[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903869#comment-16903869 ] Ivan Fedotov edited comment on IGNITE-10973 at 8/9/19 1:05 PM: --- [~Pavlukhin], Seems that the .net problem is the last one. I brought the full context of the problem in the conversation. The problem is more general, JUnit migration looks like a consequence, not a cause. [1] http://apache-ignite-developers.2346864.n4.nabble.com/Test-naming-on-TC-JUnit-5-tp42750p42810.html was (Author: ivanan.fed): Seems that the .net problem is the last one. I brought the full context of the problem in the conversation. The problem is more general, JUnit migration looks like a consequence, not a cause. [1] http://apache-ignite-developers.2346864.n4.nabble.com/Test-naming-on-TC-JUnit-5-tp42750p42810.html > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897268#comment-16897268 ] Ivan Fedotov edited comment on IGNITE-10973 at 7/31/19 3:09 PM: [~Pavlukhin], I delivered information about migration to the community. was (Author: ivanan.fed): [~Pavlukhin] I delivered information about migration to the community. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891243#comment-16891243 ] Ivan Fedotov edited comment on IGNITE-10973 at 7/23/19 5:54 PM: [~Pavlukhin] , According to Parametrized test - I added a new dependency in the last commit. We can use @CsvSource or @ParameterizedTest/@ValueSource annotations: usage is simplier than in the fourth version. Rule and ClassRule annotations can be replaced by Extension and ExtendWith respectively. According to .net tests: the reason for failures is the only one: "The filename or extension is too long" in ExecutableTest [1]. I guess that it's jvmClasspath because other args are hardcoded. I compared the log files from my branch [2] and master [3]. For some reason, jvmClasspath contains all maven dependencies. Because of addition more dependencies to pom file, this string becomes too long for system .net function. I guess that it is not correct behavior of Classpath.cs#CreateClasspath function, because if we need to add some more dependencies to pom file, we faced this problem. Moreover, it is not jvmClasspath, it's the enumeration of all jat files. [1] [https://github.com/apache/ignite/blob/master/modules/platforms/dotnet/Apache.Ignite.Core.Tests/ExecutableTest.cs#L148] [2] [https://ci.ignite.apache.org/viewLog.html?buildId=4318302=buildResultsDiv=IgniteTests24Java8_PlatformNetLongRunning] [3] [https://ci.ignite.apache.org/viewLog.html?tab=buildLog=tree=debug=all=4381131&_focus=53179] was (Author: ivanan.fed): [~Pavlukhin] , According to Parametrized test - I added a new dependency in the last commit. We can use @CsvSource or @ParameterizedTest/@ValueSource annotations: usage is simplier than in the fourth version. Rule and ClassRule annotations can be replaced by Extension and ExtendWith respectively. According to .net tests: the reason for failures is the only one: "The filename or extension is too long" in ExecutableTest [1]. I guess that it's jvmClasspath because other args are hardcoded. I compared the log files from my branch[2] and master[3]. For some reason, jvmClasspath contains all maven dependencies. Because of addition more dependencies to pom file, this string becomes too long for system .net function. I guess that it is not correct behavior of Classpath.cs#CreateClasspath function, because if we need to add some more dependencies to pom file, we faced this problem. Moreover, it is not jvmClasspath, it's the enumeration of all jat files. [1] [https://github.com/apache/ignite/blob/master/modules/platforms/dotnet/Apache.Ignite.Core.Tests/ExecutableTest.cs#L148] [2] [https://ci.ignite.apache.org/viewLog.html?buildId=4318302=buildResultsDiv=IgniteTests24Java8_PlatformNetLongRunning] [3] [https://ci.ignite.apache.org/viewLog.html?tab=buildLog=tree=debug=all=4381131&_focus=53179] > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891243#comment-16891243 ] Ivan Fedotov edited comment on IGNITE-10973 at 7/23/19 5:44 PM: [~Pavlukhin] , According to Parametrized test - I added a new dependency in the last commit. We can use @CsvSource or @ParameterizedTest/@ValueSource annotations: usage is simplier than in the fourth version. Rule and ClassRule annotations can be replaced by Extension and ExtendWith respectively. According to .net tests: the reason for failures is the only one: "The filename or extension is too long" in ExecutableTest [1]. I guess that it's jvmClasspath because other args are hardcoded. I compared the log files from my branch[2] and master[3]. For some reason, jvmClasspath contains all maven dependencies. Because of addition more dependencies to pom file, this string becomes too long for system .net function. I guess that it is not correct behavior of Classpath.cs#CreateClasspath function, because if we need to add some more dependencies to pom file, we faced this problem. Moreover, it is not jvmClasspath, it's the enumeration of all jat files. [1] [https://github.com/apache/ignite/blob/master/modules/platforms/dotnet/Apache.Ignite.Core.Tests/ExecutableTest.cs#L148] [2] [https://ci.ignite.apache.org/viewLog.html?buildId=4318302=buildResultsDiv=IgniteTests24Java8_PlatformNetLongRunning] [3] [https://ci.ignite.apache.org/viewLog.html?tab=buildLog=tree=debug=all=4381131&_focus=53179] was (Author: ivanan.fed): [~Pavlukhin] , According to Parametrized test - I added a new dependency in the last commit. We can use @CsvSource or @ParameterizedTest/@ValueSource annotations: usage is simplier than in the fourth version. Rule and ClassRule annotations can be replaced by Extension and ExtendWith respectively. According to .net tests: the reason for failures is the only one: "The filename or extension is too long" in ExecutableTest [1]. I guess that it's jvmClasspath because other args are hardcoded. I compared the log files from my branch[2] and master[3]. For some reason, jvmClasspath contains all maven dependencies. Because of addition more dependencies to pom file, this string becomes too long for system .net function. I guess that it is not correct behavior of Classpath.cs#CreateClasspath function, because if we need to add some more dependencies to pom file, we faced this problem. Moreover, it is not jvmClasspath, it's the enumeration of all jat files. [1] https://github.com/apache/ignite/blob/master/modules/platforms/dotnet/Apache.Ignite.Core.Tests/ExecutableTest.cs#L148 [2] https://ci.ignite.apache.org/viewLog.html?buildId=4318302=buildResultsDiv=IgniteTests24Java8_PlatformNetLongRunning [3] https://ci.ignite.apache.org/viewLog.html?tab=buildLog=tree=debug=all=4381131&_focus=53179 > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876385#comment-16876385 ] Ivan Fedotov edited comment on IGNITE-10973 at 7/1/19 5:49 PM: --- [~Pavlukhin] , part of the name in parentheses means path. In the case, where names are different in the version before path consists from "path to suite: path to test" and in the version after just "path to test". I tried to find the place in the code where it is constructed. It seems that TC took this path from JUnit and it does not configure inside Ignite. But maybe I am wrong and we can configure it from TC. [~ein] could you please clarify is it possible to configure test name in parentheses in TC? was (Author: ivanan.fed): [~Pavlukhin] , part of the name in parentheses means path. In the case, where names are different in the version before path consists from "path to suite: path to test" and in the version after just "path to test". I tried to find the place in the code where it is constructed. It seems that TC took this path from JUnit and it does not configure inside Ignite. But maybe I am wrong and we can configure it from TC. [~ein] could you please clarify is it possible to configure test name in parentheses in TC? > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871123#comment-16871123 ] Ivan Pavlukhin edited comment on IGNITE-10973 at 6/24/19 12:30 PM: --- [~ivanan.fed], indeed it seems that test naming is slightly differently reported before and after your changes related to junit/surefire. I suppose you can run some tests locally and inspect a content of target/surefire-reports directory to see the changes in test naming. I think using old-style naming would simplify further steps. (In TC a test history [before|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=8336299505643909339=testDetails] and [after|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=-1971297263913571970=testDetails] part of names in parentheses are different.) Also about ignores related to IGNITE-711. I think it worth starting a discussion on dev-list about removing referred examples at all as the ticket seems too outdated. It hints that there is no need for it in practice. was (Author: pavlukhin): [~ivanan.fed], indeed it seems that test naming is slightly differently reported before and after your changes related to junit/surefire. I suppose you can run some tests locally and inspect a content of target/surefire-reports directory to see the changes in test naming. I think using old-style naming would simplify further steps. Also about ignores related to IGNITE-711. I think it worth starting a discussion on dev-list about removing referred examples at all as the ticket seems too outdated. It hints that there is no need for it in practice. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871123#comment-16871123 ] Ivan Pavlukhin edited comment on IGNITE-10973 at 6/24/19 12:30 PM: --- [~ivanan.fed], indeed it seems that test naming is slightly differently reported before and after your changes related to junit/surefire. I suppose you can run some tests locally and inspect a content of target/surefire-reports directory to see the changes in test naming. I think using old-style naming would simplify further steps. (In TC test history [before|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=8336299505643909339=testDetails] and [after|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=-1971297263913571970=testDetails] part of names in parentheses are different.) Also about ignores related to IGNITE-711. I think it worth starting a discussion on dev-list about removing referred examples at all as the ticket seems too outdated. It hints that there is no need for it in practice. was (Author: pavlukhin): [~ivanan.fed], indeed it seems that test naming is slightly differently reported before and after your changes related to junit/surefire. I suppose you can run some tests locally and inspect a content of target/surefire-reports directory to see the changes in test naming. I think using old-style naming would simplify further steps. (In TC a test history [before|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=8336299505643909339=testDetails] and [after|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=-1971297263913571970=testDetails] part of names in parentheses are different.) Also about ignores related to IGNITE-711. I think it worth starting a discussion on dev-list about removing referred examples at all as the ticket seems too outdated. It hints that there is no need for it in practice. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749672#comment-16749672 ] Ivan Fedotov edited comment on IGNITE-10973 at 1/24/19 2:18 PM: (i) It seems that @Runwith(Suite.class) annotation support is via JUnitPlatform Runner, but at that moment it is not executed directly on the JUnit Platform [1]. Practically that means that reporting in an IDE, particularly in IntelliJ IDEA, is not full. So, I decided to leave testsuites classes with such annotation on JUnit4. P.S. The similar issue about ```@RunWith(JUnit4.class)``` can be resolved with merge of the relate ticket https://issues.apache.org/jira/browse/IGNITE-10758/ [1] https://stackoverflow.com/questions/50565724/are-test-suites-considered-deprecated-in-junit5 was (Author: ivanan.fed): (i) It seems that @Runwith(Suite.class) annotation support is via JUnitPlatform Runner, but at that moment it is not executed directly on the JUnit Platform [1]. Practically that means that reporting in an IDE, particularly in IntelliJ IDEA, is not full. So, I decided to leave testsuites classes with such annotation on JUnit4. P.S. This issue can be resolved with merge of relate ticket https://issues.apache.org/jira/browse/IGNITE-10758/ [1] https://stackoverflow.com/questions/50565724/are-test-suites-considered-deprecated-in-junit5 > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749672#comment-16749672 ] Ivan Fedotov edited comment on IGNITE-10973 at 1/24/19 2:20 PM: (i) It seems that _@Runwith(Suite.class)_ annotation support is via JUnitPlatform Runner, but at that moment it is not executed directly on the JUnit Platform [1]. Practically that means that reporting in an IDE, particularly in IntelliJ IDEA, is not full. So, I decided to leave testsuites classes with such annotation on JUnit4. P.S. The similar issue about _@RunWith(JUnit4.class)_ can be resolved with merge of the relate ticket https://issues.apache.org/jira/browse/IGNITE-10758/ [1] https://stackoverflow.com/questions/50565724/are-test-suites-considered-deprecated-in-junit5 was (Author: ivanan.fed): (i) It seems that @Runwith(Suite.class) annotation support is via JUnitPlatform Runner, but at that moment it is not executed directly on the JUnit Platform [1]. Practically that means that reporting in an IDE, particularly in IntelliJ IDEA, is not full. So, I decided to leave testsuites classes with such annotation on JUnit4. P.S. The similar issue about ```@RunWith(JUnit4.class)``` can be resolved with merge of the relate ticket https://issues.apache.org/jira/browse/IGNITE-10758/ [1] https://stackoverflow.com/questions/50565724/are-test-suites-considered-deprecated-in-junit5 > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749672#comment-16749672 ] Ivan Fedotov edited comment on IGNITE-10973 at 1/24/19 1:59 PM: (i) It seems that @Runwith(Suite.class) annotation support is via JUnitPlatform Runner, but at that moment it is not executed directly on the JUnit Platform [1]. Practically that means that reporting in an IDE, particularly in IntelliJ IDEA, is not full. So, I decided to leave testsuites classes with such annotation on JUnit4. P.S. This issue can be resolved with merge of relate ticket https://issues.apache.org/jira/browse/IGNITE-10758/ [1] https://stackoverflow.com/questions/50565724/are-test-suites-considered-deprecated-in-junit5 was (Author: ivanan.fed): (i) It seems that @Runwith(Suite.class) annotation support is via JUnitPlatform Runner, but at that moment it is not executed directly on the JUnit Platform [1]. Practically that means that reporting in an IDE, particularly in IntelliJ IDEA, is not full. So, I decided to leave testsuites classes with such annotation on JUnit4. [1] https://stackoverflow.com/questions/50565724/are-test-suites-considered-deprecated-in-junit5 > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
