[jira] [Comment Edited] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876072#comment-16876072 ] Sergey Chugunov edited comment on IGNITE-11844 at 7/1/19 10:30 AM: --- [~6uest], I reviewed latest patch, it looks good to me now. Please proceed with merging and thank you for the contribution! [~DmitriyGovorukhin], could you please take a look and merge this change to master? was (Author: sergey-chugunov): [~6uest], I reviewed latest patch, it looks good to me now. Please proceed with merging and thank you for the contribution! > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856566#comment-16856566 ] Vladislav Pyatkov edited comment on IGNITE-11844 at 6/5/19 10:12 AM: - [~6uest] I look at your commit and have one question: Why you using {{ThreadLocalRandom}}, when the method ({{testValidateSingleCacheShouldNotTriggerCacheGroupValidation()}}) can be used from one thread only? Is rely necessary to use random values here? (I think predefined values will be enough there - for example {{i}} instead of {{rand.nextInt()}}). was (Author: v.pyatkov): [~6uest] I look at your commit and have one question: Why you using {{ThreadLocalRandom}}, when the method ({{testValidateSingleCacheShouldNotTriggerCacheGroupValidation()}}) can be used from one thread only? Is rely necessary to use random values here? (I think predefined values will be enough there - for example {{i}} instead of {{rand.nextInt()}}.) > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-11844) Should to filtered indexes by cache name instead of validate all caches in group
[ https://issues.apache.org/jira/browse/IGNITE-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856566#comment-16856566 ] Vladislav Pyatkov edited comment on IGNITE-11844 at 6/5/19 10:12 AM: - [~6uest] I look at your commit and have one question: Why you using {{ThreadLocalRandom}}, when the method ({{testValidateSingleCacheShouldNotTriggerCacheGroupValidation()}}) can be used from one thread only? Is rely necessary to use random values here? (I think predefined values will be enough there - for example {{i}} instead of {{rand.nextInt()}}.) was (Author: v.pyatkov): [~6uest] I look at your commit and have one question: Why you using {{ThreadLocalRandom}}, when the method ({{testValidateSingleCacheShouldNotTriggerCacheGroupValidation()}}) can be used from one thread only? Is rely necessary to use random values here? (I think predefined values will be enough there - for example i instead of {{rand.nextInt()}}.) > Should to filtered indexes by cache name instead of validate all caches in > group > > > Key: IGNITE-11844 > URL: https://issues.apache.org/jira/browse/IGNITE-11844 > Project: Ignite > Issue Type: Bug >Reporter: Vladislav Pyatkov >Assignee: Andrey Kalinin >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > control.sh utility method validate_indexes checks all indexes of all caches > in group. Just do specify one caches (from generic group) in caches list, > then all indexes from all caches (that group) will be start to validate and > this can consume more time, than checks indexes only specified caches. > Will be correct to validate only indexes of specified caches, for the purpose > need to filtered caches, by list from parameters, in shared group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)