[jira] [Comment Edited] (IGNITE-1572) .Net: Check if we can get rid of "WritePortableOrSerializable" method.

2015-10-12 Thread Pavel Tupitsyn (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952943#comment-14952943
 ] 

Pavel  Tupitsyn edited comment on IGNITE-1572 at 10/12/15 11:28 AM:


1) I have fixed TestPortableObjectInTask by adding a wrapper in the test 
itself. This use is very unlikely, so we can tell users to create their own 
wrapper (which is trivial).
2) Actually, this looks like correct behavior. Wrapped serializable type may be 
not present on some remote node, so we return IPortableObject. And if the type 
is present, calling IPortableObject.Deserialize will return correct result.


was (Author: ptupitsyn):
1) I have fixed TestPortableObjectInTask by adding a wrapper in the test 
itself. This use is very unlikely, so we can tell users to create their own 
wrapper (which is trivial).
2) .

> .Net: Check if we can get rid of "WritePortableOrSerializable" method.
> --
>
> Key: IGNITE-1572
> URL: https://issues.apache.org/jira/browse/IGNITE-1572
> Project: Ignite
>  Issue Type: Task
>  Components: interop
>Affects Versions: ignite-1.4
>Reporter: Vladimir Ozerov
>Assignee: Pavel  Tupitsyn
>Priority: Critical
> Fix For: 1.5
>
>
> We have lots of places where "WritePortableOrSerializable" routine is 
> invoked. It is not clear why do we need it provided that we already handle 
> [Serializable] classes properly. 
> Looks like we are able to get rid of it safely, aren't we? Need to 
> double-check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (IGNITE-1572) .Net: Check if we can get rid of "WritePortableOrSerializable" method.

2015-10-09 Thread Pavel Tupitsyn (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941040#comment-14941040
 ] 

Pavel  Tupitsyn edited comment on IGNITE-1572 at 10/9/15 10:13 AM:
---

Good catch, I have removed these wrappers, since we have 
SerializableObjectHolder in Writer/Reader.
However, one test (TestPortableObjectInTask) has failed. We have 2 issues:
* .Net writes user objects as FullObj (103) or PortObj (27), but Java always 
returns them as PortObj (27), so we loose that information. Removed wrappers 
indirectly solved that problem.
* In KeepPortable mode with Serializable object, we return PortableUserObject 
[SerializableObjectHolder] to the user, which is a bug, caused by the first 
issue.


was (Author: ptupitsyn):
Good catch, I have remove these wrappers, since we have 
SerializableObjectHolder in Writer/Reader.
However, one test (TestPortableObjectInTask) has failed. We have 2 issues:
* .Net writes user objects as FullObj (103) or PortObj (27), but Java always 
returns them as PortObj (27), so we loose that information. Removed wrappers 
indirectly solved that problem.
* In KeepPortable mode with Serializable object, we return PortableUserObject 
[SerializableObjectHolder] to the user, which is a bug, causes by the first 
issue.

> .Net: Check if we can get rid of "WritePortableOrSerializable" method.
> --
>
> Key: IGNITE-1572
> URL: https://issues.apache.org/jira/browse/IGNITE-1572
> Project: Ignite
>  Issue Type: Task
>  Components: interop
>Affects Versions: ignite-1.4
>Reporter: Vladimir Ozerov
>Assignee: Pavel  Tupitsyn
>Priority: Critical
> Fix For: 1.5
>
>
> We have lots of places where "WritePortableOrSerializable" routine is 
> invoked. It is not clear why do we need it provided that we already handle 
> [Serializable] classes properly. 
> Looks like we are able to get rid of it safely, aren't we? Need to 
> double-check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)