[jira] [Comment Edited] (IGNITE-4770) Script inside javadoc bottom cause compilation error at 1.8.0_121-b13
[
https://issues.apache.org/jira/browse/IGNITE-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892298#comment-15892298
]
Vyacheslav Daradur edited comment on IGNITE-4770 at 3/2/17 2:11 PM:
[~avinogradov],
Master and ignite-2.0 branches have the same problem.
If this fix is good, makes sense to copy it in other branches.
was (Author: daradurvs):
[~avinogradov],
Master and ignite-2.0 branches have the same problem.
If this fix good, makes sense to copy it in other branches.
> Script inside javadoc bottom cause compilation error at 1.8.0_121-b13
> -
>
> Key: IGNITE-4770
> URL: https://issues.apache.org/jira/browse/IGNITE-4770
> Project: Ignite
> Issue Type: Bug
> Components: build
>Reporter: Anton Vinogradov
>Assignee: Vyacheslav Daradur
> Fix For: 1.9
>
>
> Problem:
> parent/pom.xml:455 contains following:
> {noformat}
> !function(d,s,id){var
> js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document,
> 'script', 'twitter-wjs');
> {noformat}
> this script generates "Follow us" at the bottom of the
> incubator-ignite/target/javadoc/core/index.html.
> this cause compilation error during
> {noformat}
> mvn clean package -DskipTests
> {noformat}
> error
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.1:jar (module-javadoc) on
> project ignite-tools: MavenReportException: Error while creating archive:
> [ERROR] Exit code: 1 - javadoc: error - Argument for -bottom contains
> JavaScript.
> [ERROR] Use --allow-script-in-comments to allow use of JavaScript.
> {noformat}
> addition of "--allow-script-in-comments"
> cause compilation issues on any JDK8 before 1.8.0_121-b13
> {noformat}
> [ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-javadoc-plugin:2.10.1:jar (module-javadoc) on project ignite-tools:
> MavenReportException: Error while creating archive:
> [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> --allow-script-in-comments
> {noformat}
> Solution:
> Need to keep button at the bottom of the page, but fix compilation errors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (IGNITE-4770) Script inside javadoc bottom cause compilation error at 1.8.0_121-b13
[
https://issues.apache.org/jira/browse/IGNITE-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892298#comment-15892298
]
Vyacheslav Daradur edited comment on IGNITE-4770 at 3/2/17 2:10 PM:
[~avinogradov],
Master and ignite-2.0 branches have the same problem.
If this fix good, makes sense to copy it in other branches.
was (Author: daradurvs):
[~avinogradov],
Master and ignite-2.0 have same problem.
If this fix good, makes sense to copy it to another branches.
> Script inside javadoc bottom cause compilation error at 1.8.0_121-b13
> -
>
> Key: IGNITE-4770
> URL: https://issues.apache.org/jira/browse/IGNITE-4770
> Project: Ignite
> Issue Type: Bug
> Components: build
>Reporter: Anton Vinogradov
>Assignee: Vyacheslav Daradur
> Fix For: 1.9
>
>
> Problem:
> parent/pom.xml:455 contains following:
> {noformat}
> !function(d,s,id){var
> js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document,
> 'script', 'twitter-wjs');
> {noformat}
> this script generates "Follow us" at the bottom of the
> incubator-ignite/target/javadoc/core/index.html.
> this cause compilation error during
> {noformat}
> mvn clean package -DskipTests
> {noformat}
> error
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.1:jar (module-javadoc) on
> project ignite-tools: MavenReportException: Error while creating archive:
> [ERROR] Exit code: 1 - javadoc: error - Argument for -bottom contains
> JavaScript.
> [ERROR] Use --allow-script-in-comments to allow use of JavaScript.
> {noformat}
> addition of "--allow-script-in-comments"
> cause compilation issues on any JDK8 before 1.8.0_121-b13
> {noformat}
> [ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-javadoc-plugin:2.10.1:jar (module-javadoc) on project ignite-tools:
> MavenReportException: Error while creating archive:
> [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> --allow-script-in-comments
> {noformat}
> Solution:
> Need to keep button at the bottom of the page, but fix compilation errors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
