[jira] [Comment Edited] (IGNITE-7648) Revert IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450141#comment-16450141 ] Alexei Scherbakov edited comment on IGNITE-7648 at 4/24/18 4:24 PM: [~agoncharuk] I suppose you're right. I reverted a change which removes property. PR and TC linked to the tickets. Please review. was (Author: ascherbakov): [~agoncharuk] I suppose you're right. I reverted change which removes property. PR and TC linked to the tickets. Please review. > Revert IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Alexei Scherbakov >Priority: Major > Fix For: 2.6 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-7648) Revert IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365433#comment-16365433 ] Alexei Scherbakov edited comment on IGNITE-7648 at 2/15/18 11:52 AM: - Property is removed, added addititnal waits and retries if connection to socket was unsuccessful by some other reason than timeout. Code in communication is slightly cleaned up. TC result, looks acceptable https://ci.ignite.apache.org/viewLog.html?buildId=1094577 was (Author: ascherbakov): Property is removed, added addititnal waits and retrys if connection to socket was unsuccessful by some other reason than timeout. Code in communication is slightly cleaned up. TC result, looks acceptable https://ci.ignite.apache.org/viewLog.html?buildId=1094577 > Revert IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Alexei Scherbakov >Priority: Major > Fix For: 2.5 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-7648) Revert IGNITE_ENABLE_FORCIBLE_NODE_KILL system property.
[ https://issues.apache.org/jira/browse/IGNITE-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365433#comment-16365433 ] Alexei Scherbakov edited comment on IGNITE-7648 at 2/15/18 11:51 AM: - Property is removed, added addititnal waits and retrys if connection to socket was unsuccessful by some other reason than timeout. Code in communication is slightly cleaned up. TC result, looks acceptable https://ci.ignite.apache.org/viewLog.html?buildId=1094577 was (Author: ascherbakov): TC result, looks acceptable https://ci.ignite.apache.org/viewLog.html?buildId=1094577 > Revert IGNITE_ENABLE_FORCIBLE_NODE_KILL system property. > > > Key: IGNITE-7648 > URL: https://issues.apache.org/jira/browse/IGNITE-7648 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.3 >Reporter: Alexei Scherbakov >Assignee: Alexei Scherbakov >Priority: Major > Fix For: 2.5 > > > IGNITE_ENABLE_FORCIBLE_NODE_KILL system property was introduced in > IGNITE-5718 as a way to prevent unnecessary node drops in case of short > network problems. > I suppose it's wrong decision to fix it in such way. > We had faced some issues in our production due to lack of automatic kicking > of ill-behaving nodes (on example, hanging due to long GC pauses) until we > realised the necessity of changing default behavior via property. > Right solution is to kick nodes only if failure threshold is reached. Such > behavior should be always enabled. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
