[jira] [Commented] (IGNITE-1018) Node local map is not available when LifecycleEventType.BEFORE_NODE_START is processed in lifecycle bean

[Andrey Velichko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422529#comment-15422529
 ] 

Andrey Velichko commented on IGNITE-1018:
-

Please, make review changes. Pull request 
https://github.com/apache/ignite/pull/812
Added unit test IgniteClusterSelfTest, LifecycleExample was revert.

> Node local map is not available when LifecycleEventType.BEFORE_NODE_START is 
> processed in lifecycle bean
> 
>
> Key: IGNITE-1018
> URL: https://issues.apache.org/jira/browse/IGNITE-1018
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: sprint-4
>Reporter: Valentin Kulichenko
>Assignee: Andrey Velichko
>  Labels: Usability, newbie
>
> Currently {{IgniteCluster.nodeLocalMap()}} method is guarded by gateway like 
> all others. But this is just a local concurrent map which is already 
> available at the moment LifecycleEventType.BEFORE_NODE_START is processed, so 
> I think it will be good to make it available in lifecycle bean.
> This can be useful if user needs to initialize some resources and put them to 
> node local map before node is started.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1018) Node local map is not available when LifecycleEventType.BEFORE_NODE_START is processed in lifecycle bean

[Semen Boikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346203#comment-15346203
 ] 

Semen Boikov commented on IGNITE-1018:
--

Andrey, 

Reviewed your changes, I don't think we need change LifecycleExample, please 
instead add test verifying that problem is fixed.

Thanks

> Node local map is not available when LifecycleEventType.BEFORE_NODE_START is 
> processed in lifecycle bean
> 
>
> Key: IGNITE-1018
> URL: https://issues.apache.org/jira/browse/IGNITE-1018
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: sprint-4
>Reporter: Valentin Kulichenko
>Assignee: Andrey Velichko
>  Labels: Usability, newbie
>
> Currently {{IgniteCluster.nodeLocalMap()}} method is guarded by gateway like 
> all others. But this is just a local concurrent map which is already 
> available at the moment LifecycleEventType.BEFORE_NODE_START is processed, so 
> I think it will be good to make it available in lifecycle bean.
> This can be useful if user needs to initialize some resources and put them to 
> node local map before node is started.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1018) Node local map is not available when LifecycleEventType.BEFORE_NODE_START is processed in lifecycle bean

[Andrey Velichko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344087#comment-15344087
 ] 

Andrey Velichko commented on IGNITE-1018:
-

Ignite\modules\core\src\main\java\org\apache\ignite\internal\cluster\IgniteClusterImpl.java
public  ConcurrentMap nodeLocalMap() {
удалил блокировку guard() / unguard()
 
ignite\examples\src\main\java\org\apache\ignite\examples\misc\lifecycle\LifecycleExample.java
Добавил в пример счетчик событий

 + IgniteCluster cluster = ignite.cluster();
 + ConcurrentMap map = cluster.nodeLocalMap();
 + Integer val = (Integer)map.getOrDefault(evt, 0);
 + map.put(evt, val + 1); // event counter



> Node local map is not available when LifecycleEventType.BEFORE_NODE_START is 
> processed in lifecycle bean
> 
>
> Key: IGNITE-1018
> URL: https://issues.apache.org/jira/browse/IGNITE-1018
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: sprint-4
>Reporter: Valentin Kulichenko
>Assignee: Andrey Velichko
>  Labels: Usability, newbie
>
> Currently {{IgniteCluster.nodeLocalMap()}} method is guarded by gateway like 
> all others. But this is just a local concurrent map which is already 
> available at the moment LifecycleEventType.BEFORE_NODE_START is processed, so 
> I think it will be good to make it available in lifecycle bean.
> This can be useful if user needs to initialize some resources and put them to 
> node local map before node is started.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1018) Node local map is not available when LifecycleEventType.BEFORE_NODE_START is processed in lifecycle bean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335839#comment-15335839
 ] 

ASF GitHub Bot commented on IGNITE-1018:


GitHub user AndreyVel opened a pull request:

https://github.com/apache/ignite/pull/812

IGNITE-1018

Node local map is not available when LifecycleEventType.BEFORE_NODE_START 
is processed in lifecycle bean

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AndreyVel/ignite ignite-1018

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/812.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #812


commit a56c8b3140bf9af7f562f4cec879278e4fa0e699
Author: AndreyVel 
Date:   2016-06-17T09:54:00Z

IGNITE-1018

Node local map is not available when LifecycleEventType.BEFORE_NODE_START 
is processed in lifecycle bean




> Node local map is not available when LifecycleEventType.BEFORE_NODE_START is 
> processed in lifecycle bean
> 
>
> Key: IGNITE-1018
> URL: https://issues.apache.org/jira/browse/IGNITE-1018
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: sprint-4
>Reporter: Valentin Kulichenko
>  Labels: Usability, newbie
>
> Currently {{IgniteCluster.nodeLocalMap()}} method is guarded by gateway like 
> all others. But this is just a local concurrent map which is already 
> available at the moment LifecycleEventType.BEFORE_NODE_START is processed, so 
> I think it will be good to make it available in lifecycle bean.
> This can be useful if user needs to initialize some resources and put them to 
> node local map before node is started.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)