[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686555#comment-16686555
]
ASF GitHub Bot commented on IGNITE-10228:
-
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/5377
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Fix For: 2.8
>
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686422#comment-16686422
]
Pavel Kovalenko commented on IGNITE-10228:
--
[~voropava] I've reviewed your changes. Looks good to me.
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Fix For: 2.8
>
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686396#comment-16686396
]
Pavel Voronkin commented on IGNITE-10228:
-
https://reviews.ignite.apache.org/ignite/review/IGNT-CR-963
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Fix For: 2.8
>
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686344#comment-16686344
]
Pavel Kovalenko commented on IGNITE-10228:
--
[~voropava] Thank you for contribution. Could you please review at
https://reviews.ignite.apache.org for the change?
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686167#comment-16686167
]
Ignite TC Bot commented on IGNITE-10228:
{panel:title=No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity Run All
Results|http://ci.ignite.apache.org/viewLog.html?buildId=2314457buildTypeId=IgniteTests24Java8_InspectionsCore]
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686082#comment-16686082
]
Ignite TC Bot commented on IGNITE-10228:
{panel:title=Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric
|https://ci.ignite.apache.org/viewLog.html?buildId=2309009]]
{panel}
[TeamCity Run All
Results|http://ci.ignite.apache.org/viewLog.html?buildId=2309013buildTypeId=IgniteTests24Java8_RunAll]
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686042#comment-16686042
]
Ignite TC Bot commented on IGNITE-10228:
{panel:title=Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric
|https://ci.ignite.apache.org/viewLog.html?buildId=2309009]]
{color:#d04437}_Licenses Headers_{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=2312975]]
{panel}
[TeamCity Run All
Results|http://ci.ignite.apache.org/viewLog.html?buildId=2309013buildTypeId=IgniteTests24Java8_RunAll]
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686041#comment-16686041
]
ASF GitHub Bot commented on IGNITE-10228:
-
GitHub user voropava reopened a pull request:
https://github.com/apache/ignite/pull/5377
IGNITE-10228 Start multiple caches in parallel may lead to the fact that
some of the caches won't be registered.
…suboptimal batch splitting in U.doInParallel().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-10228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5377
commit 3a146d54ca6eef07a90fafc1ac4ce6f0deeda5a6
Author: Pavel Voronkin
Date: 2018-08-14T18:20:50Z
IGNITE-10028 Fixed race on addCacheContext/removeCacheContext, fixed
suboptimal batch splitting in U.doInParallel().
commit 8c93ced97960a85fd4d2a24e1fdefaa3e75bebda
Author: Pavel Voronkin
Date: 2018-08-14T18:20:50Z
IGNITE-10028 Review fixes.
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686040#comment-16686040
]
ASF GitHub Bot commented on IGNITE-10228:
-
Github user voropava closed the pull request at:
https://github.com/apache/ignite/pull/5377
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Voronkin
>Priority: Major
> Attachments: CacheStartingParallelTest.java
>
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684240#comment-16684240
]
Alexey Goncharuk commented on IGNITE-10228:
---
No, the cause was not merged to ignite-2.7.
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Priority: Major
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10228) Start multiple caches in parallel may lead to the fact that some of the caches won't be registered.
[
https://issues.apache.org/jira/browse/IGNITE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684223#comment-16684223
]
Eduard Shangareev commented on IGNITE-10228:
should we add it for 2.7?
> Start multiple caches in parallel may lead to the fact that some of the
> caches won't be registered.
> ---
>
> Key: IGNITE-10228
> URL: https://issues.apache.org/jira/browse/IGNITE-10228
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.6
>Reporter: Vyacheslav Koptilin
>Priority: Major
>
> It looks like the root cause of the issue is that
> {{CacheGroupContext.addCacheContext()}} (which is called in parallel) does
> not use a lock/semaphore in order to synchronize {{caches}} updates.
>
> {code:java}
> private void addCacheContext(GridCacheContext cctx) {
> ArrayList caches = new ArrayList<>(this.caches);
> boolean add = caches.add(cctx);
> ...
> this.caches = caches;
> }
> {code}
>
> The possible workaround is to disable parallel start of caches by setting the
> {{IGNITE_ALLOW_START_CACHES_IN_PARALLEL}} property to {{false}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
