[jira] [Commented] (IGNITE-10239) Web Console: Create a new top menu
[ https://issues.apache.org/jira/browse/IGNITE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722827#comment-16722827 ] ASF GitHub Bot commented on IGNITE-10239: - Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5630 > Web Console: Create a new top menu > -- > > Key: IGNITE-10239 > URL: https://issues.apache.org/jira/browse/IGNITE-10239 > Project: Ignite > Issue Type: Improvement > Components: UI, wizards >Reporter: Vica Abramova >Assignee: Andrey Novikov >Priority: Major > Attachments: Top-ignite-menu.png, navigation links block scroll > example.png, new design example.png > > Time Spent: 11h 13m > Remaining Estimate: 0h > > New navigation menu design moves navigation to left sidebar in order to save > some vertical space. The sidebar with navigation links has two modes - > collapsed, with icon-only link, and expanded, with full-text links. By > default, it's kept collapsed, but user can click on toggle sidebar button > left of logo to expand or collapse it again. For now, the sidebar state does > not persist between page reloads. The footer should be moved to expanded > sidebar, except for public screens like "sign in" or "reset password". > Navigation links block in sidebar should scroll and indicate that some > content is hidden when viewport height is low enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10239) Web Console: Create a new top menu
[ https://issues.apache.org/jira/browse/IGNITE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721026#comment-16721026 ] Ilya Borisov commented on IGNITE-10239: --- [~anovikov] all done. > Web Console: Create a new top menu > -- > > Key: IGNITE-10239 > URL: https://issues.apache.org/jira/browse/IGNITE-10239 > Project: Ignite > Issue Type: Improvement > Components: UI, wizards >Reporter: Vica Abramova >Assignee: Andrey Novikov >Priority: Major > Attachments: Top-ignite-menu.png, navigation links block scroll > example.png, new design example.png > > Time Spent: 10h 55m > Remaining Estimate: 0h > > New navigation menu design moves navigation to left sidebar in order to save > some vertical space. The sidebar with navigation links has two modes - > collapsed, with icon-only link, and expanded, with full-text links. By > default, it's kept collapsed, but user can click on toggle sidebar button > left of logo to expand or collapse it again. For now, the sidebar state does > not persist between page reloads. The footer should be moved to expanded > sidebar, except for public screens like "sign in" or "reset password". > Navigation links block in sidebar should scroll and indicate that some > content is hidden when viewport height is low enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10239) Web Console: Create a new top menu
[ https://issues.apache.org/jira/browse/IGNITE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721000#comment-16721000 ] Andrey Novikov commented on IGNITE-10239: - [~Klaster_1] I added several comments in GitHub PR, please check them out. > Web Console: Create a new top menu > -- > > Key: IGNITE-10239 > URL: https://issues.apache.org/jira/browse/IGNITE-10239 > Project: Ignite > Issue Type: Improvement > Components: UI, wizards >Reporter: Vica Abramova >Assignee: Andrey Novikov >Priority: Major > Attachments: Top-ignite-menu.png, navigation links block scroll > example.png, new design example.png > > Time Spent: 10h 55m > Remaining Estimate: 0h > > New navigation menu design moves navigation to left sidebar in order to save > some vertical space. The sidebar with navigation links has two modes - > collapsed, with icon-only link, and expanded, with full-text links. By > default, it's kept collapsed, but user can click on toggle sidebar button > left of logo to expand or collapse it again. For now, the sidebar state does > not persist between page reloads. The footer should be moved to expanded > sidebar, except for public screens like "sign in" or "reset password". > Navigation links block in sidebar should scroll and indicate that some > content is hidden when viewport height is low enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10239) Web Console: Create a new top menu
[ https://issues.apache.org/jira/browse/IGNITE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719910#comment-16719910 ] Ilya Borisov commented on IGNITE-10239: --- [~pkonstantinov] can you test the branch while Andrey performs the review? > Web Console: Create a new top menu > -- > > Key: IGNITE-10239 > URL: https://issues.apache.org/jira/browse/IGNITE-10239 > Project: Ignite > Issue Type: Improvement > Components: UI, wizards >Reporter: Vica Abramova >Assignee: Andrey Novikov >Priority: Major > Attachments: Top-ignite-menu.png, navigation links block scroll > example.png, new design example.png > > Time Spent: 10h 55m > Remaining Estimate: 0h > > New navigation menu design moves navigation to left sidebar in order to save > some vertical space. The sidebar with navigation links has two modes - > collapsed, with icon-only link, and expanded, with full-text links. By > default, it's kept collapsed, but user can click on toggle sidebar button > left of logo to expand or collapse it again. For now, the sidebar state does > not persist between page reloads. The footer should be moved to expanded > sidebar, except for public screens like "sign in" or "reset password". > Navigation links block in sidebar should scroll and indicate that some > content is hidden when viewport height is low enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10239) Web Console: Create a new top menu
[ https://issues.apache.org/jira/browse/IGNITE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716114#comment-16716114 ] ASF GitHub Bot commented on IGNITE-10239: - GitHub user Klaster1 opened a pull request: https://github.com/apache/ignite/pull/5630 IGNITE-10239 Update navigation and top menu https://issues.apache.org/jira/browse/IGNITE-10239 @nva please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10239 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5630.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5630 commit 9d578e25759351a231b1c6f62ebb54293031f793 Author: Ilya Borisov Date: 2018-11-26T10:11:02Z IGNITE-10239 Update top menu, navigation and footer. commit 6980be0dae42cd1760f7a384cad1ea466a5f3c9e Author: Ilya Borisov Date: 2018-12-05T09:47:12Z IGNITE-10239 Use old-style footer on certain pages. commit 1e38cc13cc1a2f608268885e6168058fba064476 Author: Ilya Borisov Date: 2018-12-06T04:48:01Z IGNITE-10239 Add configuration icon. commit 8b3b8ba356b0da66d178108e9b57721a8c26a2b0 Author: Ilya Borisov Date: 2018-12-06T07:09:13Z IGNITE-10239 Fix page side paddings. commit 1cc228075bc814bdc445720dfc75bcd055bf085f Author: Ilya Borisov Date: 2018-12-06T07:10:59Z IGNITE-10239 Fix navigation icon height. commit aa5874251d5d3fc8fd42feeea1c22deac33e4ae8 Author: Ilya Borisov Date: 2018-12-06T07:28:47Z IGNITE-10239 More padding fixes. commit 365f6adc9e085688cc1380fd27a267aa67cc5601 Author: Ilya Borisov Date: 2018-12-06T07:29:28Z IGNITE-10239 Restore footer styles on certain pages. commit 7a0e8a57db84535d82949af012072a0c8c016060 Author: Ilya Borisov Date: 2018-12-06T09:42:31Z WIP UNDO LATER commit 986d22e1ce3863d449f5a47e71b1bf48194ad087 Author: Ilya Borisov Date: 2018-12-07T03:34:55Z IGNITE-10239 Use solid background in footer. commit b45580fafedc3f18ff3e7c4307c8f090b5721f96 Author: Ilya Borisov Date: 2018-12-07T03:38:26Z IGNITE-10239 Fix password-reset-change page styles. commit ced945e6cd62fa7fadf8c556d0444877a6f50f96 Author: Ilya Borisov Date: 2018-12-07T06:18:11Z IGNITE-10239 Use class to style page bottom footer. commit 844d3f93ec4182cae891fd6ba53d7077fa3c154e Author: Ilya Borisov Date: 2018-12-07T08:32:12Z IGNITE-10239 Refactor public pages. commit cf8ce9f3e738c46538075cfd2b20973a92e995b8 Author: Ilya Borisov Date: 2018-12-10T05:53:26Z IGNITE-10239 Handle navigation items overflow. commit a7fdd67589df0f595915814eecd580a24b8bb506 Author: Ilya Borisov Date: 2018-12-10T06:38:40Z IGNITE-10239 Make nav menu items accessible by keyboard. commit df4fba7cd1219f27b74208d05f19669e1aad0a68 Author: Ilya Borisov Date: 2018-12-10T07:12:22Z IGNITE-10239 Make overflow work with page zoom. commit 33faf8acc5afa197e93d4b48b8bf9fc7309a9dac Author: Ilya Borisov Date: 2018-12-10T07:37:40Z IGNITE-10239 Add bottom padding to all pages. commit 564da7506b0f6cb10f90789fc251c0a97d2671f4 Author: Ilya Borisov Date: 2018-12-10T08:37:31Z IGNITE-10239 Safari fixes. commit 085438a8f4f6fa0f13fde86e4ff546ac8767d2ba Author: Ilya Borisov Date: 2018-12-10T09:30:21Z IGNITE-10239 Tweak some layout styles. commit a14e26eaccde699831d4f67adfa1379a67e18f56 Author: Ilya Borisov Date: 2018-12-10T09:54:45Z IGNITE-10239 Fix footer position on 404 screen. commit 6295d4ae907079fa2db998598dc666a8168fc0c5 Author: Ilya Borisov Date: 2018-12-10T10:01:16Z IGNITE-10239 Cleanup. commit 4a2aed5bf600c7f690cf647c952f51aadbc39c60 Author: Ilya Borisov Date: 2018-12-10T10:29:05Z IGNITE-10239 Fix e2e tests. > Web Console: Create a new top menu > -- > > Key: IGNITE-10239 > URL: https://issues.apache.org/jira/browse/IGNITE-10239 > Project: Ignite > Issue Type: Improvement > Components: UI, wizards >Reporter: Vica Abramova >Assignee: Andrey Novikov >Priority: Major > Attachments: Top-ignite-menu.png, navigation links block scroll > example.png, new design example.png > > Time Spent: 9h 5m > Remaining Estimate: 0h > > New navigation menu design moves navigation to left sidebar in order to save > some vertical space. The sidebar with navigation links has two modes - > collapsed, with icon-only link, and expanded, with full-text links. By > default, it's kept collapsed, but user can click on toggle sidebar button > left of logo to expand or collapse it again. For now, the sidebar state does > not persist between page reloads. The footer should be moved to expanded >
[jira] [Commented] (IGNITE-10239) Web Console: Create a new top menu
[ https://issues.apache.org/jira/browse/IGNITE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716109#comment-16716109 ] Ilya Borisov commented on IGNITE-10239: --- Extra items to test: 1. All public pages markup should remain intact. 2. All navigation links should still work, that includes links outside of navigation sidebar. > Web Console: Create a new top menu > -- > > Key: IGNITE-10239 > URL: https://issues.apache.org/jira/browse/IGNITE-10239 > Project: Ignite > Issue Type: Improvement > Components: UI, wizards >Reporter: Vica Abramova >Assignee: Ilya Borisov >Priority: Major > Attachments: Top-ignite-menu.png, navigation links block scroll > example.png, new design example.png > > Time Spent: 9h 5m > Remaining Estimate: 0h > > New navigation menu design moves navigation to left sidebar in order to save > some vertical space. The sidebar with navigation links has two modes - > collapsed, with icon-only link, and expanded, with full-text links. By > default, it's kept collapsed, but user can click on toggle sidebar button > left of logo to expand or collapse it again. For now, the sidebar state does > not persist between page reloads. The footer should be moved to expanded > sidebar, except for public screens like "sign in" or "reset password". > Navigation links block in sidebar should scroll and indicate that some > content is hidden when viewport height is low enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
