[jira] [Commented] (IGNITE-10335) move ML examples datasets files to resources
[ https://issues.apache.org/jira/browse/IGNITE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697160#comment-16697160 ] ASF GitHub Bot commented on IGNITE-10335: - Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5434 > move ML examples datasets files to resources > > > Key: IGNITE-10335 > URL: https://issues.apache.org/jira/browse/IGNITE-10335 > Project: Ignite > Issue Type: Improvement > Components: ml >Affects Versions: 2.7 >Reporter: Oleg Ignatenko >Assignee: Oleg Ignatenko >Priority: Major > Fix For: 2.8 > > > ML examples datasets files were moved from resources to some folder under > src/main/java in the course of IGNITE-10209. > This was done as a quick workaround to unblock another change. However, > resources is a more appropriate location for this kind of content and in the > course of IGNITE-10234 we discovered that there is a way to make things work > with dataset files in this folder. > Solution appears to be to rework {{SandboxMLCache}} to use > {{IgniteUtils.resolveIgnitePath}} API like it is done in > [SqlJdbcCopyExample|https://github.com/apache/ignite/blob/master/examples/src/main/java/org/apache/ignite/examples/sql/SqlJdbcCopyExample.java]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10335) move ML examples datasets files to resources
[ https://issues.apache.org/jira/browse/IGNITE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695973#comment-16695973 ] Oleg Ignatenko commented on IGNITE-10335: - (i) note inspections failure reported by TC bot above appears to be irrelevant - if needed find more details in [this comment in IGNITE-10191|https://issues.apache.org/jira/browse/IGNITE-10191?focusedCommentId=16695880=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16695880] > move ML examples datasets files to resources > > > Key: IGNITE-10335 > URL: https://issues.apache.org/jira/browse/IGNITE-10335 > Project: Ignite > Issue Type: Improvement > Components: ml >Affects Versions: 2.7 >Reporter: Oleg Ignatenko >Assignee: Oleg Ignatenko >Priority: Major > Fix For: 2.8 > > > ML examples datasets files were moved from resources to some folder under > src/main/java in the course of IGNITE-10209. > This was done as a quick workaround to unblock another change. However, > resources is a more appropriate location for this kind of content and in the > course of IGNITE-10234 we discovered that there is a way to make things work > with dataset files in this folder. > Solution appears to be to rework {{SandboxMLCache}} to use > {{IgniteUtils.resolveIgnitePath}} API like it is done in > [SqlJdbcCopyExample|https://github.com/apache/ignite/blob/master/examples/src/main/java/org/apache/ignite/examples/sql/SqlJdbcCopyExample.java]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10335) move ML examples datasets files to resources
[ https://issues.apache.org/jira/browse/IGNITE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695967#comment-16695967 ] Ignite TC Bot commented on IGNITE-10335: {panel:title=Possible Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1} {color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric |https://ci.ignite.apache.org/viewLog.html?buildId=2378822]] {panel} [TeamCity Run All Results|https://ci.ignite.apache.org/viewLog.html?buildId=2377345buildTypeId=IgniteTests24Java8_RunAll] > move ML examples datasets files to resources > > > Key: IGNITE-10335 > URL: https://issues.apache.org/jira/browse/IGNITE-10335 > Project: Ignite > Issue Type: Improvement > Components: ml >Affects Versions: 2.7 >Reporter: Oleg Ignatenko >Assignee: Oleg Ignatenko >Priority: Major > Fix For: 2.8 > > > ML examples datasets files were moved from resources to some folder under > src/main/java in the course of IGNITE-10209. > This was done as a quick workaround to unblock another change. However, > resources is a more appropriate location for this kind of content and in the > course of IGNITE-10234 we discovered that there is a way to make things work > with dataset files in this folder. > Solution appears to be to rework {{SandboxMLCache}} to use > {{IgniteUtils.resolveIgnitePath}} API like it is done in > [SqlJdbcCopyExample|https://github.com/apache/ignite/blob/master/examples/src/main/java/org/apache/ignite/examples/sql/SqlJdbcCopyExample.java]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10335) move ML examples datasets files to resources
[ https://issues.apache.org/jira/browse/IGNITE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695936#comment-16695936 ] Ignite TC Bot commented on IGNITE-10335: {panel:title=Possible Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1} {color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric |https://ci.ignite.apache.org/viewLog.html?buildId=2378457]] {color:#d04437}Queries 1{color} [[tests 7|https://ci.ignite.apache.org/viewLog.html?buildId=2378459]] * IgniteBinaryCacheQueryTestSuite: IgniteSqlQueryMinMaxTest.testMinMaxQueryPlanOnKey - 0,0% fails in last 100 master runs. * IgniteBinaryCacheQueryTestSuite: IgniteSqlQueryMinMaxTest.testMinMaxQueryPlanOnFields - 0,0% fails in last 100 master runs. * IgniteBinaryCacheQueryTestSuite: IgniteSqlQueryMinMaxTest.testGroupHavingMinMax - 0,0% fails in last 100 master runs. * IgniteBinaryCacheQueryTestSuite: IgniteSqlQueryMinMaxTest.testQueryMinMaxEmptyCache - 0,0% fails in last 100 master runs. * IgniteBinaryCacheQueryTestSuite: IgniteSqlQueryMinMaxTest.testJoinGroupMinMax - 0,0% fails in last 100 master runs. * IgniteBinaryCacheQueryTestSuite: IgniteSqlQueryMinMaxTest.testSimpleMinMaxQueryPlanOnValue - 0,0% fails in last 100 master runs. * IgniteBinaryCacheQueryTestSuite: IgniteSqlQueryMinMaxTest.testGroupMinMax - 0,0% fails in last 100 master runs. {panel} [TeamCity Run All Results|https://ci.ignite.apache.org/viewLog.html?buildId=2377345buildTypeId=IgniteTests24Java8_RunAll] > move ML examples datasets files to resources > > > Key: IGNITE-10335 > URL: https://issues.apache.org/jira/browse/IGNITE-10335 > Project: Ignite > Issue Type: Improvement > Components: ml >Affects Versions: 2.7 >Reporter: Oleg Ignatenko >Assignee: Oleg Ignatenko >Priority: Major > Fix For: 2.8 > > > ML examples datasets files were moved from resources to some folder under > src/main/java in the course of IGNITE-10209. > This was done as a quick workaround to unblock another change. However, > resources is a more appropriate location for this kind of content and in the > course of IGNITE-10234 we discovered that there is a way to make things work > with dataset files in this folder. > Solution appears to be to rework {{SandboxMLCache}} to use > {{IgniteUtils.resolveIgnitePath}} API like it is done in > [SqlJdbcCopyExample|https://github.com/apache/ignite/blob/master/examples/src/main/java/org/apache/ignite/examples/sql/SqlJdbcCopyExample.java]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10335) move ML examples datasets files to resources
[ https://issues.apache.org/jira/browse/IGNITE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693005#comment-16693005 ] Ignite TC Bot commented on IGNITE-10335: {panel:title=No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} [TeamCity Run All Results|https://ci.ignite.apache.org/viewLog.html?buildId=2353700buildTypeId=IgniteTests24Java8_RunAll] > move ML examples datasets files to resources > > > Key: IGNITE-10335 > URL: https://issues.apache.org/jira/browse/IGNITE-10335 > Project: Ignite > Issue Type: Improvement > Components: ml >Affects Versions: 2.7 >Reporter: Oleg Ignatenko >Assignee: Oleg Ignatenko >Priority: Major > Fix For: 2.8 > > > ML examples datasets files were moved from resources to some folder under > src/main/java in the course of IGNITE-10209. > This was done as a quick workaround to unblock another change. However, > resources is a more appropriate location for this kind of content and in the > course of IGNITE-10234 we discovered that there is a way to make things work > with dataset files in this folder. > Solution appears to be to rework {{SandboxMLCache}} to use > {{IgniteUtils.resolveIgnitePath}} API like it is done in > [SqlJdbcCopyExample|https://github.com/apache/ignite/blob/master/examples/src/main/java/org/apache/ignite/examples/sql/SqlJdbcCopyExample.java]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10335) move ML examples datasets files to resources
[ https://issues.apache.org/jira/browse/IGNITE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691971#comment-16691971 ] ASF GitHub Bot commented on IGNITE-10335: - GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5434 IGNITE-10335 move ML examples datasets files to resources You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10335 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5434.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5434 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: