[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939439#comment-16939439 ] Pavel Kovalenko commented on IGNITE-11094: -- [~SomeFire] Merged dependency fix for Kafka module > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 7h > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938527#comment-16938527 ] Ignite TC Bot commented on IGNITE-11094: {panel:title=Branch: [pull/6910/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=4634438&buildTypeId=IgniteTests24Java8_RunAll] > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 6h 50m > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934221#comment-16934221 ] Ryabov Dmitrii commented on IGNITE-11094: - [~Jokser], tests are finished and have no new failures. [Zookeeper suite|https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeper?branch=pull%2F6799%2Fhead&buildTypeTab=overview] [Zookeeper (Discovery) 1 suite|https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1?branch=pull%2F6799%2Fhead&buildTypeTab=overview] [Zookeeper (Discovery) 2 suite|https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery2?branch=pull%2F6799%2Fhead&buildTypeTab=overview] [Zookeeper (Discovery) 3 suite|https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery3?branch=pull%2F6799%2Fhead&buildTypeTab=overview] [Zookeeper (Discovery) 4 suite|https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery4?branch=pull%2F6799%2Fhead&buildTypeTab=overview] > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 6.5h > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933355#comment-16933355 ] Pavel Kovalenko commented on IGNITE-11094: -- [~SomeFire] Thank you for your work on the issue. Now changes are ready to merge. Please re-run Zookeeper suites to ensure that everything works well. > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 6.5h > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928391#comment-16928391 ] Pavel Kovalenko commented on IGNITE-11094: -- [~SomeFire] I've several minor concerns about the change and left comments in PR. Please resolve them. > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927603#comment-16927603 ] Ryabov Dmitrii commented on IGNITE-11094: - Apache Zookeeper supports SSL since 3.5.x version, so, to write a test we need to update zk version (and Curator version, because it tests Zookeeper). I added {{ZookeeperDiscoverySpiSslTest}} class and edited {{ZookeeperDiscoverySpiTestBase}} class to test SSL connection. In the same time, version update requires changes in some other test classes. In {{ZookeeperDiscoveryImpl}} class I fixed a bug - with enabled custom security, NPE happens in {{ZookeeperDiscoveryImpl.validateJoiningNode}} on spi validation, because currently {{ATTR_SECURITY_SUBJECT_V2}} is placed into node attrs after validation. > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 2h > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921287#comment-16921287 ] Ignite TC Bot commented on IGNITE-11094: {panel:title=Branch: [pull/6799/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=4560949&buildTypeId=IgniteTests24Java8_RunAll] > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 2h > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918481#comment-16918481 ] Ignite TC Bot commented on IGNITE-11094: {panel:title=Branch: [pull/6799/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} [TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=4524543&buildTypeId=IgniteTests24Java8_RunAll] > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.2#803003)