[jira] [Commented] (IGNITE-11123) MVCC: Fix MvccFeatureChecker to throw assumption exception instead of failure.
[ https://issues.apache.org/jira/browse/IGNITE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758300#comment-16758300 ] Andrew Mashenkov commented on IGNITE-11123: --- [~oignatenko], Looks good. Thanks for contribution. > MVCC: Fix MvccFeatureChecker to throw assumption exception instead of failure. > -- > > Key: IGNITE-11123 > URL: https://issues.apache.org/jira/browse/IGNITE-11123 > Project: Ignite > Issue Type: Sub-task > Components: mvcc >Reporter: Andrew Mashenkov >Assignee: Oleg Ignatenko >Priority: Major > Labels: MakeTeamcityGreenAgain > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Let's rewrite MvccFeatureChecker.validateFeature() method with using JUnit4 > Assume instead of Assert.fail(). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11123) MVCC: Fix MvccFeatureChecker to throw assumption exception instead of failure.
[
https://issues.apache.org/jira/browse/IGNITE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758047#comment-16758047
]
Ignite TC Bot commented on IGNITE-11123:
{panel:title=-- Run :: All (Nightly): No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All (Nightly)*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2961902buildTypeId=IgniteTests24Java8_RunAllNightly]
> MVCC: Fix MvccFeatureChecker to throw assumption exception instead of failure.
> --
>
> Key: IGNITE-11123
> URL: https://issues.apache.org/jira/browse/IGNITE-11123
> Project: Ignite
> Issue Type: Sub-task
> Components: mvcc
>Reporter: Andrew Mashenkov
>Assignee: Oleg Ignatenko
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Let's rewrite MvccFeatureChecker.validateFeature() method with using JUnit4
> Assume instead of Assert.fail().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11123) MVCC: Fix MvccFeatureChecker to throw assumption exception instead of failure.
[
https://issues.apache.org/jira/browse/IGNITE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757611#comment-16757611
]
Ignite TC Bot commented on IGNITE-11123:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2961895buildTypeId=IgniteTests24Java8_RunAll]
> MVCC: Fix MvccFeatureChecker to throw assumption exception instead of failure.
> --
>
> Key: IGNITE-11123
> URL: https://issues.apache.org/jira/browse/IGNITE-11123
> Project: Ignite
> Issue Type: Sub-task
> Components: mvcc
>Reporter: Andrew Mashenkov
>Assignee: Oleg Ignatenko
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Let's rewrite MvccFeatureChecker.validateFeature() method with using JUnit4
> Assume instead of Assert.fail().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11123) MVCC: Fix MvccFeatureChecker to throw assumption exception instead of failure.
[ https://issues.apache.org/jira/browse/IGNITE-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754915#comment-16754915 ] Oleg Ignatenko commented on IGNITE-11123: - (i) in PR 5925 there is an example of how this can be reworked: [method skipIfNotSupported|https://github.com/apache/ignite/blob/1ee033459ac8f2ef0804029f5ce8f4caf5ddf5b6/modules/core/src/test/java/org/apache/ignite/testframework/MvccFeatureChecker.java] > MVCC: Fix MvccFeatureChecker to throw assumption exception instead of failure. > -- > > Key: IGNITE-11123 > URL: https://issues.apache.org/jira/browse/IGNITE-11123 > Project: Ignite > Issue Type: Sub-task > Components: mvcc >Reporter: Andrew Mashenkov >Priority: Major > Labels: MakeTeamcityGreenAgain > Fix For: 2.8 > > > Let's rewrite MvccFeatureChecker.validateFeature() method with using JUnit4 > Assume instead of Assert.fail(). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
