[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108162#comment-17108162
]
Alexey Scherbakov commented on IGNITE-11147:
[~v.pyatkov]
LGTM, merged to master
#a6d3f52e41dfe602a3654cc67c59f460fd0dfd4e.
Thanks for a contribution.
> Re-balance cancellation occur by non-affected event
> ---
>
> Key: IGNITE-11147
> URL: https://issues.apache.org/jira/browse/IGNITE-11147
> Project: Ignite
> Issue Type: Test
> Components: cache
>Affects Versions: 2.7
>Reporter: Sergey Antonov
>Assignee: Vladislav Pyatkov
>Priority: Critical
> Fix For: 2.9
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Re-balance cancels by non-affected events, for examples:
> 1) joining non affinity node
> 2) stating snapshot
> 3) starting/stopping other cache
> Try to skip as more as possible events instead of cancellation.
> After solved several issues appearing during this testing, I decided to add
> specific property allowing on/off rebalance's optimization. (see
> {{IgniteSystemProperties#IGNITE_DISABLE_REBALANCING_CANCELLATION_OPTIMIZATION}}
> by default false).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107086#comment-17107086
]
Ignite TC Bot commented on IGNITE-11147:
{panel:title=Branch: [pull/7428/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5304072buildTypeId=IgniteTests24Java8_RunAll]
> Re-balance cancellation occur by non-affected event
> ---
>
> Key: IGNITE-11147
> URL: https://issues.apache.org/jira/browse/IGNITE-11147
> Project: Ignite
> Issue Type: Test
> Components: cache
>Affects Versions: 2.7
>Reporter: Sergey Antonov
>Assignee: Vladislav Pyatkov
>Priority: Critical
> Fix For: 2.9
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Re-balance cancels by non-affected events, for examples:
> 1) joining non affinity node
> 2) stating snapshot
> 3) starting/stopping other cache
> Try to skip as more as possible events instead of cancellation.
> After solved several issues appearing during this testing, I decided to add
> specific property allowing on/off rebalance's optimization. (see
> {{IgniteSystemProperties#IGNITE_DISABLE_REBALANCING_CANCELLATION_OPTIMIZATION}}
> by default false).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080462#comment-17080462
]
Ignite TC Bot commented on IGNITE-11147:
{panel:title=Branch: [pull/7428/head] Base: [master] : Possible Blockers
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Long Running){color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=5211515]]
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5211314buildTypeId=IgniteTests24Java8_RunAll]
> Re-balance cancellation occur by non-affected event
> ---
>
> Key: IGNITE-11147
> URL: https://issues.apache.org/jira/browse/IGNITE-11147
> Project: Ignite
> Issue Type: Test
> Components: cache
>Affects Versions: 2.7
>Reporter: Sergey Antonov
>Assignee: Vladislav Pyatkov
>Priority: Critical
> Fix For: 2.9
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Re-balance cancels by non-affected events, for examples:
> 1) joining non affinity node
> 2) stating snapshot
> 3) starting/stopping other cache
> Try to skip as more as possible events instead of cancellation.
> After solved several issues appearing during this testing, I decided to add
> specific property allowing on/off rebalance's optimization. (see
> {{IgniteSystemProperties#IGNITE_DISABLE_REBALANCING_CANCELLATION_OPTIMIZATION}}
> by default false).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[ https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063809#comment-17063809 ] Vladislav Pyatkov commented on IGNITE-11147: [~ascherbakov] I added several changes, following your advices. Please, review this again. > Re-balance cancellation occur by non-affected event > --- > > Key: IGNITE-11147 > URL: https://issues.apache.org/jira/browse/IGNITE-11147 > Project: Ignite > Issue Type: Test > Components: cache >Affects Versions: 2.7 >Reporter: Sergey Antonov >Assignee: Vladislav Pyatkov >Priority: Critical > Fix For: 2.9 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > Re-balance cancels by non-affected events, for examples: > 1) joining non affinity node > 2) stating snapshot > 3) starting/stopping other cache > Try to skip as more as possible events instead of cancellation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063807#comment-17063807
]
Ignite TC Bot commented on IGNITE-11147:
{panel:title=Branch: [pull/7428/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5144222buildTypeId=IgniteTests24Java8_RunAll]
> Re-balance cancellation occur by non-affected event
> ---
>
> Key: IGNITE-11147
> URL: https://issues.apache.org/jira/browse/IGNITE-11147
> Project: Ignite
> Issue Type: Test
> Components: cache
>Affects Versions: 2.7
>Reporter: Sergey Antonov
>Assignee: Vladislav Pyatkov
>Priority: Critical
> Fix For: 2.9
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Re-balance cancels by non-affected events, for examples:
> 1) joining non affinity node
> 2) stating snapshot
> 3) starting/stopping other cache
> Try to skip as more as possible events instead of cancellation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[ https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039008#comment-17039008 ] Alexey Scherbakov commented on IGNITE-11147: [~v.pyatkov] I think we should add a test for such a scenario and fix it before merging. > Re-balance cancellation occur by non-affected event > --- > > Key: IGNITE-11147 > URL: https://issues.apache.org/jira/browse/IGNITE-11147 > Project: Ignite > Issue Type: Test > Components: cache >Affects Versions: 2.7 >Reporter: Sergey Antonov >Assignee: Vladislav Pyatkov >Priority: Critical > Fix For: 2.9 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > Re-balance cancels by non-affected events, for examples: > 1) joining non affinity node > 2) stating snapshot > 3) starting/stopping other cache > Try to skip as more as possible events instead of cancellation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[ https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039000#comment-17039000 ] Maxim Muzafarov commented on IGNITE-11147: -- [~ascherbakov] Yes, I've mentioned the same in PR. > Re-balance cancellation occur by non-affected event > --- > > Key: IGNITE-11147 > URL: https://issues.apache.org/jira/browse/IGNITE-11147 > Project: Ignite > Issue Type: Test > Components: cache >Affects Versions: 2.7 >Reporter: Sergey Antonov >Assignee: Vladislav Pyatkov >Priority: Critical > Fix For: 2.9 > > Time Spent: 4.5h > Remaining Estimate: 0h > > Re-balance cancels by non-affected events, for examples: > 1) joining non affinity node > 2) stating snapshot > 3) starting/stopping other cache > Try to skip as more as possible events instead of cancellation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038999#comment-17038999
]
Alexey Scherbakov commented on IGNITE-11147:
Guys,
Looks like the patch has an issue.
It's possible to have parallel rebalancing of multiple groups, because chain is
processed even if future was cancelled.
We must stop chain processing if result was false:
{noformat}
@Override public boolean onDone(@Nullable Boolean res, @Nullable
Throwable err) {
if (super.onDone(res, err)) {
if (res && next != null)
next.init(); // Go to next item in chain only for
successful rebalance completion.
return true;
}
return false;
}
{noformat}
> Re-balance cancellation occur by non-affected event
> ---
>
> Key: IGNITE-11147
> URL: https://issues.apache.org/jira/browse/IGNITE-11147
> Project: Ignite
> Issue Type: Test
> Components: cache
>Affects Versions: 2.7
>Reporter: Sergey Antonov
>Assignee: Vladislav Pyatkov
>Priority: Critical
> Fix For: 2.9
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Re-balance cancels by non-affected events, for examples:
> 1) joining non affinity node
> 2) stating snapshot
> 3) starting/stopping other cache
> Try to skip as more as possible events instead of cancellation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[ https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038932#comment-17038932 ] Alexey Scherbakov commented on IGNITE-11147: Looks like all comments are addressed. No more objections from me. [~mmuzaf] do you need more time to look at the changes ? > Re-balance cancellation occur by non-affected event > --- > > Key: IGNITE-11147 > URL: https://issues.apache.org/jira/browse/IGNITE-11147 > Project: Ignite > Issue Type: Test > Components: cache >Affects Versions: 2.7 >Reporter: Sergey Antonov >Assignee: Vladislav Pyatkov >Priority: Critical > Fix For: 2.9 > > Time Spent: 4h 20m > Remaining Estimate: 0h > > Re-balance cancels by non-affected events, for examples: > 1) joining non affinity node > 2) stating snapshot > 3) starting/stopping other cache > Try to skip as more as possible events instead of cancellation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[ https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038925#comment-17038925 ] Vladislav Pyatkov commented on IGNITE-11147: [~ascherbakov] [~xtern] [~NSAmelchev][~mmuzaf] Thank for your review. I applied your advices particaly and stayed some comment in PR. > Re-balance cancellation occur by non-affected event > --- > > Key: IGNITE-11147 > URL: https://issues.apache.org/jira/browse/IGNITE-11147 > Project: Ignite > Issue Type: Test > Components: cache >Affects Versions: 2.7 >Reporter: Sergey Antonov >Assignee: Vladislav Pyatkov >Priority: Critical > Fix For: 2.9 > > Time Spent: 4h 10m > Remaining Estimate: 0h > > Re-balance cancels by non-affected events, for examples: > 1) joining non affinity node > 2) stating snapshot > 3) starting/stopping other cache > Try to skip as more as possible events instead of cancellation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[ https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038356#comment-17038356 ] Alexey Scherbakov commented on IGNITE-11147: [~v.pyatkov] Check my comments under the PR. > Re-balance cancellation occur by non-affected event > --- > > Key: IGNITE-11147 > URL: https://issues.apache.org/jira/browse/IGNITE-11147 > Project: Ignite > Issue Type: Test > Components: cache >Affects Versions: 2.7 >Reporter: Sergey Antonov >Assignee: Vladislav Pyatkov >Priority: Critical > Fix For: 2.9 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Re-balance cancels by non-affected events, for examples: > 1) joining non affinity node > 2) stating snapshot > 3) starting/stopping other cache > Try to skip as more as possible events instead of cancellation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[ https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038329#comment-17038329 ] Maxim Muzafarov commented on IGNITE-11147: -- Folks, I'll take a look at these changes soon. Please, do not hurry with the merge. > Re-balance cancellation occur by non-affected event > --- > > Key: IGNITE-11147 > URL: https://issues.apache.org/jira/browse/IGNITE-11147 > Project: Ignite > Issue Type: Test > Components: cache >Affects Versions: 2.7 >Reporter: Sergey Antonov >Assignee: Vladislav Pyatkov >Priority: Critical > Fix For: 2.9 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Re-balance cancels by non-affected events, for examples: > 1) joining non affinity node > 2) stating snapshot > 3) starting/stopping other cache > Try to skip as more as possible events instead of cancellation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[ https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037888#comment-17037888 ] Vladislav Pyatkov commented on IGNITE-11147: [~ascherbakov] Please review my changes. > Re-balance cancellation occur by non-affected event > --- > > Key: IGNITE-11147 > URL: https://issues.apache.org/jira/browse/IGNITE-11147 > Project: Ignite > Issue Type: Test > Components: cache >Affects Versions: 2.7 >Reporter: Sergey Antonov >Assignee: Vladislav Pyatkov >Priority: Critical > Fix For: 2.9 > > Time Spent: 20m > Remaining Estimate: 0h > > Re-balance cancels by non-affected events, for examples: > 1) joining non affinity node > 2) stating snapshot > 3) starting/stopping other cache > Try to skip as more as possible events instead of cancellation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-11147) Re-balance cancellation occur by non-affected event
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037886#comment-17037886
]
Ignite TC Bot commented on IGNITE-11147:
{panel:title=Branch: [pull/7428/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5050400buildTypeId=IgniteTests24Java8_RunAll]
> Re-balance cancellation occur by non-affected event
> ---
>
> Key: IGNITE-11147
> URL: https://issues.apache.org/jira/browse/IGNITE-11147
> Project: Ignite
> Issue Type: Test
> Components: cache
>Affects Versions: 2.7
>Reporter: Sergey Antonov
>Assignee: Vladislav Pyatkov
>Priority: Critical
> Fix For: 2.9
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Re-balance cancels by non-affected events, for examples:
> 1) joining non affinity node
> 2) stating snapshot
> 3) starting/stopping other cache
> Try to skip as more as possible events instead of cancellation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
