[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-07-08 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153573#comment-17153573
 ] 

Aleksey Plekhanov commented on IGNITE-11393:


[~amashenkov], thanks for the review! Yes, we still can't use JDK 11+ for 
release purposes (one more issue, on JDK 9+ we compiling with target 11, and 
class files generated with the wrong version and can't be used on JDK 8, but 
this issue can be easily fixed).

I've removed old PR and rebased the actual one. I will merge the fix today.

 

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
> Fix For: 2.9
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-07-08 Thread Andrey Mashenkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153498#comment-17153498
 ] 

Andrey Mashenkov commented on IGNITE-11393:
---

[~alex_pl], I've noticed you created a new PR and closed the old one.
Please, remove a link to the outdated PR and fix merge conflicts for the new 
one.

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
> Fix For: 2.9
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-07-08 Thread Andrey Mashenkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153495#comment-17153495
 ] 

Andrey Mashenkov commented on IGNITE-11393:
---

[~alex_pl], fix look good.
{noformat}
But there still some issues with Javadoc on JDK 11+ (see IGNITE-13202){noformat}
Do you mean, Apache Ignite can now be successfully build from sources on JDK 
11+, 
but we still can't use JDK 11+ for release purposes as javadocs are still 
broken?

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
> Fix For: 2.9
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-07-02 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150728#comment-17150728
 ] 

Ignite TC Bot commented on IGNITE-11393:


{panel:title=Branch: [pull/7983/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7983/head] Base: [master] : New Tests 
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=c67a0639-b5f1-4c78-925e-8366aa0cc174, topVer=0, 
nodeId8=9102236b, msg=, type=NODE_JOINED, tstamp=1593674423276], 
val2=AffinityTopologyVersion [topVer=3424044072389115096, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=c67a0639-b5f1-4c78-925e-8366aa0cc174, topVer=0, 
nodeId8=9102236b, msg=, type=NODE_JOINED, tstamp=1593674423276], 
val2=AffinityTopologyVersion [topVer=3424044072389115096, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=bbd207e0371-c697d234-6fad-493d-afea-4beeb930a44d, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=b9bf8878-9fb3-4f05-8cea-4c7c2edfa88e, topVer=0, nodeId8=b9bf8878, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593674423276]], 
val2=AffinityTopologyVersion [topVer=-2163644835463648817, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=bbd207e0371-c697d234-6fad-493d-afea-4beeb930a44d, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=b9bf8878-9fb3-4f05-8cea-4c7c2edfa88e, topVer=0, nodeId8=b9bf8878, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593674423276]], 
val2=AffinityTopologyVersion [topVer=-2163644835463648817, minorTopVer=0]]] - 
PASSED{color}

{color:#8b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=c7ed05a2-5ee9-4202-a8ab-9521a3509083, topVer=0, 
nodeId8=3abde5a8, msg=, type=NODE_JOINED, tstamp=1593674229938], 
val2=AffinityTopologyVersion [topVer=3445520685455818384, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=c7ed05a2-5ee9-4202-a8ab-9521a3509083, topVer=0, 
nodeId8=3abde5a8, msg=, type=NODE_JOINED, tstamp=1593674229938], 
val2=AffinityTopologyVersion [topVer=3445520685455818384, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=6b8e26e0371-2f2c9fa4-9ae9-4e17-9a57-3e98f106e958, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=b11a8a03-377a-4758-aa62-b584b75b5284, topVer=0, nodeId8=b11a8a03, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593674229938]], 
val2=AffinityTopologyVersion [topVer=5336888790201139606, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=6b8e26e0371-2f2c9fa4-9ae9-4e17-9a57-3e98f106e958, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=b11a8a03-377a-4758-aa62-b584b75b5284, topVer=0, nodeId8=b11a8a03, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593674229938]], 
val2=AffinityTopologyVersion [topVer=5336888790201139606, minorTopVer=0]]] - 
PASSED{color}

{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5433386buildTypeId=IgniteTests24Java8_RunAll]

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-07-02 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150036#comment-17150036
 ] 

Aleksey Plekhanov commented on IGNITE-11393:


[~amashenkov] or [~dpavlov], can you please review the patch in PR 7983?

I've additionally fixed some maven build issues and now release can be built by 
maven on JDK 11+:
{noformat}
mvn clean install -Pall-java,all-scala,licenses -DskipTests
mvn initialize -Pjavadoc
mvn initialize -Prelease{noformat}
Checked on JDK 8, JDK 11, JDK 14.

But there still some issues with Javadoc on JDK 11+ (see IGNITE-13202)

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-06-22 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141763#comment-17141763
 ] 

Aleksey Plekhanov commented on IGNITE-11393:


[~amashenkov], thanks for your comments. I will return to this ticket in a week.

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-06-19 Thread Andrey Mashenkov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140767#comment-17140767
 ] 

Andrey Mashenkov commented on IGNITE-11393:
---

[~alex_pl]

I have  OpenJDK  14  on my NB and I can't  build Ignite from sources due to 
compilations issues with IgniteLinkTaglet in ignite-tool module.
"Tag" class doesn't exists anymore.

With your fix I am able to compile Ignite sources successfully, thanks!

I've left few comments to the PR.

 

 

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-05-27 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117926#comment-17117926
 ] 

Aleksey Plekhanov commented on IGNITE-11393:


Seems like some of java8 javadoc builds have been broken with the new version 
of maven-javadoc-plugin. Further investigation needed.

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-05-25 Thread Dmitry Pavlov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116203#comment-17116203
 ] 

Dmitry Pavlov commented on IGNITE-11393:


LGTM provided that it actually generates proper javadoc under java9+. It may be 
tricky to check without full compilation support from Apache Ignite.

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-11393) Create IgniteLinkTaglet.toString() implementation for Java9+

2020-05-24 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115544#comment-17115544
 ] 

Ignite TC Bot commented on IGNITE-11393:


{panel:title=Branch: [pull/7839/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5332237buildTypeId=IgniteTests24Java8_RunAll]

> Create IgniteLinkTaglet.toString() implementation for Java9+
> 
>
> Key: IGNITE-11393
> URL: https://issues.apache.org/jira/browse/IGNITE-11393
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Dmitry Pavlov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> New implementation was added according to the new Java API for Javadoc.
> But the main method kept empty, need to implement toString() to process 
> IgniteLink annotation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)