[jira] [Commented] (IGNITE-11797) Fix consistency issues for atomic and mixed tx-atomic cache groups.

2020-01-31 Thread Pavel Pereslegin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027430#comment-17027430
 ] 

Pavel Pereslegin commented on IGNITE-11797:
---

[~ascherbakov], thanks for the clarification.

> Fix consistency issues for atomic and mixed tx-atomic cache groups.
> ---
>
> Key: IGNITE-11797
> URL: https://issues.apache.org/jira/browse/IGNITE-11797
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Scherbakov
>Assignee: Alexey Scherbakov
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> IGNITE-10078 only solves consistency problems for tx mode.
> For atomic caches the rebalance consistency issues still remain and should be 
> fixed together with improvement of atomic cache protocol consistency.
> Also, need to disable dynamic start of atomic cache in group having only tx 
> caches because it's not working in current state.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-11797) Fix consistency issues for atomic and mixed tx-atomic cache groups.

2020-01-31 Thread Alexey Scherbakov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027295#comment-17027295
 ] 

Alexey Scherbakov commented on IGNITE-11797:


[~xtern]

This change is necessary until we fix all remaining issues with atomic caches 
consistency.
Right now it's possible some update will be absent in the WAL causing this 
assertion to trigger if a primary node has left under load and returned later.
Reproducible by AtomicPartitionCounterStateConsistencyHistoryRebalanceTest 
(added in this contribution).

The assertion should be enabled again after the consistency fix is done.

> Fix consistency issues for atomic and mixed tx-atomic cache groups.
> ---
>
> Key: IGNITE-11797
> URL: https://issues.apache.org/jira/browse/IGNITE-11797
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Scherbakov
>Assignee: Alexey Scherbakov
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> IGNITE-10078 only solves consistency problems for tx mode.
> For atomic caches the rebalance consistency issues still remain and should be 
> fixed together with improvement of atomic cache protocol consistency.
> Also, need to disable dynamic start of atomic cache in group having only tx 
> caches because it's not working in current state.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-11797) Fix consistency issues for atomic and mixed tx-atomic cache groups.

2020-01-30 Thread Pavel Pereslegin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026863#comment-17026863
 ] 

Pavel Pereslegin commented on IGNITE-11797:
---

[~ascherbakov], you changed WAL iterator "assertion" to "warning", can you 
elaborate why you done [this 
change|https://github.com/apache/ignite/pull/7315/files#diff-982671dd518b3d8a905da745d8f0942fL1419]?
If I understand correctly - we can OWN a partition with inconsistent data in 
this case only with a warning in the log file, or am I missing something?
>From my point of view - we should at least restart rebalancing when such 
>errors occur.

> Fix consistency issues for atomic and mixed tx-atomic cache groups.
> ---
>
> Key: IGNITE-11797
> URL: https://issues.apache.org/jira/browse/IGNITE-11797
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Scherbakov
>Assignee: Alexey Scherbakov
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> IGNITE-10078 only solves consistency problems for tx mode.
> For atomic caches the rebalance consistency issues still remain and should be 
> fixed together with improvement of atomic cache protocol consistency.
> Also, need to disable dynamic start of atomic cache in group having only tx 
> caches because it's not working in current state.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-11797) Fix consistency issues for atomic and mixed tx-atomic cache groups.

2020-01-30 Thread Alexey Scherbakov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026497#comment-17026497
 ] 

Alexey Scherbakov commented on IGNITE-11797:


Merged to master.
a9278eedf75d4cefc9642826bfe8dadbc59e04d0

> Fix consistency issues for atomic and mixed tx-atomic cache groups.
> ---
>
> Key: IGNITE-11797
> URL: https://issues.apache.org/jira/browse/IGNITE-11797
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Scherbakov
>Assignee: Alexey Scherbakov
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> IGNITE-10078 only solves consistency problems for tx mode.
> For atomic caches the rebalance consistency issues still remain and should be 
> fixed together with improvement of atomic cache protocol consistency.
> Also, need to disable dynamic start of atomic cache in group having only tx 
> caches because it's not working in current state.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-11797) Fix consistency issues for atomic and mixed tx-atomic cache groups.

2020-01-29 Thread Ivan Rakov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025866#comment-17025866
 ] 

Ivan Rakov commented on IGNITE-11797:
-

[~ascherbakov] Looks good, please merge.

> Fix consistency issues for atomic and mixed tx-atomic cache groups.
> ---
>
> Key: IGNITE-11797
> URL: https://issues.apache.org/jira/browse/IGNITE-11797
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Scherbakov
>Assignee: Alexey Scherbakov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IGNITE-10078 only solves consistency problems for tx mode.
> For atomic caches the rebalance consistency issues still remain and should be 
> fixed together with improvement of atomic cache protocol consistency.
> Also, need to disable dynamic start of atomic cache in group having only tx 
> caches because it's not working in current state.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-11797) Fix consistency issues for atomic and mixed tx-atomic cache groups.

2020-01-28 Thread Alexey Scherbakov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025663#comment-17025663
 ] 

Alexey Scherbakov commented on IGNITE-11797:


This patch reduces the probability of partition desync due to partition 
counters discrepancies and lays a foundation for further atomic caches repairs.
We still have issues on primary node failure under load. 
Will be handled by separate ticket.

[~ivan.glukos] Can you take a look ?

> Fix consistency issues for atomic and mixed tx-atomic cache groups.
> ---
>
> Key: IGNITE-11797
> URL: https://issues.apache.org/jira/browse/IGNITE-11797
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Scherbakov
>Assignee: Alexey Scherbakov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IGNITE-10078 only solves consistency problems for tx mode.
> For atomic caches the rebalance consistency issues still remain and should be 
> fixed together with improvement of atomic cache protocol consistency.
> Also, need to disable dynamic start of atomic cache in group having only tx 
> caches because it's not working in current state.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-11797) Fix consistency issues for atomic and mixed tx-atomic cache groups.

2020-01-28 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025660#comment-17025660
 ] 

Ignite TC Bot commented on IGNITE-11797:


{panel:title=Branch: [pull/7315/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4967059buildTypeId=IgniteTests24Java8_RunAll]

> Fix consistency issues for atomic and mixed tx-atomic cache groups.
> ---
>
> Key: IGNITE-11797
> URL: https://issues.apache.org/jira/browse/IGNITE-11797
> Project: Ignite
>  Issue Type: Bug
>Reporter: Alexey Scherbakov
>Assignee: Alexey Scherbakov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IGNITE-10078 only solves consistency problems for tx mode.
> For atomic caches the rebalance consistency issues still remain and should be 
> fixed together with improvement of atomic cache protocol consistency.
> Also, need to disable dynamic start of atomic cache in group having only tx 
> caches because it's not working in current state.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)