[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965309#comment-15965309
 ] 

Denis Magda commented on IGNITE-1192:
-

Folks, finally we did this and I've just merged the integration into the master 
branch. The feature will be released in a couple of weeks in Apache Ignite 2.0 
release.

[~EdShangGG], thanks a lot for tremendous work you did for this task especially 
for the query generator component. I've just polished your existing 
implementation, expanded test coverage and introduce an example. If you don't 
mind I'll reach you out when will be preparing the documentation so that we can 
wrap up a list of current limitations together.

[~sboikov], just to let you know, I've looked at the new Spring Data Key Value 
store that is supported by HZ but there is no way for us to go with it because 
it requires implementing  criteria (predicate) like querying API which will 
significantly limit our querying capabilities.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Denis Magda
>Priority: Minor
>  Labels: Newbie, important
> Fix For: 2.0
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963778#comment-15963778
 ] 

Denis Magda commented on IGNITE-1192:
-

Ignore the message above. You tests work if to merge the pull request as is. 
Looking for a root cause in updated version on my side.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Denis Magda
>Priority: Minor
>  Labels: Newbie, important
> Fix For: 2.0
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963739#comment-15963739
 ] 

Denis Magda commented on IGNITE-1192:
-

[~EdShangGG], did all the test created by you passed on your side? I've altered 
implementation a bit making it compliant to the latest Spring Key Value store 
concept and after the tests were merged I see them failing.


> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Denis Magda
>Priority: Minor
>  Labels: Newbie, important
> Fix For: 2.0
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Sury Sinha (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677945#comment-15677945
 ] 

Sury Sinha commented on IGNITE-1192:


Thanks , will be interesting to see when it becomes available , cheers 

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 2.0
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676388#comment-15676388
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

Yes, this ticket is intended to make possible querying Ignite via Spring Data. 
But it is not merged yet.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 2.0
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670097#comment-15670097
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

If you want you some storage and Ignite as cache layer, you could look here - 
https://apacheignite.readme.io/docs/spring-caching..

This ticket about querying Ignite itself via Spring Data. Not about caching 
queries for some storage.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 2.0
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Sury Sinha (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668597#comment-15668597
 ] 

Sury Sinha commented on IGNITE-1192:


[~EdShangGG] , I was interested in integrating Ignite caching with Spring Data 
, Looks like there is some progress on this based on last commit from you . Can 
you please point me :
a) any sample code for Spring Data and Ignite integration
b) version of Ignite which needs to be used  

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 2.0
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Sury Sinha (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508638#comment-15508638
 ] 

Sury Sinha commented on IGNITE-1192:


Hi Semen,

We have a REST service built using Spring boot and Spring Data . Here is the 
flow :
a) REST Client > REST Controller (Client calls REST controller )
b) REST Controller  > Spring Data Repository ( REST Controller calls one or 
many spring data repositories like "BinEntryRepository" )  
c) Spring Data Repository> Database ( Spring Data Repository calls 
underlying database and invokes queries associated with methods like 
"findByPrefixAndVersion" )
Now any hit to controller will result in database calls in the current design . 
We intended to load all the tables in database in caches and see if the 
database SQL can be executed against the cache directly .The intent was to use 
@Cacheable  against the Spring Data Repository methods was just to achieve the 
same.

It will be great if you can point us to a sample example of Spring data + 
Ignite usage .

Thanks,
Sury

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.8
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Semen Boikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506463#comment-15506463
 ] 

Semen Boikov commented on IGNITE-1192:
--

Hi Sury,

Are you trying to use Ignite as a Spring Cache? This is different from Spring 
Data integration. Take a look at Ignite Spring Cache documentation: 
https://apacheignite.readme.io/docs/spring-caching.

Thanks

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.8
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Sury Sinha (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506225#comment-15506225
 ] 

Sury Sinha commented on IGNITE-1192:


Hi Eduard,

Thanks for your reply. Following steps were done by us:

a) We loaded data of all database tables like "BinEntry" , "Dataload" , 
"Version" in separate Ignite caches by same name as table name . For ex: Data 
of "BinEntry" table was stored in a cache named as "BinEntry" and so on..
b) We did an override of findOne() in spring data repository of "BinEntry" 
table . Below is the piece of code for override:
 @Override
 @Cacheable("BinEntry")
 BinEntry findOne(Integer id);
c) After doing the above two steps , on invoking findOne() , the data was 
returned from Ignite cache rather than hitting the database.
d) Then we tried invoking another method from spring data repository of 
"BinEntry" table . The query executed by this methopd joins another table 
"DataLoad " .
This did not work anyways.
 @Query("select  b from BinEntry b  where b.prefix = ( select max (prefix)  
from BinEntry binEntry where :prefix like binEntry.prefix " + 
"and binEntry.dataLoad in ( select  d from DataLoad d join 
d.versions dt where dt = :version ) )" +
"and b.dataLoad in ( select  d from DataLoad d join d.versions dt 
where dt = :version ) )" +
" order by b.id , b.cardType asc")
 @Cacheable("BinEntry")
 List findByPrefixAndVersion(@Param("prefix") String prefix, 
@Param("version") Version version);
e) We were also not sure what cache name should be used as parameter in 
@Cacheable annotation for the second method as the second method would need to 
query on both "BinEntry" and "DataLoad" caches.

Please let me know if you need more details. Also please let me know if there 
is any existing implementation example of Spring Data + Ignite .
Cheers,
Sury

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.8
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506061#comment-15506061
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

Hi Sury!

Did you implement repository by yourself or check out my changes?

If you find, pls, provide me a reproducer. 

Also, this patch should be included in 1.8 release. But there is issue with 
repository configuration, we should find way how to provide cache name for 
repository in spring config.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.8
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Semen Boikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434987#comment-15434987
 ] 

Semen Boikov commented on IGNITE-1192:
--

Hi Eduard,

I did quick review Spring Data integration, have few comments:
- now cache name is bound to repository at compile time, could you please try 
to investigate if more flexible bindign is possible?
- as I see now all spring-data integrations are hosted here - 
https://github.com/spring-projects, Could you please investigated how ignite 
inegration can be added there?

Thanks!

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.8
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419328#comment-15419328
 ] 

Denis Magda commented on IGNITE-1192:
-

[~EdShangGG], you need to prepare at least a documentation draft for the 
functionality you've contributed. Let me know when your changes are ready to be 
merged we will work out together on what have to be included in the doc.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.8
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412300#comment-15412300
 ] 

ASF GitHub Bot commented on IGNITE-1192:


GitHub user EdShangGG opened a pull request:

https://github.com/apache/ignite/pull/931

IGNITE-1192



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/EdShangGG/ignite IGNITE-1192

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #931


commit 272b685033bdce712d67393a03608c9e783d66cd
Author: EdShangGG 
Date:   2016-08-03T17:17:51Z

IGNITE-1192 Provide integration with Spring Data
-prototype

commit 1b175c5b887b7a0d6e5ef7a83a04fbf9efc69c3c
Author: EdShangGG 
Date:   2016-08-04T15:12:05Z

IGNITE-1192 Provide integration with Spring Data
-adding sql generation for almost all PartTree.Type

commit 9b00d7ba5a00cfc9ee28bd7b9b66da2952615beb
Author: EdShangGG 
Date:   2016-08-05T14:17:01Z

IGNITE-1192 Provide integration with Spring Data
-adding support of count-query, sort and pageable

commit 3dedbc88dc8ff2c7cbbb84dd0e935d2b4ba4eacc
Author: EdShangGG 
Date:   2016-08-05T16:11:54Z

IGNITE-1192 Provide integration with Spring Data
-adding support for select for fields

commit 38b66070eedd69eaceda7543bfbd5ad935dd6cb8
Author: EdShangGG 
Date:   2016-08-08T14:12:01Z

IGNITE-1192 Provide integration with Spring Data
-adding support for Cache.Entry

commit 3ee689eb75806047ceaf41713c61ec3b5c26575d
Author: EdShangGG 
Date:   2016-08-08T14:21:14Z

IGNITE-1192 Provide integration with Spring Data
-refactoring

commit c8c691d9e94070258c3064e4d8ee47b7a2000e5c
Author: EdShangGG 
Date:   2016-08-08T15:02:19Z

IGNITE-1192 Provide integration with Spring Data
-adding support for returning several fields in sql fields queries

commit 0784d241a09b88149d78373dda2072d71e0051d2
Author: EdShangGG 
Date:   2016-08-08T17:18:24Z

IGNITE-1192 Provide integration with Spring Data
-refactoring, adding comments, javadocs

commit cff02437ee8ccafa0b03cbd2638defab35f349db
Author: EdShangGG 
Date:   2016-08-08T17:44:46Z

IGNITE-1192 Provide integration with Spring Data
-adding support for slice of cache entries

commit 1665cc498a6ffc02c4c808b98bcdf8a9b0780d23
Author: EdShangGG 
Date:   2016-08-08T19:13:31Z

IGNITE-1192 Provide integration with Spring Data
-adding javadoc, tests, clearing pom




> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409638#comment-15409638
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

Update:
Adding support for count-queries, sort, pageable, select for fields.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407925#comment-15407925
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

Update: 
I have added support for querying by almost all PartTree.Type.  
I've looked at Querydsql and I think it is not worth to add support right now.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407588#comment-15407588
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

I have sent my thoughts to dev-list. Pls, take a look.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407433#comment-15407433
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

Dmitriy,
1. I think, it is too early state to advance status.
2. I want to start the discussion today. Describe what was done, what problems 
I see and a list of features what we want to achieve.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Dmitriy Setrakyan (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406811#comment-15406811
 ] 

Dmitriy Setrakyan commented on IGNITE-1192:
---

Eduard,
1. Please advance the ticket Patch Available status
2. Feel free to start a discussion on the dev list and propose a few things.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406259#comment-15406259
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

The first prototype is available.

https://github.com/EdShangGG/ignite/blob/IGNITE-1192/modules/spring-data/src/test/java/org/ignite/spring/data/FirstRepository.java

Now the repository works.

But there are many things to do. Also, need start discussion about what exactly 
we want to achieve.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405934#comment-15405934
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

Well, because of Juan inactivity I have assigned the ticket to me myself.
Now I am investigation Spring Data entrails.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Eduard Shangareev
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Eduard Shangareev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399425#comment-15399425
 ] 

Eduard Shangareev commented on IGNITE-1192:
---

Hi Juan, do you mind if I assign this ticket to me. 
I am very interested in implementing this feature.



> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Juan C Fiorenzano
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Semen Boikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398164#comment-15398164
 ] 

Semen Boikov commented on IGNITE-1192:
--

Here are some thoughts how spring data integration can look like. Main feature 
Spring Data provides - Repository concept, user just defines some interface for 
entity access and spring data framework automatically generates CRUD/query 
methods.

Basically, it can look like this:

There is cache enity type:
{code}
class Person {
@QuerySqlField(index = true)
private String firstName;

@QuerySqlField(index = true)
private String lastName;

public String getFirstName() {
return firstName;
}

public void setFirstName(String firstName) {
this.firstName = firstName;
}

public String getLastName() {
return lastName;
}

public void setLastName(String lastName) {
this.lastName = lastName;
}
}
{code}

User creates PersonRepository interface:
{code}
// PersonRepository, spring data automatically generates CRUD/query methods.
interface PersonRepository extends CrudRepository {
// Inherited from CrudRepository, call cache.get(key)
Person findOne(Long key);

// Inherited from CrudRepository, call cache.containsKey(key)
boolean exists(Long key);

// Inherited from CrudRepository, call cache.remove(key)
void delete(Long key);

// SQL query 'where firstName=?'
List findByLastname(String lastname);

// SQL query 'where firstName=? or lastName=?'
List findByFirstnameOrLastname(String firstname, String 
lastname);

// Query with pagination.
Page findPersonByLastname(String lastname, Pageable page);
}
{code}

Then spring-data framework should atomatically generate repository methods 
implementation so that PersonRepository.findOne will call cache.get(), and 
PersonRepository.findByLastname will execute Ignite SqlQuery 'select from 
Person where firstName=?'.

(there also should be some ignite-specific configuration which can be used by 
repository to connect to Ignite). 

Some notes:
- there is separate module 'Spring Data Key Value' which provides some 
infrastructure for key/value storage integration 
(https://github.com/spring-projects/spring-data-keyvalue). Need check if it 
makes sense to use it for Ignite integration
- standard repository assumes that each entity has some 'id' field - unique 
entity identifier, (e.g. database primary key), but for values stored in Ignite 
cache often this is not the case. Maybe it makes sense to add special 
IgniteRepository interface with save methods which will accept 'key' parameter? 
But it still makes sense support 'id': if enity has propery with @Id annotation 
it can be use as cache key, thus standard CrudRepository.save API can be used.
- there should be some way to specify what cache to use for entity access. 
Looks like 'Spring Data Key Value' has KeySpace annotation for such purpose (or 
it can be Ignite-specific annotation/repositiry configuration parameter/derived 
from class name?)



> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Juan C Fiorenzano
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Dmitriy Setrakyan (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372636#comment-15372636
 ] 

Dmitriy Setrakyan commented on IGNITE-1192:
---

Juan, have you been able to make any progress on this ticket?

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Juan C Fiorenzano
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Da Weng (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371348#comment-15371348
 ] 

Da Weng commented on IGNITE-1192:
-

Hi, we have the same requirement to use spring data to query ignite via jdbc 
driver (read only).
What's the release data for this issue? and if it will take time, is there any 
workaround for now? 
thanks.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Juan C Fiorenzano
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Juan C Fiorenzano (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299497#comment-15299497
 ] 

Juan C Fiorenzano commented on IGNITE-1192:
---

Hello I am going to start developing this ticket, I am going to create a new 
module for this characteristic , if somebody has a better approach, please let 
me know. 

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Juan C Fiorenzano
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Juan C Fiorenzano (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295340#comment-15295340
 ] 

Juan C Fiorenzano commented on IGNITE-1192:
---

Hello I am little lost here I need more information, I took this ticket because 
I want to begin to contribute in the project. When you say "integration with 
Spring Data" what are you expecting? ,what modules are implied in this 
integration?,exist some example to see how a third-party technology is 
integrated to Ignite? . All that I have seen is create a new repository in 
spring data for support Ignite, but if I do that then I only add a new 
repository to spring-data, I don't have to do anything in Ignite. Thanks in 
advance

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Juan C Fiorenzano
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Juan C Fiorenzano (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295302#comment-15295302
 ] 

Juan C Fiorenzano commented on IGNITE-1192:
---

Hello I am little lost here I need more information, I took this ticket because 
I want to begin to contribute in the project. When you say "integration with 
Spring Data" what are you expecting? ,what modules are implied in this 
integration?,exist some example to see how a third-party technology is 
integrated to Ignite? . All that I have seen is create a new repository in 
spring data for support Ignite but if I do that is add a new repository to 
spring-data, I don't have to do anything in Ignite.

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Juan C Fiorenzano
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.7
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[JIRA]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060750#comment-15060750
 ] 

Jörn Franke commented on IGNITE-1192:
-

I will write later a little bit more, but I assume it is about integrating 
spring-data with Ignite Datagrid. 
IGFS and Hadoop MR Jobs on Ignite can be already accessed via spring-data-hadoop

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.6
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Dmitriy Setrakyan (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060812#comment-15060812
 ] 

Dmitriy Setrakyan commented on IGNITE-1192:
---

Jörn Franke, yes you are right, it is about integrating the Data Grid with 
Spring Data. Are you interested in contributing this feature?

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.6
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1192) Provide integration with Spring Data

[Taini Andrea (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15055781#comment-15055781
 ] 

Taini Andrea commented on IGNITE-1192:
--

Hi Vikrant,
is this ticket makig any progress? Is a very interesting feature for us.
Thx! :)

> Provide integration with Spring Data
> 
>
> Key: IGNITE-1192
> URL: https://issues.apache.org/jira/browse/IGNITE-1192
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.1.4
>Reporter: Valentin Kulichenko
>Assignee: Vikrant Navalgund
>Priority: Minor
>  Labels: Newbie
> Fix For: 1.5
>
>
> Spring Data docs:
> * http://docs.spring.io/spring-data/data-commons/docs/current/reference/html/
> * http://docs.spring.io/spring-data/data-commons/docs/current/api/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)