[jira] [Commented] (IGNITE-12135) Rework GridCommandHandlerTest

2019-09-11 Thread Dmitriy Govorukhin (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927395#comment-16927395
 ] 

Dmitriy Govorukhin commented on IGNITE-12135:
-

[~ktkale...@gridgain.com]Merged to master. Thanks for your contribution!

> Rework GridCommandHandlerTest
> -
>
> Key: IGNITE-12135
> URL: https://issues.apache.org/jira/browse/IGNITE-12135
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are 50+ tests. In each test we are start and stop nodes. I think we 
> could split tests at least to two groups:
>  # Tests on normal behaviour. We could start nodes before all tests and stop 
> them after all tests.
>  # Tests required start new cluster before each test.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (IGNITE-12135) Rework GridCommandHandlerTest

2019-09-10 Thread Anton Kalashnikov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926638#comment-16926638
 ] 

Anton Kalashnikov commented on IGNITE-12135:


[~ktkale...@gridgain.com] thanks for your changes. Looks good to me.

> Rework GridCommandHandlerTest
> -
>
> Key: IGNITE-12135
> URL: https://issues.apache.org/jira/browse/IGNITE-12135
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are 50+ tests. In each test we are start and stop nodes. I think we 
> could split tests at least to two groups:
>  # Tests on normal behaviour. We could start nodes before all tests and stop 
> them after all tests.
>  # Tests required start new cluster before each test.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (IGNITE-12135) Rework GridCommandHandlerTest

2019-09-10 Thread Kirill Tkalenko (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926460#comment-16926460
 ] 

Kirill Tkalenko commented on IGNITE-12135:
--

Return @Test.

> Rework GridCommandHandlerTest
> -
>
> Key: IGNITE-12135
> URL: https://issues.apache.org/jira/browse/IGNITE-12135
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are 50+ tests. In each test we are start and stop nodes. I think we 
> could split tests at least to two groups:
>  # Tests on normal behaviour. We could start nodes before all tests and stop 
> them after all tests.
>  # Tests required start new cluster before each test.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (IGNITE-12135) Rework GridCommandHandlerTest

2019-09-09 Thread Kirill Tkalenko (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925410#comment-16925410
 ] 

Kirill Tkalenko commented on IGNITE-12135:
--

Deleted @Test.

> Rework GridCommandHandlerTest
> -
>
> Key: IGNITE-12135
> URL: https://issues.apache.org/jira/browse/IGNITE-12135
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are 50+ tests. In each test we are start and stop nodes. I think we 
> could split tests at least to two groups:
>  # Tests on normal behaviour. We could start nodes before all tests and stop 
> them after all tests.
>  # Tests required start new cluster before each test.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (IGNITE-12135) Rework GridCommandHandlerTest

2019-09-05 Thread Kirill Tkalenko (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923429#comment-16923429
 ] 

Kirill Tkalenko commented on IGNITE-12135:
--

[~antonovsergey93] Made corrections on comments in PR.
[~DmitriyGovorukhin], please review the code.

> Rework GridCommandHandlerTest
> -
>
> Key: IGNITE-12135
> URL: https://issues.apache.org/jira/browse/IGNITE-12135
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are 50+ tests. In each test we are start and stop nodes. I think we 
> could split tests at least to two groups:
>  # Tests on normal behaviour. We could start nodes before all tests and stop 
> them after all tests.
>  # Tests required start new cluster before each test.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (IGNITE-12135) Rework GridCommandHandlerTest

2019-09-05 Thread Sergey Antonov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923272#comment-16923272
 ] 

Sergey Antonov commented on IGNITE-12135:
-

[~ktkale...@gridgain.com] I left minor comments in PR. Other changes looks good 
for me.

> Rework GridCommandHandlerTest
> -
>
> Key: IGNITE-12135
> URL: https://issues.apache.org/jira/browse/IGNITE-12135
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are 50+ tests. In each test we are start and stop nodes. I think we 
> could split tests at least to two groups:
>  # Tests on normal behaviour. We could start nodes before all tests and stop 
> them after all tests.
>  # Tests required start new cluster before each test.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (IGNITE-12135) Rework GridCommandHandlerTest

2019-09-03 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-12135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921462#comment-16921462
 ] 

Ignite TC Bot commented on IGNITE-12135:


{panel:title=Branch: [pull/6833/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4560479buildTypeId=IgniteTests24Java8_RunAll]

> Rework GridCommandHandlerTest
> -
>
> Key: IGNITE-12135
> URL: https://issues.apache.org/jira/browse/IGNITE-12135
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are 50+ tests. In each test we are start and stop nodes. I think we 
> could split tests at least to two groups:
>  # Tests on normal behaviour. We could start nodes before all tests and stop 
> them after all tests.
>  # Tests required start new cluster before each test.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)