[jira] [Commented] (IGNITE-12376) Change level of "TCP client created ..." log messages to WARN
[
https://issues.apache.org/jira/browse/IGNITE-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119567#comment-17119567
]
Surkov Aleksandr commented on IGNITE-12376:
---
[~alexpl] Could you please review my PR?
> Change level of "TCP client created ..." log messages to WARN
> -
>
> Key: IGNITE-12376
> URL: https://issues.apache.org/jira/browse/IGNITE-12376
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ruslan Kuzmin
>Assignee: Surkov Aleksandr
>Priority: Minor
> Labels: newbie
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Log messages generated when createTcpClient takes more than
> CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.
> It seems it should be changed to WARN level and message text needs to be
> changed for better understanding.
> Message sample (current):
> ~{{2019-11-11 11:11:11.567[INFO
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client
> created [client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
> Proposed format:
> ~{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color}
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi]
> {color:#ff8b00}TCP client creation took longer than expected
> {color}[{color:#ff8b00}threshold=100ms{color},
> client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12376) Change level of "TCP client created ..." log messages to WARN
[
https://issues.apache.org/jira/browse/IGNITE-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119562#comment-17119562
]
Ignite TC Bot commented on IGNITE-12376:
{panel:title=Branch: [pull/7090/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5330055buildTypeId=IgniteTests24Java8_RunAll]
> Change level of "TCP client created ..." log messages to WARN
> -
>
> Key: IGNITE-12376
> URL: https://issues.apache.org/jira/browse/IGNITE-12376
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ruslan Kuzmin
>Assignee: Surkov Aleksandr
>Priority: Minor
> Labels: newbie
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Log messages generated when createTcpClient takes more than
> CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.
> It seems it should be changed to WARN level and message text needs to be
> changed for better understanding.
> Message sample (current):
> ~{{2019-11-11 11:11:11.567[INFO
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client
> created [client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
> Proposed format:
> ~{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color}
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi]
> {color:#ff8b00}TCP client creation took longer than expected
> {color}[{color:#ff8b00}threshold=100ms{color},
> client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12376) Change level of "TCP client created ..." log messages to WARN
[
https://issues.apache.org/jira/browse/IGNITE-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036038#comment-17036038
]
Ignite TC Bot commented on IGNITE-12376:
{panel:title=Branch: [pull/7090/head] Base: [master] : Possible Blockers
(107)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Cache 6{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5046527]]
* IgniteCacheTestSuite6:
GridCachePartitionEvictionDuringReadThroughSelfTest.testPartitionRent - Test
has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}ZooKeeper (Discovery) 2{color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=5046497]]
* ZookeeperDiscoverySpiTestSuite2:
GridCachePartitionedNodeRestartTest.testRestartWithPutEightNodesTwoBackups -
Test has low fail rate in base branch 0,0% and is not flaky
* ZookeeperDiscoverySpiTestSuite2:
GridCommandHandlerTest.testReadOnlyEnableDisable - Test has low fail rate in
base branch 0,0% and is not flaky
* ZookeeperDiscoverySpiTestSuite2:
GridCommandHandlerClusterByClassTest.testHelp - Test has low fail rate in base
branch 0,0% and is not flaky
* ZookeeperDiscoverySpiTestSuite2:
GridCommandHandlerClusterByClassTest.testCacheHelp - Test has low fail rate in
base branch 0,0% and is not flaky
{color:#d04437}Cache 5{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5046526]]
* IgniteCacheTestSuite5:
IgniteCachePartitionLossPolicySelfTest.testReadWriteSafeWithBackupsAfterKillCrdWithPersistence[TRANSACTIONAL]
- Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Cache 7{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5046528]]
* IgniteCacheTestSuite7:
TxRollbackAsyncWithPersistenceTest.testSynchronousRollback - Test has low fail
rate in base branch 0,0% and is not flaky
{color:#d04437}Platform .NET{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5046543]]
* exe: JniThreadDetachTest.TestUseIgniteFromClrThreadsDoesNotLeakJvmThreads -
Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}JCache TCK 1.1{color} [[tests 90 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=5046503]]
* org.jsr107.tck.integration.CacheLoaderTest.shouldNotLoadUsingPutIfAbsent -
Test has low fail rate in base branch 0,0% and is not flaky
*
org.jsr107.tck.integration.CacheLoaderTest.shouldNotLoadWithNullKeyUsingLoadAll
- Test has low fail rate in base branch 0,0% and is not flaky
* org.jsr107.tck.integration.CacheLoaderTest.shouldNotLoadUsingGetAndRemove -
Test has low fail rate in base branch 0,0% and is not flaky
* org.jsr107.tck.integration.CacheLoaderTest.shouldNotLoadDueToIteration - Test
has low fail rate in base branch 0,0% and is not flaky
* org.jsr107.tck.integration.CacheLoaderTest.shouldNotLoadUsingPutAll - Test
has low fail rate in base branch 0,0% and is not flaky
* org.jsr107.tck.integration.CacheLoaderTest.shouldNotLoadUsingRemove - Test
has low fail rate in base branch 0,0% and is not flaky
*
org.jsr107.tck.integration.CacheLoaderTest.testLoadAllWithExecptionAndNoCompletionListener
- Test has low fail rate in base branch 0,0% and is not flaky
* org.jsr107.tck.integration.CacheLoaderTest.shouldNotLoadUsingReplace - Test
has low fail rate in base branch 0,0% and is not flaky
*
org.jsr107.tck.integration.CacheLoaderTest.shouldLoadMultipleExistingEntryUsingLoadAll
- Test has low fail rate in base branch 0,0% and is not flaky
*
org.jsr107.tck.integration.CacheLoaderTest.shouldNotLoadUsingGetWithExistingValue
- Test has low fail rate in base branch 0,0% and is not flaky
*
org.jsr107.tck.integration.CacheLoaderTest.shouldPropagateExceptionUsingLoadAll
- Test has low fail rate in base branch 0,0% and is not flaky
... and 79 tests blockers
{color:#d04437}Basic 3{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=5046502]]
* IgniteBasicWithPersistenceTestSuite:
GridCommandHandlerClusterByClassTest.testHelp - Test has low fail rate in base
branch 0,0% and is not flaky
* IgniteBasicWithPersistenceTestSuite:
GridCommandHandlerClusterByClassTest.testCacheHelp - Test has low fail rate in
base branch 0,0% and is not flaky
{color:#d04437}PDS (Compatibility)*{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5046536]]
* IgniteCompatibilityBasicTestSuite:
MigratingToWalV2SerializerWithCompactionTest.testCompactingOldWalFiles - Test
has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Thin client: Node.js{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=5046500]]
* scan query test suite : scan query settings - Test has low fail rate in
base branch 0,0% and is not flaky
{color:#d04437}Continuous Query 1{color} [[tests
3|https://ci.ignite.apache.org/viewLog.html?buildId=5046468]]
* IgniteCacheQuerySelfTestSuite3:
[jira] [Commented] (IGNITE-12376) Change level of "TCP client created ..." log messages to WARN
[
https://issues.apache.org/jira/browse/IGNITE-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035953#comment-17035953
]
Surkov Aleksandr commented on IGNITE-12376:
---
The final message looks like this:
2019-11-11 11:11:11.567[WARN
]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client
creation took longer than expected [threshold=100ms,
client=GridTcpNioCommunicationClient... ]], duration=1234ms]
100 it's property
org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi#CONNECTION_ESTABLISH_THRESHOLD_MS
> Change level of "TCP client created ..." log messages to WARN
> -
>
> Key: IGNITE-12376
> URL: https://issues.apache.org/jira/browse/IGNITE-12376
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ruslan Kuzmin
>Assignee: Surkov Aleksandr
>Priority: Minor
> Labels: newbie
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Log messages generated when createTcpClient takes more than
> CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.
> It seems it should be changed to WARN level and message text needs to be
> changed for better understanding.
> Message sample (current):
> ~{{2019-11-11 11:11:11.567[INFO
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client
> created [client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
> Proposed format:
> ~{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color}
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi]
> {color:#ff8b00}Long TCP client creation time{color}
> [{color:#ff8b00}threshold=100ms{color},
> client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12376) Change level of "TCP client created ..." log messages to WARN
[
https://issues.apache.org/jira/browse/IGNITE-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989483#comment-16989483
]
Ignite TC Bot commented on IGNITE-12376:
{panel:title=Branch: [pull/7090/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4802570buildTypeId=IgniteTests24Java8_RunAll]
> Change level of "TCP client created ..." log messages to WARN
> -
>
> Key: IGNITE-12376
> URL: https://issues.apache.org/jira/browse/IGNITE-12376
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ruslan Kuzmin
>Assignee: Surkov Aleksandr
>Priority: Minor
> Labels: newbie
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Log messages generated when createTcpClient takes more than
> CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.
> It seems it should be changed to WARN level and message text needs to be
> changed for better understanding.
> Message sample (current):
> ~{{2019-11-11 11:11:11.567[INFO
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client
> created [client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
> Proposed format:
> ~{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color}
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi]
> {color:#ff8b00}Long TCP client creation time{color}
> [{color:#ff8b00}threshold=100ms{color},
> client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12376) Change level of "TCP client created ..." log messages to WARN
[
https://issues.apache.org/jira/browse/IGNITE-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984960#comment-16984960
]
Surkov Aleksandr commented on IGNITE-12376:
---
We have discussed with Ruslan message and decided that it should be the next:
2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color}
]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] {color:#ffab00}TCP
client creation time more than 100ms{color}
[client=GridTcpNioCommunicationClient... ]], duration=1234ms]
100 it's property
org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi#CONNECTION_ESTABLISH_THRESHOLD_MS
> Change level of "TCP client created ..." log messages to WARN
> -
>
> Key: IGNITE-12376
> URL: https://issues.apache.org/jira/browse/IGNITE-12376
> Project: Ignite
> Issue Type: Improvement
>Reporter: Ruslan Kuzmin
>Assignee: Surkov Aleksandr
>Priority: Minor
> Labels: newbie
>
> Log messages generated when createTcpClient takes more than
> CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.
> It seems it should be changed to WARN level and message text needs to be
> changed for better understanding.
> Message sample (current):
> ~{{2019-11-11 11:11:11.567[INFO
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client
> created [client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
> Proposed format:
> ~{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color}
> ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi]
> {color:#ff8b00}Long TCP client creation time{color}
> [{color:#ff8b00}threshold=100ms{color},
> client=GridTcpNioCommunicationClient... ]],
> duration=1234ms]}}~
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
