[jira] [Commented] (IGNITE-12632) [IEP-39] Management API to cancel user provided tasks and queries.

2020-03-20 Thread Anton Vinogradov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063187#comment-17063187
 ] 

Anton Vinogradov commented on IGNITE-12632:
---

[~nizhikov]
Seems, the main idea of your proposal is to emulate "cancel from originating 
node".
I have some concerns about this approach
1) You will have 2 ways to achieve cancellation, this definitely 
overcomplicates the code.
2) An originating node may fail on unexpected cancellation on its behalf (when 
remote structures closed prior to local)

My proposal is to ask the originating node to cancel its task (using the 
current cancelation design) by sending compute with local cancelation code.
Also, I'd like to propose to have additional kill operation - to kill the node. 
This feature can be used when the node ignores proposals to stop the operations.

This approach can be implemented quite simply.
Also, it does not overcomplicate the codebase.

Another proposal is to refactor the current cancellation design for every type 
of task to be not tied on the originating node.
But, this seems to be a complex task, so, it can be plan B. I don't like this 
idea.

> [IEP-39] Management API to cancel user provided tasks and queries.
> --
>
> Key: IGNITE-12632
> URL: https://issues.apache.org/jira/browse/IGNITE-12632
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>  Labels: IEP-39
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> Ignite provides many API to deploy and execute user-provided code on the 
> server nodes inside the same JVM as the Ignite process runs.
> Ignite has many APIs that allocate many resources on the server nodes, also. 
> In case of some buggy code that consumes many system resources(CPU, RAM, 
> flood network) or heavy query the whole cluster can become unstable.
> We should provide to the cluster administrator the ability to stop any user 
> deployed task.
> JMX beans to cancel listed tasks should be introduced:
> * Compute task
> * Service
> * Continuous query
> * Transactions
> * Queries(SQL, Scan, Text)
> In the scope of IEP-35 System view API introduced.
> A new API should use the same identifier that is used in corresponding System 
> View.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12632) [IEP-39] Management API to cancel user provided tasks and queries.

2020-03-17 Thread Roman Kondakov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060882#comment-17060882
 ] 

Roman Kondakov commented on IGNITE-12632:
-

[~nizhikov], I've left a couple comments in PR.

> [IEP-39] Management API to cancel user provided tasks and queries.
> --
>
> Key: IGNITE-12632
> URL: https://issues.apache.org/jira/browse/IGNITE-12632
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>  Labels: IEP-39
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Ignite provides many API to deploy and execute user-provided code on the 
> server nodes inside the same JVM as the Ignite process runs.
> Ignite has many APIs that allocate many resources on the server nodes, also. 
> In case of some buggy code that consumes many system resources(CPU, RAM, 
> flood network) or heavy query the whole cluster can become unstable.
> We should provide to the cluster administrator the ability to stop any user 
> deployed task.
> JMX beans to cancel listed tasks should be introduced:
> * Compute task
> * Service
> * Continuous query
> * Transactions
> * Queries(SQL, Scan, Text)
> In the scope of IEP-35 System view API introduced.
> A new API should use the same identifier that is used in corresponding System 
> View.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12632) [IEP-39] Management API to cancel user provided tasks and queries.

2020-03-17 Thread Nikolay Izhikov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060844#comment-17060844
 ] 

Nikolay Izhikov commented on IGNITE-12632:
--

Hello, [~avinogradov]. 

Can you, please, take a look at my changes.

> [IEP-39] Management API to cancel user provided tasks and queries.
> --
>
> Key: IGNITE-12632
> URL: https://issues.apache.org/jira/browse/IGNITE-12632
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>  Labels: IEP-39
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Ignite provides many API to deploy and execute user-provided code on the 
> server nodes inside the same JVM as the Ignite process runs.
> Ignite has many APIs that allocate many resources on the server nodes, also. 
> In case of some buggy code that consumes many system resources(CPU, RAM, 
> flood network) or heavy query the whole cluster can become unstable.
> We should provide to the cluster administrator the ability to stop any user 
> deployed task.
> JMX beans to cancel listed tasks should be introduced:
> * Compute task
> * Service
> * Continuous query
> * Transactions
> * Queries(SQL, Scan, Text)
> In the scope of IEP-35 System view API introduced.
> A new API should use the same identifier that is used in corresponding System 
> View.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)