[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[ https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056065#comment-17056065 ] Vyacheslav Koptilin commented on IGNITE-12656: -- Hello [~langj], I have created IGNITE-12766 in order to fix the issue you mentioned. > Cleanup GridCacheProcessor from functionality not related to its > responsibility > --- > > Key: IGNITE-12656 > URL: https://issues.apache.org/jira/browse/IGNITE-12656 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Fix For: 2.9 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, we have a couple of functionality in GridCacheProcessor not > directly related to its responsibility, like: > * initQueryStructuresForNotStartedCache > * addRemovedItemsCleanupTask > * setTxOwnerDumpRequestsAllowed > * longTransactionTimeDumpThreshold > * transactionTimeDumpSamplesCoefficient > * longTransactionTimeDumpSamplesPerSecondLimit > * broadcastToNodesSupportingFeature > * LocalAffinityFunction > * RemovedItemsCleanupTask > * TxTimeoutOnPartitionMapExchangeChangeFuture > * enableRebalance > We need to move them to the right places and make GridCacheProcessor code > cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[ https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052164#comment-17052164 ] Vyacheslav Koptilin commented on IGNITE-12656: -- Hello [~langj], [~agoncharuk], You are absolutely right. I just checked AI 2.7.6 -> AI master and I can confirm that node's startup is broken by this change. I will create a new ticket to handle this issue. > Cleanup GridCacheProcessor from functionality not related to its > responsibility > --- > > Key: IGNITE-12656 > URL: https://issues.apache.org/jira/browse/IGNITE-12656 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Fix For: 2.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we have a couple of functionality in GridCacheProcessor not > directly related to its responsibility, like: > * initQueryStructuresForNotStartedCache > * addRemovedItemsCleanupTask > * setTxOwnerDumpRequestsAllowed > * longTransactionTimeDumpThreshold > * transactionTimeDumpSamplesCoefficient > * longTransactionTimeDumpSamplesPerSecondLimit > * broadcastToNodesSupportingFeature > * LocalAffinityFunction > * RemovedItemsCleanupTask > * TxTimeoutOnPartitionMapExchangeChangeFuture > * enableRebalance > We need to move them to the right places and make GridCacheProcessor code > cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[ https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052091#comment-17052091 ] Alexey Goncharuk commented on IGNITE-12656: --- [~slava.koptilin] can you check the LocalAffinityFunction concern? I think we can either keep it for compatibility reasons, or keep a placeholder which will delegate to a moved class. > Cleanup GridCacheProcessor from functionality not related to its > responsibility > --- > > Key: IGNITE-12656 > URL: https://issues.apache.org/jira/browse/IGNITE-12656 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Fix For: 2.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we have a couple of functionality in GridCacheProcessor not > directly related to its responsibility, like: > * initQueryStructuresForNotStartedCache > * addRemovedItemsCleanupTask > * setTxOwnerDumpRequestsAllowed > * longTransactionTimeDumpThreshold > * transactionTimeDumpSamplesCoefficient > * longTransactionTimeDumpSamplesPerSecondLimit > * broadcastToNodesSupportingFeature > * LocalAffinityFunction > * RemovedItemsCleanupTask > * TxTimeoutOnPartitionMapExchangeChangeFuture > * enableRebalance > We need to move them to the right places and make GridCacheProcessor code > cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[ https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048362#comment-17048362 ] Joel Lang commented on IGNITE-12656: [~slava.koptilin] I think moving the LocalAffinityFunction class would break node startup for anyone that is using a local cache with persistence enabled. > Cleanup GridCacheProcessor from functionality not related to its > responsibility > --- > > Key: IGNITE-12656 > URL: https://issues.apache.org/jira/browse/IGNITE-12656 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Fix For: 2.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we have a couple of functionality in GridCacheProcessor not > directly related to its responsibility, like: > * initQueryStructuresForNotStartedCache > * addRemovedItemsCleanupTask > * setTxOwnerDumpRequestsAllowed > * longTransactionTimeDumpThreshold > * transactionTimeDumpSamplesCoefficient > * longTransactionTimeDumpSamplesPerSecondLimit > * broadcastToNodesSupportingFeature > * LocalAffinityFunction > * RemovedItemsCleanupTask > * TxTimeoutOnPartitionMapExchangeChangeFuture > * enableRebalance > We need to move them to the right places and make GridCacheProcessor code > cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[ https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047749#comment-17047749 ] Vyacheslav Koptilin commented on IGNITE-12656: -- Thank you [~Pavlukhin], [~ivan.glukos]! > Cleanup GridCacheProcessor from functionality not related to its > responsibility > --- > > Key: IGNITE-12656 > URL: https://issues.apache.org/jira/browse/IGNITE-12656 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Fix For: 2.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we have a couple of functionality in GridCacheProcessor not > directly related to its responsibility, like: > * initQueryStructuresForNotStartedCache > * addRemovedItemsCleanupTask > * setTxOwnerDumpRequestsAllowed > * longTransactionTimeDumpThreshold > * transactionTimeDumpSamplesCoefficient > * longTransactionTimeDumpSamplesPerSecondLimit > * broadcastToNodesSupportingFeature > * LocalAffinityFunction > * RemovedItemsCleanupTask > * TxTimeoutOnPartitionMapExchangeChangeFuture > * enableRebalance > We need to move them to the right places and make GridCacheProcessor code > cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[ https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047745#comment-17047745 ] Ivan Rakov commented on IGNITE-12656: - [~sk0x50] Looks good to me. > Cleanup GridCacheProcessor from functionality not related to its > responsibility > --- > > Key: IGNITE-12656 > URL: https://issues.apache.org/jira/browse/IGNITE-12656 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Fix For: 2.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we have a couple of functionality in GridCacheProcessor not > directly related to its responsibility, like: > * initQueryStructuresForNotStartedCache > * addRemovedItemsCleanupTask > * setTxOwnerDumpRequestsAllowed > * longTransactionTimeDumpThreshold > * transactionTimeDumpSamplesCoefficient > * longTransactionTimeDumpSamplesPerSecondLimit > * broadcastToNodesSupportingFeature > * LocalAffinityFunction > * RemovedItemsCleanupTask > * TxTimeoutOnPartitionMapExchangeChangeFuture > * enableRebalance > We need to move them to the right places and make GridCacheProcessor code > cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[
https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047476#comment-17047476
]
Ivan Pavlukhin commented on IGNITE-12656:
-
[~slava.koptilin], I checked a description of {{GridCacheProcessor}} in
javadoc. Sounds good to me. Have not done thorough code review but did not
catch any problems during brief check.
> Cleanup GridCacheProcessor from functionality not related to its
> responsibility
> ---
>
> Key: IGNITE-12656
> URL: https://issues.apache.org/jira/browse/IGNITE-12656
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.8
>Reporter: Vyacheslav Koptilin
>Assignee: Vyacheslav Koptilin
>Priority: Major
> Fix For: 2.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, we have a couple of functionality in GridCacheProcessor not
> directly related to its responsibility, like:
> * initQueryStructuresForNotStartedCache
> * addRemovedItemsCleanupTask
> * setTxOwnerDumpRequestsAllowed
> * longTransactionTimeDumpThreshold
> * transactionTimeDumpSamplesCoefficient
> * longTransactionTimeDumpSamplesPerSecondLimit
> * broadcastToNodesSupportingFeature
> * LocalAffinityFunction
> * RemovedItemsCleanupTask
> * TxTimeoutOnPartitionMapExchangeChangeFuture
> * enableRebalance
> We need to move them to the right places and make GridCacheProcessor code
> cleaner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[ https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046413#comment-17046413 ] Vyacheslav Koptilin commented on IGNITE-12656: -- Hello [~ivan.glukos], [~Pavlukhin], Could you please take a look at PR? > Cleanup GridCacheProcessor from functionality not related to its > responsibility > --- > > Key: IGNITE-12656 > URL: https://issues.apache.org/jira/browse/IGNITE-12656 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Vyacheslav Koptilin >Assignee: Vyacheslav Koptilin >Priority: Major > Fix For: 2.9 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently, we have a couple of functionality in GridCacheProcessor not > directly related to its responsibility, like: > * initQueryStructuresForNotStartedCache > * addRemovedItemsCleanupTask > * setTxOwnerDumpRequestsAllowed > * longTransactionTimeDumpThreshold > * transactionTimeDumpSamplesCoefficient > * longTransactionTimeDumpSamplesPerSecondLimit > * broadcastToNodesSupportingFeature > * LocalAffinityFunction > * RemovedItemsCleanupTask > * TxTimeoutOnPartitionMapExchangeChangeFuture > * enableRebalance > We need to move them to the right places and make GridCacheProcessor code > cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[
https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044538#comment-17044538
]
Ignite TC Bot commented on IGNITE-12656:
{panel:title=Branch: [pull/7467/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5077782buildTypeId=IgniteTests24Java8_RunAll]
> Cleanup GridCacheProcessor from functionality not related to its
> responsibility
> ---
>
> Key: IGNITE-12656
> URL: https://issues.apache.org/jira/browse/IGNITE-12656
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.8
>Reporter: Vyacheslav Koptilin
>Assignee: Vyacheslav Koptilin
>Priority: Major
> Fix For: 2.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, we have a couple of functionality in GridCacheProcessor not
> directly related to its responsibility, like:
> * initQueryStructuresForNotStartedCache
> * addRemovedItemsCleanupTask
> * setTxOwnerDumpRequestsAllowed
> * longTransactionTimeDumpThreshold
> * transactionTimeDumpSamplesCoefficient
> * longTransactionTimeDumpSamplesPerSecondLimit
> * broadcastToNodesSupportingFeature
> * LocalAffinityFunction
> * RemovedItemsCleanupTask
> * TxTimeoutOnPartitionMapExchangeChangeFuture
> * enableRebalance
> We need to move them to the right places and make GridCacheProcessor code
> cleaner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12656) Cleanup GridCacheProcessor from functionality not related to its responsibility
[
https://issues.apache.org/jira/browse/IGNITE-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033748#comment-17033748
]
Ivan Pavlukhin commented on IGNITE-12656:
-
[~slava.koptilin], would be great to define {{GridCacheProcessor}}
responcibilities e.g. in javadocs. Sincerely existing desing seems very
compicated to me. Would be totally great to improve it.
> Cleanup GridCacheProcessor from functionality not related to its
> responsibility
> ---
>
> Key: IGNITE-12656
> URL: https://issues.apache.org/jira/browse/IGNITE-12656
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.8
>Reporter: Vyacheslav Koptilin
>Assignee: Vyacheslav Koptilin
>Priority: Major
> Fix For: 2.9
>
>
> Currently, we have a couple of functionality in GridCacheProcessor not
> directly related to its responsibility, like:
> * initQueryStructuresForNotStartedCache
> * addRemovedItemsCleanupTask
> * setTxOwnerDumpRequestsAllowed
> * longTransactionTimeDumpThreshold
> * transactionTimeDumpSamplesCoefficient
> * longTransactionTimeDumpSamplesPerSecondLimit
> * broadcastToNodesSupportingFeature
> * LocalAffinityFunction
> * RemovedItemsCleanupTask
> * TxTimeoutOnPartitionMapExchangeChangeFuture
> * enableRebalance
> We need to move them to the right places and make GridCacheProcessor code
> cleaner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
