[jira] [Commented] (IGNITE-12925) Flaky tests for continuous query metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095425#comment-17095425 ] Mikhail Petrov commented on IGNITE-12925: - [~mmuzaf], [~NSAmelchev] Thanks for the review. > Flaky tests for continuous query metrics. > - > > Key: IGNITE-12925 > URL: https://issues.apache.org/jira/browse/IGNITE-12925 > Project: Ignite > Issue Type: Test >Reporter: Mikhail Petrov >Assignee: Mikhail Petrov >Priority: Minor > Fix For: 2.9 > > Time Spent: 20m > Remaining Estimate: 0h > > It is needed to fix flaky tests: > SystemViewSelfTest.testContinuousQuery test – [TC > history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=2075278944640125900=testDetails_IgniteTests24Java8=pull%2F7696%2Fhead] > SqlViewExporterSpiTest#testContinuousQuery – [TC > history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8==testDetails=-5486808152570919536=START_DATE_DESC_IgniteTests24Java8=pull%2F7622%2Fhead=50] > JmxExporterSpiTest#testContinuousQuery – no failures so far but the same test > scenario is used as above. > It seems that QueryCursor#close method > gives no guarantees that CQ routine will be cleared from all nodes before > its returning. This behavior is due to StopRoutineDiscoveryMessage is > immutable and so StopRoutineAckDiscoveryMessage can be received > (QueryCoursor#close method returns) before > GridContinuousProcessor#processStopRequest completion on all nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12925) Flaky tests for continuous query metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095403#comment-17095403 ] Maxim Muzafarov commented on IGNITE-12925: -- [~PetrovMikhail] LGTM, merged to the master branch. > Flaky tests for continuous query metrics. > - > > Key: IGNITE-12925 > URL: https://issues.apache.org/jira/browse/IGNITE-12925 > Project: Ignite > Issue Type: Test >Reporter: Mikhail Petrov >Assignee: Mikhail Petrov >Priority: Minor > Fix For: 2.9 > > Time Spent: 20m > Remaining Estimate: 0h > > It is needed to fix flaky tests: > SystemViewSelfTest.testContinuousQuery test – [TC > history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=2075278944640125900=testDetails_IgniteTests24Java8=pull%2F7696%2Fhead] > SqlViewExporterSpiTest#testContinuousQuery – [TC > history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8==testDetails=-5486808152570919536=START_DATE_DESC_IgniteTests24Java8=pull%2F7622%2Fhead=50] > JmxExporterSpiTest#testContinuousQuery – no failures so far but the same test > scenario is used as above. > It seems that QueryCursor#close method > gives no guarantees that CQ routine will be cleared from all nodes before > its returning. This behavior is due to StopRoutineDiscoveryMessage is > immutable and so StopRoutineAckDiscoveryMessage can be received > (QueryCoursor#close method returns) before > GridContinuousProcessor#processStopRequest completion on all nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12925) Flaky tests for continuous query metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094299#comment-17094299 ] Mikhail Petrov commented on IGNITE-12925: - [~mmuzaf], Could you please take a look? > Flaky tests for continuous query metrics. > - > > Key: IGNITE-12925 > URL: https://issues.apache.org/jira/browse/IGNITE-12925 > Project: Ignite > Issue Type: Test >Reporter: Mikhail Petrov >Assignee: Mikhail Petrov >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > It is needed to fix flaky tests: > SystemViewSelfTest.testContinuousQuery test – [TC > history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=2075278944640125900=testDetails_IgniteTests24Java8=pull%2F7696%2Fhead] > SqlViewExporterSpiTest#testContinuousQuery – [TC > history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8==testDetails=-5486808152570919536=START_DATE_DESC_IgniteTests24Java8=pull%2F7622%2Fhead=50] > JmxExporterSpiTest#testContinuousQuery – no failures so far but the same test > scenario is used as above. > It seems that QueryCursor#close method > gives no guarantees that CQ routine will be cleared from all nodes before > its returning. This behavior is due to StopRoutineDiscoveryMessage is > immutable and so StopRoutineAckDiscoveryMessage can be received > (QueryCoursor#close method returns) before > GridContinuousProcessor#processStopRequest completion on all nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12925) Flaky tests for continuous query metrics.
[
https://issues.apache.org/jira/browse/IGNITE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094298#comment-17094298
]
Ignite TC Bot commented on IGNITE-12925:
{panel:title=Branch: [pull/7747/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5266296buildTypeId=IgniteTests24Java8_RunAll]
> Flaky tests for continuous query metrics.
> -
>
> Key: IGNITE-12925
> URL: https://issues.apache.org/jira/browse/IGNITE-12925
> Project: Ignite
> Issue Type: Test
>Reporter: Mikhail Petrov
>Assignee: Mikhail Petrov
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It is needed to fix flaky tests:
> SystemViewSelfTest.testContinuousQuery test – [TC
> history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=2075278944640125900=testDetails_IgniteTests24Java8=pull%2F7696%2Fhead]
> SqlViewExporterSpiTest#testContinuousQuery – [TC
> history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8==testDetails=-5486808152570919536=START_DATE_DESC_IgniteTests24Java8=pull%2F7622%2Fhead=50]
> JmxExporterSpiTest#testContinuousQuery – no failures so far but the same test
> scenario is used as above.
> It seems that QueryCursor#close method
> gives no guarantees that CQ routine will be cleared from all nodes before
> its returning. This behavior is due to StopRoutineDiscoveryMessage is
> immutable and so StopRoutineAckDiscoveryMessage can be received
> (QueryCoursor#close method returns) before
> GridContinuousProcessor#processStopRequest completion on all nodes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12925) Flaky tests for continuous query metrics.
[ https://issues.apache.org/jira/browse/IGNITE-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093884#comment-17093884 ] Amelchev Nikita commented on IGNITE-12925: -- [~PetrovMikhail], LGTM. > Flaky tests for continuous query metrics. > - > > Key: IGNITE-12925 > URL: https://issues.apache.org/jira/browse/IGNITE-12925 > Project: Ignite > Issue Type: Test >Reporter: Mikhail Petrov >Assignee: Mikhail Petrov >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > It is needed to fix flaky tests: > SystemViewSelfTest.testContinuousQuery test – [TC > history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=2075278944640125900=testDetails_IgniteTests24Java8=pull%2F7696%2Fhead] > SqlViewExporterSpiTest#testContinuousQuery – [TC > history|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8==testDetails=-5486808152570919536=START_DATE_DESC_IgniteTests24Java8=pull%2F7622%2Fhead=50] > JmxExporterSpiTest#testContinuousQuery – no failures so far but the same test > scenario is used as above. > It seems that QueryCursor#close method > gives no guarantees that CQ routine will be cleared from all nodes before > its returning. This behavior is due to StopRoutineDiscoveryMessage is > immutable and so StopRoutineAckDiscoveryMessage can be received > (QueryCoursor#close method returns) before > GridContinuousProcessor#processStopRequest completion on all nodes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
