[jira] [Commented] (IGNITE-13144) Improve ClusterState enum and other minor improvements for the cluster read-only mode.
[
https://issues.apache.org/jira/browse/IGNITE-13144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141483#comment-17141483
]
Ignite TC Bot commented on IGNITE-13144:
{panel:title=Branch: [pull/7924/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5403682buildTypeId=IgniteTests24Java8_RunAll]
> Improve ClusterState enum and other minor improvements for the cluster
> read-only mode.
> --
>
> Key: IGNITE-13144
> URL: https://issues.apache.org/jira/browse/IGNITE-13144
> Project: Ignite
> Issue Type: Improvement
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.9
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We have {{boolean ClusterState#active(ClusterState)}} static method. It would
> be better to have an instance method {{boolean active()}}.
> Also, we have ClusterState#lesserOf static method. It needs for internal
> purposes. So we must move this method in an internal package.
> We introduced new compute requests for getting/change cluster state from the
> client node as internal classes of GridClusterStateProcessor. We should move
> them to separate public classes for maintainability purposes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13144) Improve ClusterState enum and other minor improvements for the cluster read-only mode.
[
https://issues.apache.org/jira/browse/IGNITE-13144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140713#comment-17140713
]
Sergey Antonov commented on IGNITE-13144:
-
[~alex_pl] Thank you for the your review. I fixed most of them and answered
others. Could you look again, please?
> Improve ClusterState enum and other minor improvements for the cluster
> read-only mode.
> --
>
> Key: IGNITE-13144
> URL: https://issues.apache.org/jira/browse/IGNITE-13144
> Project: Ignite
> Issue Type: Improvement
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.9
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We have {{boolean ClusterState#active(ClusterState)}} static method. It would
> be better to have an instance method {{boolean active()}}.
> Also, we have ClusterState#lesserOf static method. It needs for internal
> purposes. So we must move this method in an internal package.
> We introduced new compute requests for getting/change cluster state from the
> client node as internal classes of GridClusterStateProcessor. We should move
> them to separate public classes for maintainability purposes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13144) Improve ClusterState enum and other minor improvements for the cluster read-only mode.
[
https://issues.apache.org/jira/browse/IGNITE-13144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139104#comment-17139104
]
Ignite TC Bot commented on IGNITE-13144:
{panel:title=Branch: [pull/7924/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5397196buildTypeId=IgniteTests24Java8_RunAll]
> Improve ClusterState enum and other minor improvements for the cluster
> read-only mode.
> --
>
> Key: IGNITE-13144
> URL: https://issues.apache.org/jira/browse/IGNITE-13144
> Project: Ignite
> Issue Type: Improvement
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have {{boolean ClusterState#active(ClusterState)}} static method. It would
> be better to have an instance method {{boolean active()}}.
> Also, we have ClusterState#lesserOf static method. It needs for internal
> purposes. So we must move this method in an internal package.
> We introduced new compute requests for getting/change cluster state from the
> client node as internal classes of GridClusterStateProcessor. We should move
> them to separate public classes for maintainability purposes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
