[jira] [Commented] (IGNITE-13226) .NET: Thin Client Compute leaks ClientNotificationHandler instances

2020-07-08 Thread Pavel Tupitsyn (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153423#comment-17153423
 ] 

Pavel Tupitsyn commented on IGNITE-13226:
-

Merged to master: 69c5b516686924834876d3f52d349ac1880b20f3
Cherry-picked to ignite-2.9: bffe714072c3b9d45cad1bc6cd2a2fcf100b0795

> .NET: Thin Client Compute leaks ClientNotificationHandler instances
> ---
>
> Key: IGNITE-13226
> URL: https://issues.apache.org/jira/browse/IGNITE-13226
> Project: Ignite
>  Issue Type: Bug
>  Components: platforms
>Affects Versions: 2.9
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Critical
>  Labels: .NET
> Fix For: 2.9
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In multithreaded thin client compute scenarios there is a possibility for 
> ClientNotificationHandler leak: handlers remain in 
> ClientSocket._notificationListeners even after corresponding tasks have 
> completed.
> To reproduce, add the following code at the end of 
> ComputeClientTests.TestExecuteJavaTaskAsyncMultithreaded:
> {code}
> var failoverSocket = 
> TestUtils.GetPrivateField(client, "_socket");
> var socket = 
> TestUtils.GetPrivateField(failoverSocket, "_socket");
> var listeners = TestUtils.GetPrivateField(socket, 
> "_notificationListeners");
> Assert.IsEmpty(listeners);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13226) .NET: Thin Client Compute leaks ClientNotificationHandler instances

2020-07-07 Thread Sergey Stronchinskiy (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153072#comment-17153072
 ] 

Sergey Stronchinskiy commented on IGNITE-13226:
---

[~ptupitsyn] looks fine to me!

> .NET: Thin Client Compute leaks ClientNotificationHandler instances
> ---
>
> Key: IGNITE-13226
> URL: https://issues.apache.org/jira/browse/IGNITE-13226
> Project: Ignite
>  Issue Type: Bug
>  Components: platforms
>Affects Versions: 2.9
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Critical
>  Labels: .NET
> Fix For: 2.9
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In multithreaded thin client compute scenarios there is a possibility for 
> ClientNotificationHandler leak: handlers remain in 
> ClientSocket._notificationListeners even after corresponding tasks have 
> completed.
> To reproduce, add the following code at the end of 
> ComputeClientTests.TestExecuteJavaTaskAsyncMultithreaded:
> {code}
> var failoverSocket = 
> TestUtils.GetPrivateField(client, "_socket");
> var socket = 
> TestUtils.GetPrivateField(failoverSocket, "_socket");
> var listeners = TestUtils.GetPrivateField(socket, 
> "_notificationListeners");
> Assert.IsEmpty(listeners);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-13226) .NET: Thin Client Compute leaks ClientNotificationHandler instances

2020-07-07 Thread Ignite TC Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152980#comment-17152980
 ] 

Ignite TC Bot commented on IGNITE-13226:


{panel:title=Branch: [pull/8003/head] Base: [master] : Possible Blockers 
(5)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}PDS 4{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=5446507]]
* IgnitePdsTestSuite4: 
ResetLostPartitionTest.testReactivateGridBeforeResetLostPartitions - Test has 
low fail rate in base branch 0,0% and is not flaky

{color:#d04437}Queries 1{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=5446514]]
* IgniteBinaryCacheQueryTestSuite: 
IndexingCachePartitionLossPolicySelfTest.checkLostPartition[ATOMIC IGNORE 2 
true 5 false] - Test has low fail rate in base branch 0,0% and is not flaky

{color:#d04437}Cache 9{color} [[tests 0 TIMEOUT , Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=5446495]]

{color:#d04437}Thin client: PHP{color} [[tests 0 Exit Code 
|https://ci.ignite.apache.org/viewLog.html?buildId=5446473]]

{color:#d04437}Cache (Deadlock Detection){color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=5446476]]
* TxDeadlockDetectionTestSuite: 
TxOptimisticDeadlockDetectionTest.testDeadlocksPartitionedNear - Test has low 
fail rate in base branch 0,0% and is not flaky

{panel}
{panel:title=Branch: [pull/8003/head] Base: [master] : New Tests 
(14)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}PDS (Indexing){color} [tests 4]
* {color:#013220}IgnitePdsWithIndexingCoreTestSuite: 
IgniteWalRebalanceTest.testSwitchHistoricalRebalanceToFullAndClientJoin - 
PASSED{color}
* {color:#013220}IgnitePdsWithIndexingCoreTestSuite: 
IgniteWalRebalanceTest.testMultipleNodesFailHistoricalRebalance - PASSED{color}
* {color:#013220}IgnitePdsWithIndexingCoreTestSuite: 
IgniteWalRebalanceTest.testSwitchHistoricalRebalanceToFullDueToFailOnCreatingWalIterator
 - PASSED{color}
* {color:#013220}IgnitePdsWithIndexingCoreTestSuite: 
IgniteWalRebalanceTest.testSwitchHistoricalRebalanceToFullWhileIteratingOverWAL 
- PASSED{color}

{color:#8b}Queries 1{color} [tests 2]
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
QueryEntityValidationSelfTest.testNotUniqueNameInAnnotation - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: 
QueryEntityValidationSelfTest.testUniqueNameInAnnotation - PASSED{color}

{color:#8b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=f8236df7-1439-483f-a00f-20c41dec4c72, topVer=0, 
nodeId8=1316ee8a, msg=, type=NODE_JOINED, tstamp=1594138329084], 
val2=AffinityTopologyVersion [topVer=-3639958942977458018, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=f8236df7-1439-483f-a00f-20c41dec4c72, topVer=0, 
nodeId8=1316ee8a, msg=, type=NODE_JOINED, tstamp=1594138329084], 
val2=AffinityTopologyVersion [topVer=-3639958942977458018, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=e52861a2371-46cf0102-5dd2-43ab-8b44-657a3e304fde, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=548b58b6-53f7-4964-9b54-ab6b80281089, topVer=0, nodeId8=548b58b6, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594138329084]], 
val2=AffinityTopologyVersion [topVer=-4849584122826975164, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest 
[id=e52861a2371-46cf0102-5dd2-43ab-8b44-657a3e304fde, reqs=SingletonList 
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent 
[evtNode=548b58b6-53f7-4964-9b54-ab6b80281089, topVer=0, nodeId8=548b58b6, 
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1594138329084]], 
val2=AffinityTopologyVersion [topVer=-4849584122826975164, minorTopVer=0]]] - 
PASSED{color}

{color:#8b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple 
[val1=DiscoveryEvent [evtNode=07100f3c-2238-4b38-901e-7d3543449ec5, topVer=0, 
nodeId8=b879cf82, msg=, type=NODE_JOINED, tstamp=1594138975529], 
val2=AffinityTopologyVersion [topVer=1806221681363858205, minorTopVer=0]]] - 
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: 
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple 
[val1=DiscoveryCustomEvent

[jira] [Commented] (IGNITE-13226) .NET: Thin Client Compute leaks ClientNotificationHandler instances

2020-07-07 Thread Pavel Tupitsyn (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152842#comment-17152842
 ] 

Pavel Tupitsyn commented on IGNITE-13226:
-

[~GuruStron] can you please review?

> .NET: Thin Client Compute leaks ClientNotificationHandler instances
> ---
>
> Key: IGNITE-13226
> URL: https://issues.apache.org/jira/browse/IGNITE-13226
> Project: Ignite
>  Issue Type: Bug
>  Components: platforms
>Affects Versions: 2.9
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Critical
>  Labels: .NET
> Fix For: 2.9
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In multithreaded thin client compute scenarios there is a possibility for 
> ClientNotificationHandler leak: handlers remain in 
> ClientSocket._notificationListeners even after corresponding tasks have 
> completed.
> To reproduce, add the following code at the end of 
> ComputeClientTests.TestExecuteJavaTaskAsyncMultithreaded:
> {code}
> var failoverSocket = 
> TestUtils.GetPrivateField(client, "_socket");
> var socket = 
> TestUtils.GetPrivateField(failoverSocket, "_socket");
> var listeners = TestUtils.GetPrivateField(socket, 
> "_notificationListeners");
> Assert.IsEmpty(listeners);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)