[jira] [Commented] (IGNITE-13420) Add assertion message to assert in CachedDeploymentInfo private constructor
[
https://issues.apache.org/jira/browse/IGNITE-13420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195368#comment-17195368
]
Maxim Muzafarov commented on IGNITE-13420:
--
[~ksirotkin]
Thanks for the improvement.
Merged to the master branch.
> Add assertion message to assert in CachedDeploymentInfo private constructor
> ---
>
> Key: IGNITE-13420
> URL: https://issues.apache.org/jira/browse/IGNITE-13420
> Project: Ignite
> Issue Type: Improvement
>Reporter: Konstantin Sirotkin
>Assignee: Konstantin Sirotkin
>Priority: Minor
> Fix For: 2.10
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We have an assertion in
> org.apache.ignite.internal.processors.cache.GridCacheDeploymentManager.CachedDeploymentInfo#CachedDeploymentInfo:
>
> {code:java}
> private CachedDeploymentInfo(UUID sndId, IgniteUuid ldrId, String userVer,
> DeploymentMode depMode,
> Map participants) {
> assert sndId.equals(ldrId.globalId()) || participants != null;
> this.sndId = sndId;
> this.ldrId = ldrId;
> this.userVer = userVer;
> this.depMode = depMode;
> this.participants = participants == null ||
> participants.isEmpty() ? null :
> new ConcurrentLinkedHashMap<>(participants);
> }
> {code}
> Now we can't define assertion reason. We should add assertion message to that
> place.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13420) Add assertion message to assert in CachedDeploymentInfo private constructor
[
https://issues.apache.org/jira/browse/IGNITE-13420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194968#comment-17194968
]
Konstantin Sirotkin commented on IGNITE-13420:
--
[Maxim Muzafarov
|file:///jira/secure/ViewProfile.jspa%3fname=mmuzaf]
Initial problem was fixed in
[https://issues.apache.org/jira/browse/IGNITE-12760].
Here I add assertion message for debug in case if assertion will be triggered
by another reason.
> Add assertion message to assert in CachedDeploymentInfo private constructor
> ---
>
> Key: IGNITE-13420
> URL: https://issues.apache.org/jira/browse/IGNITE-13420
> Project: Ignite
> Issue Type: Improvement
>Reporter: Konstantin Sirotkin
>Assignee: Konstantin Sirotkin
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have an assertion in
> org.apache.ignite.internal.processors.cache.GridCacheDeploymentManager.CachedDeploymentInfo#CachedDeploymentInfo:
>
> {code:java}
> private CachedDeploymentInfo(UUID sndId, IgniteUuid ldrId, String userVer,
> DeploymentMode depMode,
> Map participants) {
> assert sndId.equals(ldrId.globalId()) || participants != null;
> this.sndId = sndId;
> this.ldrId = ldrId;
> this.userVer = userVer;
> this.depMode = depMode;
> this.participants = participants == null ||
> participants.isEmpty() ? null :
> new ConcurrentLinkedHashMap<>(participants);
> }
> {code}
> Now we can't define assertion reason. We should add assertion message to that
> place.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13420) Add assertion message to assert in CachedDeploymentInfo private constructor
[
https://issues.apache.org/jira/browse/IGNITE-13420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194086#comment-17194086
]
Maxim Muzafarov commented on IGNITE-13420:
--
[~ksirotkin]
Do you have reproduces or test scenario which fails with this assertion?
I'm not against this change, but probably will be better to fix the cause.
> Add assertion message to assert in CachedDeploymentInfo private constructor
> ---
>
> Key: IGNITE-13420
> URL: https://issues.apache.org/jira/browse/IGNITE-13420
> Project: Ignite
> Issue Type: Improvement
>Reporter: Konstantin Sirotkin
>Assignee: Konstantin Sirotkin
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have an assertion in
> org.apache.ignite.internal.processors.cache.GridCacheDeploymentManager.CachedDeploymentInfo#CachedDeploymentInfo:
>
> {code:java}
> private CachedDeploymentInfo(UUID sndId, IgniteUuid ldrId, String userVer,
> DeploymentMode depMode,
> Map participants) {
> assert sndId.equals(ldrId.globalId()) || participants != null;
> this.sndId = sndId;
> this.ldrId = ldrId;
> this.userVer = userVer;
> this.depMode = depMode;
> this.participants = participants == null ||
> participants.isEmpty() ? null :
> new ConcurrentLinkedHashMap<>(participants);
> }
> {code}
> Now we can't define assertion reason. We should add assertion message to that
> place.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13420) Add assertion message to assert in CachedDeploymentInfo private constructor
[
https://issues.apache.org/jira/browse/IGNITE-13420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193196#comment-17193196
]
Ignite TC Bot commented on IGNITE-13420:
{panel:title=Branch: [pull/8231/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8231/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5594102buildTypeId=IgniteTests24Java8_RunAll]
> Add assertion message to assert in CachedDeploymentInfo private constructor
> ---
>
> Key: IGNITE-13420
> URL: https://issues.apache.org/jira/browse/IGNITE-13420
> Project: Ignite
> Issue Type: Improvement
>Reporter: Konstantin Sirotkin
>Assignee: Konstantin Sirotkin
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have an assertion in
> org.apache.ignite.internal.processors.cache.GridCacheDeploymentManager.CachedDeploymentInfo#CachedDeploymentInfo:
>
> {code:java}
> private CachedDeploymentInfo(UUID sndId, IgniteUuid ldrId, String userVer,
> DeploymentMode depMode,
> Map participants) {
> assert sndId.equals(ldrId.globalId()) || participants != null;
> this.sndId = sndId;
> this.ldrId = ldrId;
> this.userVer = userVer;
> this.depMode = depMode;
> this.participants = participants == null ||
> participants.isEmpty() ? null :
> new ConcurrentLinkedHashMap<>(participants);
> }
> {code}
> Now we can't define assertion reason. We should add assertion message to that
> place.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
