[jira] [Commented] (IGNITE-14849) Calcite engine. Support '%' operator as alias for 'mod' function

2021-06-17 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-14849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364809#comment-17364809
 ] 

Aleksey Plekhanov commented on IGNITE-14849:


[~zstan] thanks for the review! Merged to sql-calcite branch.

> Calcite engine. Support '%' operator as alias for 'mod' function
> 
>
> Key: IGNITE-14849
> URL: https://issues.apache.org/jira/browse/IGNITE-14849
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Aleksey Plekhanov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the H2-based SQL engine supports both {{a % b}} and {{mod(a, b)}} 
> syntax for the modulo operation. But calcite-based engine supports only 
> {{mod(a, b)}} syntax. Support for {{%}} operator should be added to minimize 
> compatibility issues. 
> Affected tests:
> {{src/test/sql/aggregate/group/test_group_by.test}}
> And many other.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-14849) Calcite engine. Support '%' operator as alias for 'mod' function

2021-06-16 Thread Stanilovsky Evgeny (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-14849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364351#comment-17364351
 ] 

Stanilovsky Evgeny commented on IGNITE-14849:
-

looks good !

> Calcite engine. Support '%' operator as alias for 'mod' function
> 
>
> Key: IGNITE-14849
> URL: https://issues.apache.org/jira/browse/IGNITE-14849
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Aleksey Plekhanov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the H2-based SQL engine supports both {{a % b}} and {{mod(a, b)}} 
> syntax for the modulo operation. But calcite-based engine supports only 
> {{mod(a, b)}} syntax. Support for {{%}} operator should be added to minimize 
> compatibility issues. 
> Affected tests:
> {{src/test/sql/aggregate/group/test_group_by.test}}
> And many other.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (IGNITE-14849) Calcite engine. Support '%' operator as alias for 'mod' function

2021-06-10 Thread Aleksey Plekhanov (Jira) 


[ 
https://issues.apache.org/jira/browse/IGNITE-14849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360760#comment-17360760
 ] 

Aleksey Plekhanov commented on IGNITE-14849:


[~korlov], [~tledkov-gridgain], can you please have a look?

> Calcite engine. Support '%' operator as alias for 'mod' function
> 
>
> Key: IGNITE-14849
> URL: https://issues.apache.org/jira/browse/IGNITE-14849
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Aleksey Plekhanov
>Assignee: Aleksey Plekhanov
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the H2-based SQL engine supports both {{a % b}} and {{mod(a, b)}} 
> syntax for the modulo operation. But calcite-based engine supports only 
> {{mod(a, b)}} syntax. Support for {{%}} operator should be added to minimize 
> compatibility issues. 
> Affected tests:
> {{src/test/sql/aggregate/group/test_group_by.test}}
> And many other.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)