[jira] [Commented] (IGNITE-15052) Move thread pools creation to PoolProcessor.
[ https://issues.apache.org/jira/browse/IGNITE-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390393#comment-17390393 ] Mikhail Petrov commented on IGNITE-15052: - [~alex_pl], Thanks a lot for the review! > Move thread pools creation to PoolProcessor. > > > Key: IGNITE-15052 > URL: https://issues.apache.org/jira/browse/IGNITE-15052 > Project: Ignite > Issue Type: Improvement >Reporter: Mikhail Petrov >Assignee: Mikhail Petrov >Priority: Major > Fix For: 2.12 > > Time Spent: 20m > Remaining Estimate: 0h > > It is proposed to > 1. move the creation of thread pools that are shared across multiple Ignite > processors to the PoolProcessor - now they are created in IgniitonEx > 2. get thread pools instances through the PoolProcessor - now they are > obtained through GridKernalContext > This helps to encapsulate the logic related to shared thread pools into a > dedicated processor that is in charge of thread pool management. The > implementation of this proposal will also allow to implement more reliable > way to keep correct security context for tasks that are asynchronously > executed in thread pools. > The only questionable change associated with this proposal is that thread > pools will be stopped earlier than before but tests shows no issues with it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-15052) Move thread pools creation to PoolProcessor.
[
https://issues.apache.org/jira/browse/IGNITE-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389931#comment-17389931
]
Ignite TC Bot commented on IGNITE-15052:
{panel:title=Branch: [pull/9224/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9224/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6108390buildTypeId=IgniteTests24Java8_RunAll]
> Move thread pools creation to PoolProcessor.
>
>
> Key: IGNITE-15052
> URL: https://issues.apache.org/jira/browse/IGNITE-15052
> Project: Ignite
> Issue Type: Improvement
>Reporter: Mikhail Petrov
>Assignee: Mikhail Petrov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is proposed to
> 1. move the creation of thread pools that are shared across multiple Ignite
> processors to the PoolProcessor - now they are created in IgniitonEx
> 2. get thread pools instances through the PoolProcessor - now they are
> obtained through GridKernalContext
> This helps to encapsulate the logic related to shared thread pools into a
> dedicated processor that is in charge of thread pool management. The
> implementation of this proposal will also allow to implement more reliable
> way to keep correct security context for tasks that are asynchronously
> executed in thread pools.
> The only questionable change associated with this proposal is that thread
> pools will be stopped earlier than before but tests shows no issues with it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
