[jira] [Commented] (IGNITE-15107) Integrate DDL handler into Ignite 3.0
[
https://issues.apache.org/jira/browse/IGNITE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458200#comment-17458200
]
Konstantin Orlov commented on IGNITE-15107:
---
[~zstan], LGTM!
> Integrate DDL handler into Ignite 3.0
> -
>
> Key: IGNITE-15107
> URL: https://issues.apache.org/jira/browse/IGNITE-15107
> Project: Ignite
> Issue Type: Sub-task
> Components: sql
>Reporter: Konstantin Orlov
>Assignee: Evgeny Stanilovsky
>Priority: Major
> Labels: calcite, calcite3-required, ignite-3
> Time Spent: 16h 50m
> Remaining Estimate: 0h
>
> Need to implement handler of the following basic commands:
> * Create table
> * Alter table
> * Drop table
> * Create index
> * Drop index
> Reference point is
> {{org.apache.ignite.internal.processors.query.calcite.exec.ddl.DdlCommandHandler}}.
> Required tests are available in following classes:
> {{org.apache.ignite.internal.processors.query.calcite.integration.IndexDdlIntegrationTest}}
> {{org.apache.ignite.internal.processors.query.calcite.integration.TableDdlIntegrationTest}}
> NB: all referenced classes are resided in ignite-2 codebase in
> {{sql-calcite}} branch.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (IGNITE-15107) Integrate DDL handler into Ignite 3.0
[
https://issues.apache.org/jira/browse/IGNITE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451754#comment-17451754
]
Evgeny Stanilovsky commented on IGNITE-15107:
-
[~amashenkov], [~jooger], [~tledkov-gridgain] make a review plz, thanks !
> Integrate DDL handler into Ignite 3.0
> -
>
> Key: IGNITE-15107
> URL: https://issues.apache.org/jira/browse/IGNITE-15107
> Project: Ignite
> Issue Type: Sub-task
> Components: sql
>Reporter: Konstantin Orlov
>Assignee: Evgeny Stanilovsky
>Priority: Major
> Labels: calcite, calcite3-required, ignite-3
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Need to implement handler of the following basic commands:
> * Create table
> * Alter table
> * Drop table
> * Create index
> * Drop index
> Reference point is
> {{org.apache.ignite.internal.processors.query.calcite.exec.ddl.DdlCommandHandler}}.
> Required tests are available in following classes:
> {{org.apache.ignite.internal.processors.query.calcite.integration.IndexDdlIntegrationTest}}
> {{org.apache.ignite.internal.processors.query.calcite.integration.TableDdlIntegrationTest}}
> NB: all referenced classes are resided in ignite-2 codebase in
> {{sql-calcite}} branch.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (IGNITE-15107) Integrate DDL handler into Ignite 3.0
[
https://issues.apache.org/jira/browse/IGNITE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413069#comment-17413069
]
Evgeny Stanilovsky commented on IGNITE-15107:
-
[~amashenkov] plz take a look, i complete with table api refactoring.
> Integrate DDL handler into Ignite 3.0
> -
>
> Key: IGNITE-15107
> URL: https://issues.apache.org/jira/browse/IGNITE-15107
> Project: Ignite
> Issue Type: Sub-task
> Components: sql
>Reporter: Konstantin Orlov
>Assignee: Evgeny Stanilovsky
>Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Need to implement handler of the following basic commands:
> * Create table
> * Alter table
> * Drop table
> * Create index
> * Drop index
> Reference point is
> {{org.apache.ignite.internal.processors.query.calcite.exec.ddl.DdlCommandHandler}}.
> Required tests are available in following classes:
> {{org.apache.ignite.internal.processors.query.calcite.integration.IndexDdlIntegrationTest}}
> {{org.apache.ignite.internal.processors.query.calcite.integration.TableDdlIntegrationTest}}
> NB: all referenced classes are resided in ignite-2 codebase in
> {{sql-calcite}} branch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-15107) Integrate DDL handler into Ignite 3.0
[
https://issues.apache.org/jira/browse/IGNITE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412341#comment-17412341
]
Evgeny Stanilovsky commented on IGNITE-15107:
-
[~amashenkov] my fault, now seems all ok. There are some api restrictions (we
are talking about) possibly we can merge it as is (if all other ok).
[~korlov] thanks for review, any additional suggestions?
> Integrate DDL handler into Ignite 3.0
> -
>
> Key: IGNITE-15107
> URL: https://issues.apache.org/jira/browse/IGNITE-15107
> Project: Ignite
> Issue Type: Sub-task
> Components: sql
>Reporter: Konstantin Orlov
>Assignee: Evgeny Stanilovsky
>Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Need to implement handler of the following basic commands:
> * Create table
> * Alter table
> * Drop table
> * Create index
> * Drop index
> Reference point is
> {{org.apache.ignite.internal.processors.query.calcite.exec.ddl.DdlCommandHandler}}.
> Required tests are available in following classes:
> {{org.apache.ignite.internal.processors.query.calcite.integration.IndexDdlIntegrationTest}}
> {{org.apache.ignite.internal.processors.query.calcite.integration.TableDdlIntegrationTest}}
> NB: all referenced classes are resided in ignite-2 codebase in
> {{sql-calcite}} branch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-15107) Integrate DDL handler into Ignite 3.0
[
https://issues.apache.org/jira/browse/IGNITE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411890#comment-17411890
]
Andrey Mashenkov commented on IGNITE-15107:
---
[~zstan], please check TC. There is a compilation issue.
> Integrate DDL handler into Ignite 3.0
> -
>
> Key: IGNITE-15107
> URL: https://issues.apache.org/jira/browse/IGNITE-15107
> Project: Ignite
> Issue Type: Sub-task
> Components: sql
>Reporter: Konstantin Orlov
>Assignee: Evgeny Stanilovsky
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Need to implement handler of the following basic commands:
> * Create table
> * Alter table
> * Drop table
> * Create index
> * Drop index
> Reference point is
> {{org.apache.ignite.internal.processors.query.calcite.exec.ddl.DdlCommandHandler}}.
> Required tests are available in following classes:
> {{org.apache.ignite.internal.processors.query.calcite.integration.IndexDdlIntegrationTest}}
> {{org.apache.ignite.internal.processors.query.calcite.integration.TableDdlIntegrationTest}}
> NB: all referenced classes are resided in ignite-2 codebase in
> {{sql-calcite}} branch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-15107) Integrate DDL handler into Ignite 3.0
[
https://issues.apache.org/jira/browse/IGNITE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411856#comment-17411856
]
Evgeny Stanilovsky commented on IGNITE-15107:
-
[~korlov] [~amashenkov] guys thanks ! i fix all your comments.
> Integrate DDL handler into Ignite 3.0
> -
>
> Key: IGNITE-15107
> URL: https://issues.apache.org/jira/browse/IGNITE-15107
> Project: Ignite
> Issue Type: Sub-task
> Components: sql
>Reporter: Konstantin Orlov
>Assignee: Evgeny Stanilovsky
>Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Need to implement handler of the following basic commands:
> * Create table
> * Alter table
> * Drop table
> * Create index
> * Drop index
> Reference point is
> {{org.apache.ignite.internal.processors.query.calcite.exec.ddl.DdlCommandHandler}}.
> Required tests are available in following classes:
> {{org.apache.ignite.internal.processors.query.calcite.integration.IndexDdlIntegrationTest}}
> {{org.apache.ignite.internal.processors.query.calcite.integration.TableDdlIntegrationTest}}
> NB: all referenced classes are resided in ignite-2 codebase in
> {{sql-calcite}} branch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-15107) Integrate DDL handler into Ignite 3.0
[
https://issues.apache.org/jira/browse/IGNITE-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17410533#comment-17410533
]
Evgeny Stanilovsky commented on IGNITE-15107:
-
[~korlov] [~tledkov-gridgain] [~amashenkov] pr ready for review, guys check it
plz.
> Integrate DDL handler into Ignite 3.0
> -
>
> Key: IGNITE-15107
> URL: https://issues.apache.org/jira/browse/IGNITE-15107
> Project: Ignite
> Issue Type: Sub-task
> Components: sql
>Reporter: Konstantin Orlov
>Assignee: Evgeny Stanilovsky
>Priority: Major
>
> Need to implement handler of the following basic commands:
> * Create table
> * Alter table
> * Drop table
> * Create index
> * Drop index
> Reference point is
> {{org.apache.ignite.internal.processors.query.calcite.exec.ddl.DdlCommandHandler}}.
> Required tests are available in following classes:
> {{org.apache.ignite.internal.processors.query.calcite.integration.IndexDdlIntegrationTest}}
> {{org.apache.ignite.internal.processors.query.calcite.integration.TableDdlIntegrationTest}}
> NB: all referenced classes are resided in ignite-2 codebase in
> {{sql-calcite}} branch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
