[jira] [Commented] (IGNITE-1572) .Net: Check if we can get rid of "WritePortableOrSerializable" method.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010569#comment-15010569
 ] 

ASF GitHub Bot commented on IGNITE-1572:


Github user ptupitsyn closed the pull request at:

https://github.com/apache/ignite/pull/122


> .Net: Check if we can get rid of "WritePortableOrSerializable" method.
> --
>
> Key: IGNITE-1572
> URL: https://issues.apache.org/jira/browse/IGNITE-1572
> Project: Ignite
>  Issue Type: Task
>  Components: interop
>Affects Versions: ignite-1.4
>Reporter: Vladimir Ozerov
>Assignee: Vladimir Ozerov
>Priority: Critical
> Fix For: 1.5
>
>
> We have lots of places where "WritePortableOrSerializable" routine is 
> invoked. It is not clear why do we need it provided that we already handle 
> [Serializable] classes properly. 
> Looks like we are able to get rid of it safely, aren't we? Need to 
> double-check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1572) .Net: Check if we can get rid of "WritePortableOrSerializable" method.

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952943#comment-14952943
 ] 

Pavel  Tupitsyn commented on IGNITE-1572:
-

1) I have fixed TestPortableObjectInTask by adding a wrapper in the test 
itself. This use is very unlikely, so we can tell users to create their own 
wrapper (which is trivial).
2) .

> .Net: Check if we can get rid of "WritePortableOrSerializable" method.
> --
>
> Key: IGNITE-1572
> URL: https://issues.apache.org/jira/browse/IGNITE-1572
> Project: Ignite
>  Issue Type: Task
>  Components: interop
>Affects Versions: ignite-1.4
>Reporter: Vladimir Ozerov
>Assignee: Pavel  Tupitsyn
>Priority: Critical
> Fix For: 1.5
>
>
> We have lots of places where "WritePortableOrSerializable" routine is 
> invoked. It is not clear why do we need it provided that we already handle 
> [Serializable] classes properly. 
> Looks like we are able to get rid of it safely, aren't we? Need to 
> double-check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1572) .Net: Check if we can get rid of "WritePortableOrSerializable" method.

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941040#comment-14941040
 ] 

Pavel  Tupitsyn commented on IGNITE-1572:
-

Good catch, I have remove these wrappers, since we have 
SerializableObjectHolder in Writer/Reader.
However, one test (TestPortableObjectInTask) has failed. We have 2 issues:
* .Net writes user objects as FullObj (103) or PortObj (27), but Java always 
returns them as PortObj (27), so we loose that information. Removed wrappers 
indirectly solved that problem.
* In KeepPortable mode with Serializable object, we return PortableUserObject 
[SerializableObjectHolder] to the user, which is a bug, causes by the first 
issue.

> .Net: Check if we can get rid of "WritePortableOrSerializable" method.
> --
>
> Key: IGNITE-1572
> URL: https://issues.apache.org/jira/browse/IGNITE-1572
> Project: Ignite
>  Issue Type: Task
>  Components: interop
>Affects Versions: ignite-1.4
>Reporter: Vladimir Ozerov
>Assignee: Pavel  Tupitsyn
>Priority: Critical
> Fix For: ignite-1.5
>
>
> We have lots of places where "WritePortableOrSerializable" routine is 
> invoked. It is not clear why do we need it provided that we already handle 
> [Serializable] classes properly. 
> Looks like we are able to get rid of it safely, aren't we? Need to 
> double-check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1572) .Net: Check if we can get rid of "WritePortableOrSerializable" method.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939721#comment-14939721
 ] 

ASF GitHub Bot commented on IGNITE-1572:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/122

IGNITE-1572 .Net: Check if we can get rid of "WritePortableOrSerializable" 
method.

Replace WritePortableOrSerializable with WriteObject

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptupitsyn/ignite ignite-1572

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #122


commit f984341062477a8fef7823205d68947b344836ce
Author: ptupitsyn 
Date:   2015-10-01T11:51:20Z

IGNITE-1572 .Net: Check if we can get rid of "WritePortableOrSerializable" 
method.

Replace WritePortableOrSerializable with WriteObject




> .Net: Check if we can get rid of "WritePortableOrSerializable" method.
> --
>
> Key: IGNITE-1572
> URL: https://issues.apache.org/jira/browse/IGNITE-1572
> Project: Ignite
>  Issue Type: Task
>  Components: interop
>Affects Versions: ignite-1.4
>Reporter: Vladimir Ozerov
>Assignee: Pavel  Tupitsyn
>Priority: Critical
> Fix For: ignite-1.5
>
>
> We have lots of places where "WritePortableOrSerializable" routine is 
> invoked. It is not clear why do we need it provided that we already handle 
> [Serializable] classes properly. 
> Looks like we are able to get rid of it safely, aren't we? Need to 
> double-check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)