[jira] [Commented] (IGNITE-15833) Provide interfaces for SQL Extension API
[ https://issues.apache.org/jira/browse/IGNITE-15833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443777#comment-17443777 ] Konstantin Orlov commented on IGNITE-15833: --- [~Berkov], licenses have been added. Folks, thanks for review. Merged to master. > Provide interfaces for SQL Extension API > > > Key: IGNITE-15833 > URL: https://issues.apache.org/jira/browse/IGNITE-15833 > Project: Ignite > Issue Type: Sub-task >Reporter: Konstantin Orlov >Assignee: Konstantin Orlov >Priority: Major > Labels: ignite-3 > Time Spent: 0.5h > Remaining Estimate: 0h > > During this task we need to provide minimal yet sufficient interfaces to make > extension possible. Followed aspects should be covered: > # Interface of the plugin (draft could be found in parent ticket) > # Interface to implement by relational nodes. Looks like we have to use > IgniteRel here, but it comes at cost of lost validation: IgniteConvention > uses this interface to validate the convention is set for proper rel. Need to > think about this. > # Interface of the schema. In the prototype the > org.apache.calcite.schema.SchemaPlus is used, but it doesn't look as a good > decision. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-15833) Provide interfaces for SQL Extension API
[ https://issues.apache.org/jira/browse/IGNITE-15833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443722#comment-17443722 ] Taras Ledkov commented on IGNITE-15833: --- [~korlov], the patch is OK with me. > Provide interfaces for SQL Extension API > > > Key: IGNITE-15833 > URL: https://issues.apache.org/jira/browse/IGNITE-15833 > Project: Ignite > Issue Type: Sub-task >Reporter: Konstantin Orlov >Assignee: Konstantin Orlov >Priority: Major > Labels: ignite-3 > Time Spent: 20m > Remaining Estimate: 0h > > During this task we need to provide minimal yet sufficient interfaces to make > extension possible. Followed aspects should be covered: > # Interface of the plugin (draft could be found in parent ticket) > # Interface to implement by relational nodes. Looks like we have to use > IgniteRel here, but it comes at cost of lost validation: IgniteConvention > uses this interface to validate the convention is set for proper rel. Need to > think about this. > # Interface of the schema. In the prototype the > org.apache.calcite.schema.SchemaPlus is used, but it doesn't look as a good > decision. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (IGNITE-15833) Provide interfaces for SQL Extension API
[ https://issues.apache.org/jira/browse/IGNITE-15833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442594#comment-17442594 ] Alexander Belyak commented on IGNITE-15833: --- [~korlov] Please add licence headers. > Provide interfaces for SQL Extension API > > > Key: IGNITE-15833 > URL: https://issues.apache.org/jira/browse/IGNITE-15833 > Project: Ignite > Issue Type: Sub-task >Reporter: Konstantin Orlov >Assignee: Konstantin Orlov >Priority: Major > Labels: ignite-3 > Time Spent: 10m > Remaining Estimate: 0h > > During this task we need to provide minimal yet sufficient interfaces to make > extension possible. Followed aspects should be covered: > # Interface of the plugin (draft could be found in parent ticket) > # Interface to implement by relational nodes. Looks like we have to use > IgniteRel here, but it comes at cost of lost validation: IgniteConvention > uses this interface to validate the convention is set for proper rel. Need to > think about this. > # Interface of the schema. In the prototype the > org.apache.calcite.schema.SchemaPlus is used, but it doesn't look as a good > decision. -- This message was sent by Atlassian Jira (v8.20.1#820001)
