[jira] [Commented] (IGNITE-1617) CPP: review string usage in public API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952879#comment-14952879
 ] 

ASF GitHub Bot commented on IGNITE-1617:


Github user isapego closed the pull request at:

https://github.com/apache/ignite/pull/133


> CPP: review string usage in public API 
> ---
>
> Key: IGNITE-1617
> URL: https://issues.apache.org/jira/browse/IGNITE-1617
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 1.1.4
>Reporter: Igor Sapego
>Assignee: Vladimir Ozerov
>
> Currently there is std::string type used in some parts of public API while 
> const char* used in some other parts. Need to review API and suggest solution 
> for the consistent string policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-1617) CPP: review string usage in public API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943611#comment-14943611
 ] 

ASF GitHub Bot commented on IGNITE-1617:


GitHub user isapego opened a pull request:

https://github.com/apache/ignite/pull/133

IGNITE-1617: Strings usage adjusted



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/isapego/ignite ignite-1617

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #133


commit cfd3355414b0fe425b8cba5dd032715ae5f6837f
Author: isapego 
Date:   2015-10-02T16:52:26Z

IGNITE-1610: Implemented portable reader and writer for iterators.

commit 61410e8ea4a1dba5c8122ad519d375f085f65bed
Author: isapego 
Date:   2015-10-05T09:35:49Z

Revert "IGNITE-1610: Implemented portable reader and writer for iterators."

This reverts commit cfd3355414b0fe425b8cba5dd032715ae5f6837f.

commit cdf2bb19f076d35f8b25d7a27682bf22412f18a0
Author: isapego 
Date:   2015-10-05T16:17:14Z

IGNITE-1617: Strings usage adjusted




> CPP: review string usage in public API 
> ---
>
> Key: IGNITE-1617
> URL: https://issues.apache.org/jira/browse/IGNITE-1617
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 1.1.4
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>
> Currently there is std::string type used in some parts of public API while 
> const char* used in some other parts. Need to review API and suggest solution 
> for the consistent string policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)