[jira] [Commented] (IGNITE-20232) Java client: Propagate observable timestamp to sql engine using internal API

2023-09-12 Thread Vladislav Pyatkov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-20232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764062#comment-17764062
 ] 

Vladislav Pyatkov commented on IGNITE-20232:


I am sure you will be able to start developing this issue after this one 
(IGNITE-20322) is fixed.

> Java client:  Propagate observable timestamp to sql engine using internal API
> -
>
> Key: IGNITE-20232
> URL: https://issues.apache.org/jira/browse/IGNITE-20232
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Pavel Pereslegin
>Priority: Major
>  Labels: ignite-3
>
> Currently, Java client internally uses a public API to execute sql queries 
> (and some tests also rely on this fact).
> In order to pass the observable timestamp to the sql engine and keep the code 
> clean, we need to switch to using the internal API and rework the related 
> tests.
> This must be done after the completion of IGNITE-19898.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (IGNITE-20232) Java client: Propagate observable timestamp to sql engine using internal API

2023-09-01 Thread Pavel Pereslegin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-20232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761276#comment-17761276
 ] 

Pavel Pereslegin commented on IGNITE-20232:
---

[~ptupitsyn],

> _Which internal API should be used_

QueryProcessor#querySingleAsync (you can find example in 
JdbcQueryEventHandlerImpl).

> _Which related tests should be reworked._

I assume that after switching to the internal API, some client tests that use 
FakeSession/FakeAsyncResultSet will fail.

> _How are TODOs with this ticket number in IgniteTransactionsImpl and 
> IgniteImpl should be addressed_

I think it's better to address this to the author of these TODOs.

[~v.pyatkov], can you help?

> Java client:  Propagate observable timestamp to sql engine using internal API
> -
>
> Key: IGNITE-20232
> URL: https://issues.apache.org/jira/browse/IGNITE-20232
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Pavel Pereslegin
>Assignee: Pavel Tupitsyn
>Priority: Major
>  Labels: ignite-3
>
> Currently, Java client internally uses a public API to execute sql queries 
> (and some tests also rely on this fact).
> In order to pass the observable timestamp to the sql engine and keep the code 
> clean, we need to switch to using the internal API and rework the related 
> tests.
> This must be done after the completion of IGNITE-19898.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (IGNITE-20232) Java client: Propagate observable timestamp to sql engine using internal API

2023-09-01 Thread Pavel Tupitsyn (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-20232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761268#comment-17761268
 ] 

Pavel Tupitsyn commented on IGNITE-20232:
-

>  we need to switch to using the internal API and rework the related tests

[~xtern] please clarify the task:
* Which internal API should be used
* Which related tests should be reworked
* How are TODOs with this ticket number in IgniteTransactionsImpl and 
IgniteImpl should be addressed, and why do we have HybridTimestampTracker on 
the server at all? Client can be connected to multiple servers and it tracks 
timestamp across all connections.

> Java client:  Propagate observable timestamp to sql engine using internal API
> -
>
> Key: IGNITE-20232
> URL: https://issues.apache.org/jira/browse/IGNITE-20232
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Pavel Pereslegin
>Assignee: Pavel Tupitsyn
>Priority: Major
>  Labels: ignite-3
>
> Currently, Java client internally uses a public API to execute sql queries 
> (and some tests also rely on this fact).
> In order to pass the observable timestamp to the sql engine and keep the code 
> clean, we need to switch to using the internal API and rework the related 
> tests.
> This must be done after the completion of IGNITE-19898.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)