[jira] [Commented] (IGNITE-21765) Java thin 3.0: DataStreamer partition awareness might break if assignment is not available at the moment

2024-04-02 Thread Pavel Tupitsyn (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-21765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833129#comment-17833129
 ] 

Pavel Tupitsyn commented on IGNITE-21765:
-

Merged to main: dd75ada680b6a42b022b61f9615667bca156f4ad

> Java thin 3.0: DataStreamer partition awareness might break if assignment is 
> not available at the moment
> 
>
> Key: IGNITE-21765
> URL: https://issues.apache.org/jira/browse/IGNITE-21765
> Project: Ignite
>  Issue Type: Bug
>  Components: streaming, thin client
>Affects Versions: 3.0.0-beta1
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
>  Labels: ignite-3
> Fix For: 3.0.0-beta2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> * *ClientTable.getPartitionAssignment* might return an empty list
> * *AbstractClientStreamerPartitionAwarenessProvider* assumes that partition 
> count can't change
> Therefore, if some server node lags behind and returns an empty assignment 
> for a given timestamp, streamer partition awareness won't work at all.
> *Potential Fixes*
> * Wait for assignment on the server, do not return empty/null - might affect 
> performance
> * Return correct partition count, but null values - faster and simpler



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (IGNITE-21765) Java thin 3.0: DataStreamer partition awareness might break if assignment is not available at the moment

2024-04-02 Thread Igor Sapego (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-21765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833127#comment-17833127
 ] 

Igor Sapego commented on IGNITE-21765:
--

Looks good to me.

> Java thin 3.0: DataStreamer partition awareness might break if assignment is 
> not available at the moment
> 
>
> Key: IGNITE-21765
> URL: https://issues.apache.org/jira/browse/IGNITE-21765
> Project: Ignite
>  Issue Type: Bug
>  Components: streaming, thin client
>Affects Versions: 3.0.0-beta1
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
>  Labels: ignite-3
> Fix For: 3.0.0-beta2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> * *ClientTable.getPartitionAssignment* might return an empty list
> * *AbstractClientStreamerPartitionAwarenessProvider* assumes that partition 
> count can't change
> Therefore, if some server node lags behind and returns an empty assignment 
> for a given timestamp, streamer partition awareness won't work at all.
> *Potential Fixes*
> * Wait for assignment on the server, do not return empty/null - might affect 
> performance
> * Return correct partition count, but null values - faster and simpler



--
This message was sent by Atlassian Jira
(v8.20.10#820010)