[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972315#comment-15972315
 ] 

ASF GitHub Bot commented on IGNITE-2398:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1787


> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972313#comment-15972313
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


Merged to master.

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972308#comment-15972308
 ] 

Vladimir Ozerov commented on IGNITE-2398:
-

I see, LGTM then.

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972305#comment-15972305
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


[~vozerov]
1) Nested type in .NET looks like {{Apache.Ignite.Foo+Bar}}. {{+}} can only be 
to the right of any {{.}}. So yes, this method works correctly. It is covered 
by tests.
2) I have changed the default to full name, see 
{{Marshaller.GetDefaultNameMapper()}}
3) I've added a short circuit for generics. However, this method is not on a 
hot path. It is only called during type registration.

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970982#comment-15970982
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


Removed automatic mappers configuration from 
{{PlatformDotNetConfigurationClosure}}, because now defaults are the same for 
Java and .NET.

This way .NET and Java nodes can join without any config tweaks (IGNITE-3267).

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967469#comment-15967469
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


SQL issue fixed by adding {{+}} character (.NET nested type) handling in Java.
All done, TC looks good. 

[~vozerov] please review.

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967466#comment-15967466
 ] 

ASF GitHub Bot commented on IGNITE-2398:


Github user ptupitsyn closed the pull request at:

https://github.com/apache/ignite/pull/1777


> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967467#comment-15967467
 ] 

ASF GitHub Bot commented on IGNITE-2398:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/1787

IGNITE-2398 .NET: Change default mapper behavior



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-2398

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1787.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1787


commit 25e5a5417263e25f90d198b7afc86255c5bed7f2
Author: Pavel Tupitsyn 
Date:   2017-04-13T11:45:21Z

IGNITE-2398 .NET: Change default mapper behavior




> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965736#comment-15965736
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


All done except SQL:

Table name now depends on current name mapper. We should probably extract table 
name resolver from LINQ and use it for SQL queries when {{Type}} is specified.

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965481#comment-15965481
 ] 

ASF GitHub Bot commented on IGNITE-2398:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/1777

IGNITE-2398 .NET: Change default mapper behavior



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptupitsyn/ignite ignite-2398

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1777


commit 389947517d5a9da82f2957ca6c188abee3ff1950
Author: Pavel Tupitsyn 
Date:   2017-04-06T09:12:28Z

IGNITE-2398 .NET: Change default mapper behavior

commit e8c5eb155b5b3a4ed3438bd07187bffd60da63d2
Author: Pavel Tupitsyn 
Date:   2017-04-07T05:02:22Z

Merge branch 'master' into ignite-2398

commit e3d02ffbd7ed4161208bd7320fc5aa330c795478
Author: Pavel Tupitsyn 
Date:   2017-04-07T05:54:56Z

wip

commit d03b099ad5664cf2fdd7f2fae7cca35ea42ef387
Author: Pavel Tupitsyn 
Date:   2017-04-07T06:10:12Z

Adding tests

commit d16b8e6ef6d1bb84e08a508bfda69c0955b2fcf6
Author: Pavel Tupitsyn 
Date:   2017-04-07T06:12:45Z

wip

commit ff624e11082fbc643ca63571ded2d20424b76bd5
Author: Pavel Tupitsyn 
Date:   2017-04-07T06:22:18Z

wip

commit 1984bfe487e71075ba14475c56d9b8ec11d2f9e0
Author: Pavel Tupitsyn 
Date:   2017-04-07T06:26:32Z

wip

commit 0259adde7701d5139340b27a78f8cf2a35820bca
Author: Pavel Tupitsyn 
Date:   2017-04-07T06:27:42Z

Mapper implemented

commit fdb92dfef0e54dfea405557f957bced17a0cf42c
Author: Pavel Tupitsyn 
Date:   2017-04-07T06:40:54Z

wip

commit dcbabd5e9e2590172acd5447fcf40452724ec98d
Author: Pavel Tupitsyn 
Date:   2017-04-07T06:42:54Z

wip

commit 41e75b7b1a82cc85abbe3d9b30ccb06a6ea5eb33
Author: Pavel Tupitsyn 
Date:   2017-04-07T08:07:59Z

wip

commit f9078a4be71b697146bbfd452eeadcfd6dd54b16
Author: Pavel Tupitsyn 
Date:   2017-04-07T08:27:27Z

wip

commit 62726158cb3ca7092fb9fa20c946f8612b7e50fc
Author: Pavel Tupitsyn 
Date:   2017-04-07T08:44:31Z

wip

commit cf5802362319cd9e2997874107393fd1761221f9
Author: Pavel Tupitsyn 
Date:   2017-04-07T08:57:22Z

wip

commit 48df244e753c998b79b482abeae27b2b4377
Author: Pavel Tupitsyn 
Date:   2017-04-07T09:31:29Z

wip

commit cac10fa6233bd541051c93af0662d52be809ed72
Author: Pavel Tupitsyn 
Date:   2017-04-07T09:45:51Z

wip

commit 1b085dff02469eeb25947ab6064e4fd5108db891
Author: Pavel Tupitsyn 
Date:   2017-04-07T09:49:57Z

wip

commit 283c145ad4251f3fa58d88b0c7b0d7ca3cab0b68
Author: Pavel Tupitsyn 
Date:   2017-04-07T10:26:35Z

wip

commit 93865a970dc60397304ce659ee718f4f13a19936
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:06:37Z

wip

commit 9c053e6d9f7ed25f8784c431a293776649dd8152
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:17:15Z

wip

commit 3c1b38a6979aed4116125a613f058a78dff694dc
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:18:51Z

wip

commit b4f7dd7830207f3fa8b67ccddbe4c4196b1536e5
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:37:36Z

wip

commit 44997da2750d4fea4eabc8777bac3bac0ed354db
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:40:25Z

wip

commit e952c1e3d7a881c9889137970b7cfe1f59b0870e
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:47:18Z

wip type name parser

commit 944e39fb15afee94655666f835723144102283de
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:51:12Z

wip

commit e8df2acde61abd8d853e1ae6b9329736b1f241af
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:56:16Z

wip

commit 5e6ae293e96826131a9dcba2ffa39519df35afd2
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:57:06Z

wip tests

commit d9ec783459b1b87e125ca96c99defad474ff5cb6
Author: Pavel Tupitsyn 
Date:   2017-04-07T11:59:23Z

wip

commit 7c6b6dc6610b5f17fb25e0eba3d20bb45fdb2b84
Author: Pavel Tupitsyn 
Date:   2017-04-07T12:05:59Z

wip

commit 4c8172fba6753749521b58c9c74004ffedde8e7d
Author: Pavel Tupitsyn 
Date:   2017-04-07T12:07:53Z

wip




> .NET: Change default mapper behavior
> 

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965475#comment-15965475
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


Currently we always set Simple mapper in Java when starting .NET nodes. We 
should probably do this only when simple mapper is used in .NET.

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962984#comment-15962984
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


Implementing proper type name parser: we need to be able to remap generics, 
arrays, and any combinations of them properly (throw away namespaces and/or 
assembly names).

For example, {{System.Collections.Generic.List`1[[System.Int32, mscorlib, 
Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], mscorlib, 
Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089}} should 
become {{List`1[[Int32]]}} with simple names and 
{{System.List`1[[System.Int32]]}} with full names.

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960503#comment-15960503
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


Ignite SQL engine always uses simple type names (without namespaces, parent 
classes, etc).

> .NET: Change default mapper behavior
> 
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Minor
>  Labels: .net, important
> Fix For: 2.0
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior.

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210325#comment-15210325
 ] 

Pavel Tupitsyn commented on IGNITE-2398:


Questions:
* Should NameMapper affect metadata? 
* If name mapper appends '_' to all names, what should user pass to 
BinaryObject.GetField()? "X" or "X_"?

> .NET: Change default mapper behavior.
> -
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: platforms
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Critical
>  Labels: important
> Fix For: 1.6
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-2398) .NET: Change default mapper behavior.

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106689#comment-15106689
 ] 

Vladimir Ozerov commented on IGNITE-2398:
-

There is alternate idea on how to resolve the parent issue - add name mapper to 
Java. Lets postpone this task until IGNITE-2191 is ready.

> .NET: Change default mapper behavior.
> -
>
> Key: IGNITE-2398
> URL: https://issues.apache.org/jira/browse/IGNITE-2398
> Project: Ignite
>  Issue Type: Sub-task
>  Components: interop
>Affects Versions: 1.5
>Reporter: Vladimir Ozerov
>Assignee: Pavel Tupitsyn
>Priority: Critical
>  Labels: important
> Fix For: 1.6
>
>
> We need to mirror changes implemented in IGNITE-2191:
> 1) Default mapper must use full class name (i.e. with package)
> 2) Provide additional mapper implementation which will use simple names.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)