[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[ https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683550#comment-15683550 ] Semen Boikov commented on IGNITE-3075: -- Looks good to merge, Thanks! > Implement single key-value pair DHT request/response for ATOMIC cache. > -- > > Key: IGNITE-3075 > URL: https://issues.apache.org/jira/browse/IGNITE-3075 > Project: Ignite > Issue Type: Task > Components: cache >Affects Versions: 1.5.0.final >Reporter: Vladimir Ozerov >Assignee: Konstantin Dudkov > Labels: performance > Fix For: 1.8 > > > Need to implement specialized light-weight version of DHT request/response to > make the most common case - single KV update - more performant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[ https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683486#comment-15683486 ] Konstantin Dudkov commented on IGNITE-3075: --- Semen, all done, please look again. > Implement single key-value pair DHT request/response for ATOMIC cache. > -- > > Key: IGNITE-3075 > URL: https://issues.apache.org/jira/browse/IGNITE-3075 > Project: Ignite > Issue Type: Task > Components: cache >Affects Versions: 1.5.0.final >Reporter: Vladimir Ozerov >Assignee: Konstantin Dudkov > Labels: performance > Fix For: 1.8 > > > Need to implement specialized light-weight version of DHT request/response to > make the most common case - single KV update - more performant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[ https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683334#comment-15683334 ] Semen Boikov commented on IGNITE-3075: -- Hi, Reviewed last version, the last thing to fix: for field 'GridDhtAtomicSingleUpdateRequest.partId' change type Integer -> int, and remove @GridDirectTransient (it should be written/read as part of message in 'writeTo/readFrom'). Thanks! > Implement single key-value pair DHT request/response for ATOMIC cache. > -- > > Key: IGNITE-3075 > URL: https://issues.apache.org/jira/browse/IGNITE-3075 > Project: Ignite > Issue Type: Task > Components: cache >Affects Versions: 1.5.0.final >Reporter: Vladimir Ozerov >Assignee: Konstantin Dudkov > Labels: performance > Fix For: 1.8 > > > Need to implement specialized light-weight version of DHT request/response to > make the most common case - single KV update - more performant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[ https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670360#comment-15670360 ] Konstantin Dudkov commented on IGNITE-3075: --- Semen, Thanks for your comments. * done * I've added hasConflictData() method to GridNearAtomicAbstractUpdateRequest, so now I check request expiry, ctx.expiry and request conflict data in GridDhtAtomicSingleUpdateFuture.canUseSingleRequest. * Expiry Policy suite now runs good, I'll check all other suites. > Implement single key-value pair DHT request/response for ATOMIC cache. > -- > > Key: IGNITE-3075 > URL: https://issues.apache.org/jira/browse/IGNITE-3075 > Project: Ignite > Issue Type: Task > Components: cache >Affects Versions: 1.5.0.final >Reporter: Vladimir Ozerov >Assignee: Konstantin Dudkov > Labels: performance > Fix For: 1.8 > > > Need to implement specialized light-weight version of DHT request/response to > make the most common case - single KV update - more performant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[ https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666464#comment-15666464 ] Konstantin Dudkov commented on IGNITE-3075: --- pr https://github.com/apache/ignite/pull/1233 > Implement single key-value pair DHT request/response for ATOMIC cache. > -- > > Key: IGNITE-3075 > URL: https://issues.apache.org/jira/browse/IGNITE-3075 > Project: Ignite > Issue Type: Task > Components: cache >Affects Versions: 1.5.0.final >Reporter: Vladimir Ozerov >Assignee: Konstantin Dudkov > Labels: performance > Fix For: 1.8 > > > Need to implement specialized light-weight version of DHT request/response to > make the most common case - single KV update - more performant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[ https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643726#comment-15643726 ] Konstantin Dudkov commented on IGNITE-3075: --- Semen, I've done some changes, please take a look. Thanks! > Implement single key-value pair DHT request/response for ATOMIC cache. > -- > > Key: IGNITE-3075 > URL: https://issues.apache.org/jira/browse/IGNITE-3075 > Project: Ignite > Issue Type: Task > Components: cache >Affects Versions: 1.5.0.final >Reporter: Vladimir Ozerov >Assignee: Konstantin Dudkov > Labels: performance > Fix For: 1.8 > > > Need to implement specialized light-weight version of DHT request/response to > make the most common case - single KV update - more performant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[
https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632286#comment-15632286
]
Vladimir Ozerov commented on IGNITE-3075:
-
>From what I remember about my old attempt to refactor that, good approach to
>deal with collection is to replace them with separate size and get-by-index
>methods (as our collections are Lists in this case):
Before:
{code}
Collection keys();
{code}
After:
{code}
int keysCount();
K key(int idx);
{code}
> Implement single key-value pair DHT request/response for ATOMIC cache.
> --
>
> Key: IGNITE-3075
> URL: https://issues.apache.org/jira/browse/IGNITE-3075
> Project: Ignite
> Issue Type: Task
> Components: cache
>Affects Versions: 1.5.0.final
>Reporter: Vladimir Ozerov
>Assignee: Konstantin Dudkov
> Labels: performance
> Fix For: 1.8
>
>
> Need to implement specialized light-weight version of DHT request/response to
> make the most common case - single KV update - more performant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[ https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632259#comment-15632259 ] Semen Boikov commented on IGNITE-3075: -- Hi Konstantin, Here are my comments: - now forceTransformBackups mode is not supported, so GridDhtAtomicSingleUpdateTransformRequest is not needed - GridDhtAtomicSingleUpdateRequest.updateCntrs - there can be only one update counter - GridDhtAtomicSingleUpdateRequest now it have both 'keepBinary' and 'flags' fields, let's keep only 'flags' - in GridDhtAtomicSingleUpdateRequest there can be only 'near' or only 'regular' key/val pair - let's remove ttl, conflict fields from GridDhtAtomicSingleUpdateRequest (use regualr request if there are non-default values for these fields) - GridDhtAtomicSingleUpdateRequest.keys() creates collection, now I see only one call of 'GridDhtAtomicSingleUpdateRequest .keys()', try to get rid of this method Thanks! > Implement single key-value pair DHT request/response for ATOMIC cache. > -- > > Key: IGNITE-3075 > URL: https://issues.apache.org/jira/browse/IGNITE-3075 > Project: Ignite > Issue Type: Task > Components: cache >Affects Versions: 1.5.0.final >Reporter: Vladimir Ozerov >Assignee: Konstantin Dudkov > Labels: performance > Fix For: 1.8 > > > Need to implement specialized light-weight version of DHT request/response to > make the most common case - single KV update - more performant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3075) Implement single key-value pair DHT request/response for ATOMIC cache.
[ https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629353#comment-15629353 ] Konstantin Dudkov commented on IGNITE-3075: --- https://github.com/gridgain/apache-ignite/tree/ignite-3075 will do pr after tests are completed > Implement single key-value pair DHT request/response for ATOMIC cache. > -- > > Key: IGNITE-3075 > URL: https://issues.apache.org/jira/browse/IGNITE-3075 > Project: Ignite > Issue Type: Task > Components: cache >Affects Versions: 1.5.0.final >Reporter: Vladimir Ozerov >Assignee: Konstantin Dudkov > Labels: performance > Fix For: 1.8 > > > Need to implement specialized light-weight version of DHT request/response to > make the most common case - single KV update - more performant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
