[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333482#comment-15333482
 ] 

ASF GitHub Bot commented on IGNITE-3151:


Github user vldpyatkov closed the pull request at:

https://github.com/apache/ignite/pull/796


> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329039#comment-15329039
 ] 

ASF GitHub Bot commented on IGNITE-3151:


GitHub user vldpyatkov opened a pull request:

https://github.com/apache/ignite/pull/796

IGNITE-3151 I rework fixation, so that there was no deadlock.

IGNITE-3151
Using IgniteCountDownLatch sometimes drives to dead lock.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vldpyatkov/ignite ignite-3151

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/796.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #796


commit 9b96febaeaa3e7858827c1d14330dc774723e305
Author: vdpyatkov 
Date:   2016-06-14T07:43:12Z

I rework fixation, so that there was no deadlock.




> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329031#comment-15329031
 ] 

ASF GitHub Bot commented on IGNITE-3151:


Github user vldpyatkov closed the pull request at:

https://github.com/apache/ignite/pull/768


> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[Vladislav Pyatkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324528#comment-15324528
 ] 

Vladislav Pyatkov commented on IGNITE-3151:
---

[~dmagda] I corrected all the comments.

> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324103#comment-15324103
 ] 

Denis Magda commented on IGNITE-3151:
-

[~v.pyatkov] Please see my review notes in the pull-request.

Aslo I would add the same test but when a half of the nodes are client nodes. 
Client nodes receive update notifications a bit later and we must be sure that 
your fix didn't break anything.

> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[Vladislav Pyatkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318671#comment-15318671
 ] 

Vladislav Pyatkov commented on IGNITE-3151:
---

[~dmagda] I update my pull request.
Could you please view it again?

> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[Denis Magda (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313592#comment-15313592
 ] 

Denis Magda commented on IGNITE-3151:
-

Vlad, I've reviewed your changes. Please refer to my notes in the pull-request.

Actually I don't get why this lead to the deadlock, can you explain? Also does 
it make sense to check latches current values in your test?

> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[Vladislav Pyatkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310182#comment-15310182
 ] 

Vladislav Pyatkov commented on IGNITE-3151:
---

Description of change:
I drew attention:
1) {{await}} method creates local *CountDownLatch* and wait it 
({{internalLatch}}).
2) but {{onUpdate}} works without synchronization with initializing of local 
CountDownLatch ({{initializeLatch}}).
Hence {{onUpdate}} may will pass after count of latch will got and before 
return latch from *Callable* closure.

I added wait of creation ({{initLatch}}) of local latch if the process had 
started ({{initGuard}}) already and removed transaction which hold lock on 
count of latch key.

> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[Vladislav Pyatkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307975#comment-15307975
 ] 

Vladislav Pyatkov commented on IGNITE-3151:
---

The issue with deadlock no longer occurs.
Could anyone review?

> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3151) Using IgniteCountDownLatch sometimes drives to dead lock.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307898#comment-15307898
 ] 

ASF GitHub Bot commented on IGNITE-3151:


GitHub user vldpyatkov opened a pull request:

https://github.com/apache/ignite/pull/768

IGNITE-3151

Using IgniteCountDownLatch sometimes drives to dead lock.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vldpyatkov/ignite ignite-3151

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/768.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #768


commit 53bbc1bbd9342e23c8eb57692f5b93dd273e3e03
Author: vdpyatkov 
Date:   2016-05-31T15:12:28Z

IGNITE-3151
Using IgniteCountDownLatch sometimes drives to dead lock.




> Using IgniteCountDownLatch sometimes drives to dead lock.
> -
>
> Key: IGNITE-3151
> URL: https://issues.apache.org/jira/browse/IGNITE-3151
> Project: Ignite
>  Issue Type: Bug
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
> Attachments: igniteBugShot.zip
>
>
> Run several serve node (recoment use count of CPU - 1).
> Wait update topology.
> Run client
> After some iteration exception will thrown (In my case it take place after 
> around 10K iteration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)