[jira] [Commented] (IGNITE-3152) Client node's addresses are registered in IP finder
[
https://issues.apache.org/jira/browse/IGNITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343984#comment-15343984
]
Nikolay Tikhonov commented on IGNITE-3152:
--
{{ClusterNode.isClient()}} returns {{false}} for client node with enabled
{{forceServerMode}} flag. I don't see reason why ip finder shouldn't register
such nodes. Any nodes can join to it (include node with client discovery).
Changes look good for me.
> Client node's addresses are registered in IP finder
> ---
>
> Key: IGNITE-3152
> URL: https://issues.apache.org/jira/browse/IGNITE-3152
> Project: Ignite
> Issue Type: Bug
> Components: general
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Labels: important
> Fix For: 1.7
>
> Attachments: Test.java
>
>
> Currently client node register its addresses in IP finder and never
> deregisters them. Also looks like coordinator address is also not removed.
> The simple test that shows this behavior is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3152) Client node's addresses are registered in IP finder
[
https://issues.apache.org/jira/browse/IGNITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339719#comment-15339719
]
Anton Vinogradov commented on IGNITE-3152:
--
Semantic of {{ClusterNode.isClient()}} is:
{{Tests whether or not this node is connected to cluster as a client.}}
and it's properly used to detect is another node joined to server topology or
not.
{{TcpDiscoveryIpFinderAdapter.discoveryClientMode()}}
Used at joining node. Similar check used at
{{org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi#spiStart}}
So, basicly, {{TcpDiscoveryIpFinderAdapter.discoveryClientMode()}} is a cause
and {{ClusterNode.isClient()}} is an effect.
Seems both method is reqired, and both works correct.
> Client node's addresses are registered in IP finder
> ---
>
> Key: IGNITE-3152
> URL: https://issues.apache.org/jira/browse/IGNITE-3152
> Project: Ignite
> Issue Type: Bug
> Components: general
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Labels: important
> Fix For: 1.7
>
> Attachments: Test.java
>
>
> Currently client node register its addresses in IP finder and never
> deregisters them. Also looks like coordinator address is also not removed.
> The simple test that shows this behavior is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3152) Client node's addresses are registered in IP finder
[
https://issues.apache.org/jira/browse/IGNITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329667#comment-15329667
]
Valentin Kulichenko commented on IGNITE-3152:
-
Yes, you're right, but this means that one the places in the code is incorrect
:) Why we have the {{TcpDiscoveryIpFinderAdapter.discoveryClientMode()}} method
then?
I'm actually not sure that it's correct to return {{false}} from
{{ClusterNode.isClient()}} method in case it's actually a client, but with
forced server mode on discovery level.
Should this be discussed on dev@?
> Client node's addresses are registered in IP finder
> ---
>
> Key: IGNITE-3152
> URL: https://issues.apache.org/jira/browse/IGNITE-3152
> Project: Ignite
> Issue Type: Bug
> Components: general
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Labels: important
> Fix For: 1.7
>
> Attachments: Test.java
>
>
> Currently client node register its addresses in IP finder and never
> deregisters them. Also looks like coordinator address is also not removed.
> The simple test that shows this behavior is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3152) Client node's addresses are registered in IP finder
[ https://issues.apache.org/jira/browse/IGNITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324164#comment-15324164 ] Anton Vinogradov commented on IGNITE-3152: -- I've updated test to ensure it works. > Client node's addresses are registered in IP finder > --- > > Key: IGNITE-3152 > URL: https://issues.apache.org/jira/browse/IGNITE-3152 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 1.5.0.final >Reporter: Valentin Kulichenko >Assignee: Anton Vinogradov > Labels: important > Fix For: 1.7 > > Attachments: Test.java > > > Currently client node register its addresses in IP finder and never > deregisters them. Also looks like coordinator address is also not removed. > The simple test that shows this behavior is attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3152) Client node's addresses are registered in IP finder
[ https://issues.apache.org/jira/browse/IGNITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320858#comment-15320858 ] Anton Vinogradov commented on IGNITE-3152: -- node.isClient() checks that clientRouterNodeId != null Which should means this client node not in forceServerMode, correct? So, !node.isClient() will exclude only client nodes at clietn mode. > Client node's addresses are registered in IP finder > --- > > Key: IGNITE-3152 > URL: https://issues.apache.org/jira/browse/IGNITE-3152 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 1.5.0.final >Reporter: Valentin Kulichenko >Assignee: Anton Vinogradov > Labels: important > Fix For: 1.7 > > Attachments: Test.java > > > Currently client node register its addresses in IP finder and never > deregisters them. Also looks like coordinator address is also not removed. > The simple test that shows this behavior is attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3152) Client node's addresses are registered in IP finder
[
https://issues.apache.org/jira/browse/IGNITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320625#comment-15320625
]
Valentin Kulichenko commented on IGNITE-3152:
-
Anton,
Client node can work in forced server mode. I think we should register
addresses in this case.
See {{TcpDiscoveryIpFinderAdapter.discoveryClientMode()}} and its usages on how
this can be properly checked.
> Client node's addresses are registered in IP finder
> ---
>
> Key: IGNITE-3152
> URL: https://issues.apache.org/jira/browse/IGNITE-3152
> Project: Ignite
> Issue Type: Bug
> Components: general
>Affects Versions: 1.5.0.final
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
> Labels: important
> Fix For: 1.7
>
> Attachments: Test.java
>
>
> Currently client node register its addresses in IP finder and never
> deregisters them. Also looks like coordinator address is also not removed.
> The simple test that shows this behavior is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-3152) Client node's addresses are registered in IP finder
[ https://issues.apache.org/jira/browse/IGNITE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286923#comment-15286923 ] John Levey commented on IGNITE-3152: >From testing it seems the client is connecting to the grid, and then a server >node is registering the client's addresses with Zookeeper - the client itself >was not responsible for the addresses being registered with Zookeeper. Even >after the client disconnects, the addresses are persisted because the server >which registered them is still connected to Zookeeper. > Client node's addresses are registered in IP finder > --- > > Key: IGNITE-3152 > URL: https://issues.apache.org/jira/browse/IGNITE-3152 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 1.5.0.final >Reporter: Valentin Kulichenko > Labels: important > Fix For: 1.7 > > Attachments: Test.java > > > Currently client node register its addresses in IP finder and never > deregisters them. Also looks like coordinator address is also not removed. > The simple test that shows this behavior is attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
