[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968954#comment-15968954
 ] 

Pavel Tupitsyn commented on IGNITE-3548:


Migration guide updated

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968938#comment-15968938
 ] 

ASF GitHub Bot commented on IGNITE-3548:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1694


> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968937#comment-15968937
 ] 

Pavel Tupitsyn commented on IGNITE-3548:


Merged to master

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968709#comment-15968709
 ] 

Pavel Tupitsyn commented on IGNITE-3548:


Renamed to {{ILifecycleHandler}}, injection logic left as is. [~vozerov] please 
have a look.

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967489#comment-15967489
 ] 

Pavel Tupitsyn commented on IGNITE-3548:


What is the plural form? {{LifecycleAwares}}? Not sure about this. May be name 
it {{ILifecycleHandler}} instead?

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964004#comment-15964004
 ] 

Pavel Tupitsyn commented on IGNITE-3548:


[~vozerov] Ok, I agree.

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964000#comment-15964000
 ] 

Vladimir Ozerov commented on IGNITE-3548:
-

[~ptupitsyn], I propose to name it {{ILifecycleAware}} and leave injection 
logic as is.

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962980#comment-15962980
 ] 

Pavel Tupitsyn commented on IGNITE-3548:


[~vozerov] {{LifecycleBean}} is not acceptable either. It just does not make 
sense for a non-Java people.
Semantically this is an event handler. You are right, naming is questionable 
(there is even an inspection that I had to suppress), we should come up with 
something else probably.

As for resource injection, I think it has a lot of problems where we use it. It 
is not intuitive, too verbose, triggers all sorts of compiler warnings 
(uninitialized variable, etc). Explicit parameter injection is much easier to 
use. For closures resource injection makes more sense due to serialization, but 
here we don't serialize anything.

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962955#comment-15962955
 ] 

Vladimir Ozerov commented on IGNITE-3548:
-

[~ptupitsyn],
This is very questionable change, I would close the ticket as "Won't Fix" 
instead. The main problem is that we named something as "EventHandler", but 
this is not real {{EventHandler}} delegate as .NET users might expect. 
Changes to method signature is not obvious either. Lifecycle beans are stateful 
instances. As such, resource injection appears to be more reasonable to me than 
passing values through method call.

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948550#comment-15948550
 ] 

Pavel Tupitsyn commented on IGNITE-3548:


* Renamed {{ILifecycleBean}} to {{ILifecycleEventHandler}}.
* Replaced resource injection with method argument. I think in this particular 
case it makes more sense.

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948548#comment-15948548
 ] 

ASF GitHub Bot commented on IGNITE-3548:


GitHub user ptupitsyn opened a pull request:

https://github.com/apache/ignite/pull/1694

IGNITE-3548 .NET: Rename ILifecycleBean



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-3548

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1694


commit 9947616230576233b8308351cdd8b4796a813ae6
Author: Pavel Tupitsyn 
Date:   2017-03-30T07:19:58Z

IGNITE-3548 .NET: Rename ILifecycleBean




> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-3548) .NET: Rename ILifecycleBean

[Pavel Tupitsyn (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946968#comment-15946968
 ] 

Pavel Tupitsyn commented on IGNITE-3548:


Event handlers and delegates can't be used, because these can't be configured 
in XML. We should keep the interface, just give it a different name.

Event handlers are already present in {{IIgnite}}, they probably fulfill most 
use cases.

> .NET: Rename ILifecycleBean
> ---
>
> Key: IGNITE-3548
> URL: https://issues.apache.org/jira/browse/IGNITE-3548
> Project: Ignite
>  Issue Type: Improvement
>  Components: platforms
>Reporter: Pavel Tupitsyn
>  Labels: .net, breaking-api
> Fix For: 2.0
>
>
> Bean is a Java term. 
> Either rename this interface to something like ILifecycle, or rework the 
> lifecycle notifications to C# event handlers.
> 2.0 migration guide has to be updated if needed: 
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)