[jira] [Commented] (IGNITE-3587) ODBC: Add Distributed Joins support to ODBC.

2016-08-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409078#comment-15409078
 ] 

ASF GitHub Bot commented on IGNITE-3587:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/908


> ODBC: Add Distributed Joins support to ODBC.
> 
>
> Key: IGNITE-3587
> URL: https://issues.apache.org/jira/browse/IGNITE-3587
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Vladimir Ozerov
>  Labels: odbc
> Fix For: 1.8
>
>
> Need to add support for the distributed joins to ODBC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (IGNITE-3587) ODBC: Add Distributed Joins support to ODBC.

2016-07-29 Thread Igor Sapego (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399522#comment-15399522
 ] 

Igor Sapego commented on IGNITE-3587:
-

Ok, then lets discuss variants. My proposal is to specify protocol version in 
the following format {{VERSION_X_Y}}, where {{X}} and {{Y}} is the major and 
minor versions of the Ignite since which it's introduced.

For example:
{{PROTOCOL_VERSION=VERSION_1_6}}
{{PROTOCOL_VERSION=VERSION_1_7}}
{{PROTOCOL_VERSION=VERSION_2_0}}
{{PROTOCOL_VERSION=VERSION_2_3}}

These values in their turn are mapped to simple sequential long values 1, 2, 
3... and so on.
What do you think?

> ODBC: Add Distributed Joins support to ODBC.
> 
>
> Key: IGNITE-3587
> URL: https://issues.apache.org/jira/browse/IGNITE-3587
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: odbc
> Fix For: 1.7
>
>
> Need to add support for the distributed joins to ODBC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (IGNITE-3587) ODBC: Add Distributed Joins support to ODBC.

2016-07-29 Thread Igor Sapego (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399033#comment-15399033
 ] 

Igor Sapego commented on IGNITE-3587:
-

Vladimir, there is no connect request. There is handshake request. It is more 
convenient when handshake request does not contain anything except for the 
protocol version, because otherwise we would not know how to deserialize it. In 
current approach we first deserialize it and then handle it checking if the 
version is supported. If the would be additional information we would need to 
deserialize few first fields, then handle them and then deserialize the 
remaining fields if needed. To me it seems a bit dirty so I decided to split 
connection procedure in two steps - first one is handshake and second one is 
configure request. This way we always know how to deserialize configure request 
if handshake is accepted.

> ODBC: Add Distributed Joins support to ODBC.
> 
>
> Key: IGNITE-3587
> URL: https://issues.apache.org/jira/browse/IGNITE-3587
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: odbc
> Fix For: 1.7
>
>
> Need to add support for the distributed joins to ODBC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (IGNITE-3587) ODBC: Add Distributed Joins support to ODBC.

2016-07-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397709#comment-15397709
 ] 

ASF GitHub Bot commented on IGNITE-3587:


GitHub user isapego opened a pull request:

https://github.com/apache/ignite/pull/908

IGNITE-3587: Added Distributed Joins support to ODBC.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/isapego/ignite ignite-3587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/908.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #908


commit 87a6c65364309042b0db6b2da68c05e80f0ac28e
Author: isapego 
Date:   2016-07-25T15:00:35Z

IGNITE-3577: Refactored odbc::Configuration class.

commit 0bc980537bb132c1d722b8abe4f35db7891401e9
Author: isapego 
Date:   2016-07-25T18:33:41Z

IGNITE-3577: Replaced host and port with address.

commit fbc0480366201d1f7d42b95b6462e37e49f739ac
Author: isapego 
Date:   2016-07-26T11:51:54Z

IGNITE-3577: Added tests.

commit 930b5cec0ba78b91052d3ace1b2c3d6546c1e779
Author: isapego 
Date:   2016-07-26T12:05:40Z

IGNITE-3577: Minor tests refactoring.

commit ef77f41b5c0722a91c10a350f9edbe933e2fe768
Author: isapego 
Date:   2016-07-26T13:03:09Z

IGNITE-3577: Added errors handling.

commit 9fffae874c9d296c5722541f44668015e1b0ac18
Author: isapego 
Date:   2016-07-26T13:44:33Z

IGNITE-3577: Refactored tests to be able to change connection string.

commit b2b6feded67d89d89d9201e6a748d5c6d6f6bb35
Author: isapego 
Date:   2016-07-26T14:23:17Z

IGNITE-3577: Returned support for SERVER and PORT args.

commit c441e415f1be7fa1db7a4f5997507deeff7316d7
Author: Igor Sapego 
Date:   2016-07-26T14:56:13Z

IGNITE-3577: Fix for Linux.

commit 554778afe8d534dbfc73c57b9f5018db2545ccb3
Author: isapego 
Date:   2016-07-27T10:43:03Z

IGNITE-3587: Added DISTRIBUTED_JOINS and ENFORCE_JOIN_ORDER attributes.

commit 901a6b5d57374d957f219c4c7826fbccdffd0a89
Author: isapego 
Date:   2016-07-27T15:24:51Z

IGNITE-3577: Replaces std::all_of with own implementation.

commit f83efb1140a3274b84592b0d44932702c9259826
Author: isapego 
Date:   2016-07-27T15:35:45Z

IGNITE-3577: More checks in TestConnectStringValidAddress.

commit 2b2f58380febe11e556b99f23a4d767a79523ae5
Author: isapego 
Date:   2016-07-28T08:57:14Z

IGNITE-3577: Removed unneccessary dependencies.

commit 464cab1987cac467827c37fd07379878b391fc56
Author: isapego 
Date:   2016-07-28T09:08:55Z

Merge branch 'ignite-3577' into ignite-3587

commit e62f7ae4a5edc444530e9688ebdfb1afdad07081
Author: isapego 
Date:   2016-07-28T09:14:23Z

IGNITE-3587: Merge-related fixes.

commit b67e7e845c4c60b4747b74a482e3f46603998a3e
Author: isapego 
Date:   2016-07-28T09:59:35Z

IGNITE-3587: Implemented distributed joins on C++ side

commit ebce2766b40ca07edeca8a66907113643963358d
Author: isapego 
Date:   2016-07-28T10:43:59Z

IGNITE-3587: Added configure message.

commit 762180315aa37bb98eddb4045245631483c78498
Author: isapego 
Date:   2016-07-28T11:20:25Z

IGNITE-3587: Added java-side implementation.

commit af823ca85604041671efe2defa057f058806ac62
Author: isapego 
Date:   2016-07-28T14:58:22Z

IGNITE-3587: Added test for distribution joins.

commit 6eb3d2856bd45a862a2b5131cdd704633c680ac2
Author: isapego 
Date:   2016-07-28T15:38:12Z

IGNITE-3587: Added configuration tests.

commit d9a7e6f6ebb89640b88ad47fe8bea89e4bc1950a
Author: isapego 
Date:   2016-07-28T15:41:22Z

IGNITE-3587: Minor test fix.




> ODBC: Add Distributed Joins support to ODBC.
> 
>
> Key: IGNITE-3587
> URL: https://issues.apache.org/jira/browse/IGNITE-3587
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: odbc
> Fix For: 1.7
>
>
> Need to add support for the distributed joins to ODBC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (IGNITE-3587) ODBC: Add Distributed Joins support to ODBC.

2016-07-26 Thread Igor Sapego (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394110#comment-15394110
 ] 

Igor Sapego commented on IGNITE-3587:
-

I'm going to add two new connection string arguments:
- {{DISTRIBUTED_JOINS={true,false}}} 
- {{ENFORCE_JOIN_ORDER={true,false}}}

These parameters are going to be passed to server after connection and saved 
for further usage on query execution. This can require to change ODBC protocol 
version.

> ODBC: Add Distributed Joins support to ODBC.
> 
>
> Key: IGNITE-3587
> URL: https://issues.apache.org/jira/browse/IGNITE-3587
> Project: Ignite
>  Issue Type: Task
>  Components: odbc
>Affects Versions: 1.6
>Reporter: Igor Sapego
>Assignee: Igor Sapego
>  Labels: odbc
> Fix For: 2.0
>
>
> Need to add support for the distributed joins to ODBC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)