[jira] [Commented] (IGNITE-3807) IgniteSpiContext registers message listeners incorrectly

[Saikat Maitra (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526351#comment-15526351
 ] 

Saikat Maitra commented on IGNITE-3807:
---

[~vkulichenko]

Thank you Valentin.

Regards
Saikat

> IgniteSpiContext registers message listeners incorrectly
> 
>
> Key: IGNITE-3807
> URL: https://issues.apache.org/jira/browse/IGNITE-3807
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
> Fix For: 1.8
>
>
> {{IgniteSpiContext}} implementation provided by {{GridManagerAdapter}} uses 
> {{ctx.io().addMessageListener(..)}} method to register message listeners. 
> This is incorrect, because this creates a listener for internal Ignite 
> messages, not for user messages. Thus, when user tries to send a message on 
> this topic, the listener is not invoked. To fix this, 
> {{ctx.io().addUserMessageListener(..)}} method should be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3807) IgniteSpiContext registers message listeners incorrectly

[Saikat Maitra (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517407#comment-15517407
 ] 

Saikat Maitra commented on IGNITE-3807:
---

[~vkulichenko]

Hi Valentin,

I have updated the changes required. Please review the PR and share your 
feedback.

Regards
Saikat

> IgniteSpiContext registers message listeners incorrectly
> 
>
> Key: IGNITE-3807
> URL: https://issues.apache.org/jira/browse/IGNITE-3807
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
> Fix For: 1.8
>
>
> {{IgniteSpiContext}} implementation provided by {{GridManagerAdapter}} uses 
> {{ctx.io().addMessageListener(..)}} method to register message listeners. 
> This is incorrect, because this creates a listener for internal Ignite 
> messages, not for user messages. Thus, when user tries to send a message on 
> this topic, the listener is not invoked. To fix this, 
> {{ctx.io().addUserMessageListener(..)}} method should be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3807) IgniteSpiContext registers message listeners incorrectly

[Saikat Maitra (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515217#comment-15515217
 ] 

Saikat Maitra commented on IGNITE-3807:
---

[~vkulichenko]

Hi Valentin,

I will complete the changes tomorrow and share an update.

regards
Saikat

> IgniteSpiContext registers message listeners incorrectly
> 
>
> Key: IGNITE-3807
> URL: https://issues.apache.org/jira/browse/IGNITE-3807
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
> Fix For: 1.8
>
>
> {{IgniteSpiContext}} implementation provided by {{GridManagerAdapter}} uses 
> {{ctx.io().addMessageListener(..)}} method to register message listeners. 
> This is incorrect, because this creates a listener for internal Ignite 
> messages, not for user messages. Thus, when user tries to send a message on 
> this topic, the listener is not invoked. To fix this, 
> {{ctx.io().addUserMessageListener(..)}} method should be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3807) IgniteSpiContext registers message listeners incorrectly

[Valentin Kulichenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513909#comment-15513909
 ] 

Valentin Kulichenko commented on IGNITE-3807:
-

Hi [~samaitra],

When will you have a chance to finish these changes?

> IgniteSpiContext registers message listeners incorrectly
> 
>
> Key: IGNITE-3807
> URL: https://issues.apache.org/jira/browse/IGNITE-3807
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
> Fix For: 1.8
>
>
> {{IgniteSpiContext}} implementation provided by {{GridManagerAdapter}} uses 
> {{ctx.io().addMessageListener(..)}} method to register message listeners. 
> This is incorrect, because this creates a listener for internal Ignite 
> messages, not for user messages. Thus, when user tries to send a message on 
> this topic, the listener is not invoked. To fix this, 
> {{ctx.io().addUserMessageListener(..)}} method should be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3807) IgniteSpiContext registers message listeners incorrectly

[Saikat Maitra (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488060#comment-15488060
 ] 

Saikat Maitra commented on IGNITE-3807:
---

[~vkulichenko]

Hi Valentin,

Thank you for reviewing the PR. I will update the PR as per review feedback.

Regards
Saikat

> IgniteSpiContext registers message listeners incorrectly
> 
>
> Key: IGNITE-3807
> URL: https://issues.apache.org/jira/browse/IGNITE-3807
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
> Fix For: 1.8
>
>
> {{IgniteSpiContext}} implementation provided by {{GridManagerAdapter}} uses 
> {{ctx.io().addMessageListener(..)}} method to register message listeners. 
> This is incorrect, because this creates a listener for internal Ignite 
> messages, not for user messages. Thus, when user tries to send a message on 
> this topic, the listener is not invoked. To fix this, 
> {{ctx.io().addUserMessageListener(..)}} method should be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3807) IgniteSpiContext registers message listeners incorrectly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465755#comment-15465755
 ] 

ASF GitHub Bot commented on IGNITE-3807:


GitHub user samaitra opened a pull request:

https://github.com/apache/ignite/pull/1036

IGNITE-3807 IgniteSpiContext registers message listeners incorrectly



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/samaitra/ignite IGNITE-3807

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1036.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1036


commit a3e87e8765d52223f1296cb83e2ec39d32b197db
Author: samaitra 
Date:   2016-09-05T20:41:37Z

IGNITE-3807 IgniteSpiContext registers message listeners incorrectly




> IgniteSpiContext registers message listeners incorrectly
> 
>
> Key: IGNITE-3807
> URL: https://issues.apache.org/jira/browse/IGNITE-3807
> Project: Ignite
>  Issue Type: Bug
>  Components: general
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Saikat Maitra
> Fix For: 1.8
>
>
> {{IgniteSpiContext}} implementation provided by {{GridManagerAdapter}} uses 
> {{ctx.io().addMessageListener(..)}} method to register message listeners. 
> This is incorrect, because this creates a listener for internal Ignite 
> messages, not for user messages. Thus, when user tries to send a message on 
> this topic, the listener is not invoked. To fix this, 
> {{ctx.io().addUserMessageListener(..)}} method should be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)