[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020380#comment-16020380 ] Prachi Garg commented on IGNITE-4052: - [~ntikhonov] I have merged the changes and also made some edits. Within the Json code block, the following was mentioned twice. "MESOS_USER" : "userA", "MESOS_ROLE" : "role1" I have removed one occurrence. Please review and confirm that it was the right action. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Prachi Garg >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011240#comment-16011240 ] Denis Magda commented on IGNITE-4052: - [~pgarg], please review and apply the edits suggested by Vadim in readme.io for Mesos Deployment page: https://dash.readme.io/project/apacheignite/v2.0/suggested > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Prachi Garg >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008573#comment-16008573 ] Denis Magda commented on IGNITE-4052: - [~javaller], the issue was fixed. Please go ahead and suggest the changes in readme.io. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007265#comment-16007265 ] Denis Magda commented on IGNITE-4052: - I'm trying to figure out what happened. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006872#comment-16006872 ] Nikolay Tikhonov commented on IGNITE-4052: -- I've logout from there and have the same problem too. I'll to ask from theirs support. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006629#comment-16006629 ] Nikolay Tikhonov commented on IGNITE-4052: -- [~javaller] Which kind of issue do you have? Could you share some screenshot? > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[
https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986959#comment-15986959
]
Nikolay Tikhonov commented on IGNITE-4052:
--
[~javaller],
Thank you for your contribution. I've fixed some minors issue and pushed your
changes into {{ignite-4052}} branch. Please look at the changes.
>I dont work with Mesos and think that anyone who has experience should make
>it. OK?
I think that it good time to try it. ;) It looks strange when developer don't
run own code. [2] Also would be great to update docs [1]. Use for it {{suggest
edits}} button.
1. https://apacheignite.readme.io/docs/mesos-deployment
2. http://mesos.apache.org/gettingstarted/
> Add ability to set up users for MESOS
> -
>
> Key: IGNITE-4052
> URL: https://issues.apache.org/jira/browse/IGNITE-4052
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.7
>Reporter: Nikolay Tikhonov
>Assignee: Vadim Opolski
>Priority: Trivial
>
> In current implementation Ignite Mesos Framework connects to MESOS cluster
> via current user. Need to add ability to configure this parameters via system
> env properties. Also need to add properties for mesos role.
> See org/apache/ignite/mesos/IgniteFramework.java:537
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974725#comment-15974725 ] Nikolay Tikhonov commented on IGNITE-4052: -- [~javaller] I've looked at changes and have minor comments: * code style (extra space, if esle blocks, javadoc and etc. https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute); * let's split #testIgniteFramework() test: one which will testing new parametes and other which will testing role validation; * let's to use PowerMock in test (distributed under apache 2.0 licence which acceptable for our product) and rid #setEnv method; And again, did you test this parameters on real mesos cluster? Thank you for your contribution. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972274#comment-15972274 ] Vadim Opolski commented on IGNITE-4052: --- The following improvements was maken: 1) Moved framework builder related code to separate method, so it make code cleaner and framework testable. 2) Call framework builder method from test to test role and user. 3) Added validating mesos role according with mesos role documentation http://mesos.apache.org/documentation/latest/roles/ 4) Still using setEnv method because in IgniteFramework we cannot override static method and make mock static methods (except powermock, but it would require 3 extra dependencies in the module). P.S. setEnv method designed to worked both on Linux and Windows, and it does not left variable in system environment after testing. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[
https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968814#comment-15968814
]
Nikolay Tikhonov commented on IGNITE-4052:
--
[~javaller]
It meens that lets remove #setEnv mathod and will create mock in test which
will override {{getUser}} and {{getRole}} methods. Also how do you think might
be need to add validation for role? Which valid set of values for this property?
> Add ability to set up users for MESOS
> -
>
> Key: IGNITE-4052
> URL: https://issues.apache.org/jira/browse/IGNITE-4052
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.7
>Reporter: Nikolay Tikhonov
>Assignee: Vadim Opolski
>Priority: Trivial
>
> In current implementation Ignite Mesos Framework connects to MESOS cluster
> via current user. Need to add ability to configure this parameters via system
> env properties. Also need to add properties for mesos role.
> See org/apache/ignite/mesos/IgniteFramework.java:537
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[
https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967591#comment-15967591
]
Nikolay Tikhonov commented on IGNITE-4052:
--
[~javaller]
Let's just in test override {{getUser}} and {{getRole}} methods. It should be
enough for this feature.
Also did you test this locally? It's really works? We need to understand which
exception user will get if user name and/or role incorrect.
> Add ability to set up users for MESOS
> -
>
> Key: IGNITE-4052
> URL: https://issues.apache.org/jira/browse/IGNITE-4052
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.7
>Reporter: Nikolay Tikhonov
>Assignee: Vadim Opolski
>Priority: Trivial
>
> In current implementation Ignite Mesos Framework connects to MESOS cluster
> via current user. Need to add ability to configure this parameters via system
> env properties. Also need to add properties for mesos role.
> See org/apache/ignite/mesos/IgniteFramework.java:537
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966414#comment-15966414 ] Vadim Opolski commented on IGNITE-4052: --- https://github.com/apache/ignite/pull/1783 > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953167#comment-15953167 ] Nikolay Tikhonov commented on IGNITE-4052: -- [~javaller], For example you can look at cassandra mesos integration https://github.com/mesosphere/dcos-cassandra-service/blob/5d6d15e646f1df2fa10fa98d91993d3a6b4719c4/cassandra-commons/src/main/java/com/mesosphere/dcos/cassandra/common/config/ServiceConfig.java. List of application which use Mesos not secret and can be found on official mesos site http://mesos.apache.org/documentation/latest/frameworks. ;) I'm really don't understand how the libs can help you. Could you clarify it? > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951312#comment-15951312 ] Denis Magda commented on IGNITE-4052: - Folks, Please don’t forget to update Mesos doc once this contribution gets merged: https://apacheignite.readme.io/docs/mesos-deployment Assign the ticket on [~pgarg] to review documentation changes. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947017#comment-15947017 ] Nikolay Tikhonov commented on IGNITE-4052: -- Also did you try to use new properties on real mesos cluster? Did work properly? > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947014#comment-15947014 ] Nikolay Tikhonov commented on IGNITE-4052: -- [~javaller] You used only Protos.FrameworkInfo.Builder#setRole method, but also exists Protos.FrameworkInfo.Builder#setRoleBytes. Please, pay attention on it. You did some code styles changes which conflict with official "Coding Guidelines" (see https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute). Also you use lib for testing with licence different from Apache Licence 2.0. Are you sure that for this test you need additional libs? I think this can be implemented without them. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946667#comment-15946667 ] Vadim Opolski commented on IGNITE-4052: --- https://github.com/apache/ignite/pull/1662 > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[
https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938366#comment-15938366
]
Nikolay Tikhonov commented on IGNITE-4052:
--
[~javaller]
Thank you for your contribution! I've seen that you done first part of the
issue. Please pay your attention on {{mesos role}}. Also how did you tested the
changes? Do you have any ideas how it can be checked by unit test?
> Add ability to set up users for MESOS
> -
>
> Key: IGNITE-4052
> URL: https://issues.apache.org/jira/browse/IGNITE-4052
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 1.7
>Reporter: Nikolay Tikhonov
>Assignee: Vadim Opolski
>Priority: Trivial
>
> In current implementation Ignite Mesos Framework connects to MESOS cluster
> via current user. Need to add ability to configure this parameters via system
> env properties. Also need to add properties for mesos role.
> See org/apache/ignite/mesos/IgniteFramework.java:537
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS
[ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936205#comment-15936205 ] ASF GitHub Bot commented on IGNITE-4052: GitHub user vadopolski opened a pull request: https://github.com/apache/ignite/pull/1662 IGNITE-4052 Protos.FrameworkInfoSetup.SetUser added getting MESOS_USER option. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vadopolski/ignite IGNITE-4052 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1662.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1662 commit f137d15a21b5432b9886899dfaa90c8ba47ca604 Author: vopolski <2w3e4r5t> Date: 2017-03-22T12:16:38Z IGNITE-4052 Protos.FrameworkInfoSetup.SetUser added getting MESOS_USER option. > Add ability to set up users for MESOS > - > > Key: IGNITE-4052 > URL: https://issues.apache.org/jira/browse/IGNITE-4052 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.7 >Reporter: Nikolay Tikhonov >Assignee: Vadim Opolski >Priority: Trivial > > In current implementation Ignite Mesos Framework connects to MESOS cluster > via current user. Need to add ability to configure this parameters via system > env properties. Also need to add properties for mesos role. > See org/apache/ignite/mesos/IgniteFramework.java:537 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
