[jira] [Commented] (IGNITE-4063) BinaryType.fieldNames() should return names in consistent order

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770260#comment-15770260
 ] 

ASF GitHub Bot commented on IGNITE-4063:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/1270


> BinaryType.fieldNames() should return names in consistent order
> ---
>
> Key: IGNITE-4063
> URL: https://issues.apache.org/jira/browse/IGNITE-4063
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Taras Ledkov
>Priority: Critical
> Fix For: 2.0
>
>
> In some cases it can be useful to get the field names from metadata in the 
> order fields were written when the metadata was created (i.e. object was 
> serialized for the first time). For example, this can be used to recreate the 
> object using builder preserving the consistent field ordering, so that 
> {{BinaryObject.equals()}} method works properly.
> Basically, we just need to replace {{HashMap}} with {{LinkedHashMap}} in the 
> {{BinaryType}} implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-4063) BinaryType.fieldNames() should return names in consistent order

[Taras Ledkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690383#comment-15690383
 ] 

Taras Ledkov commented on IGNITE-4063:
--

[Pull request|https://github.com/apache/ignite/pull/1270]
[Tests 
results|http://195.239.208.174/project.html?projectId=IgniteTests=projectOverview_IgniteTests=pull%2F1270%2Fhead]

> BinaryType.fieldNames() should return names in consistent order
> ---
>
> Key: IGNITE-4063
> URL: https://issues.apache.org/jira/browse/IGNITE-4063
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Taras Ledkov
>Priority: Critical
> Fix For: 1.9
>
>
> In some cases it can be useful to get the field names from metadata in the 
> order fields were written when the metadata was created (i.e. object was 
> serialized for the first time). For example, this can be used to recreate the 
> object using builder preserving the consistent field ordering, so that 
> {{BinaryObject.equals()}} method works properly.
> Basically, we just need to replace {{HashMap}} with {{LinkedHashMap}} in the 
> {{BinaryType}} implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-4063) BinaryType.fieldNames() should return names in consistent order

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690377#comment-15690377
 ] 

ASF GitHub Bot commented on IGNITE-4063:


GitHub user tledkov-gridgain opened a pull request:

https://github.com/apache/ignite/pull/1270

IGNITE-4063 BinaryType.fieldNames() should return names in consistent order



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-4063

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1270


commit b038730ee56a662f73e02bbec83eb1712180fa82
Author: isapego 
Date:   2016-11-23T09:05:54Z

IGNITE-4249: ODBC: Fixed performance issue caused by ineddicient IO 
handling on CPP side. This closes #1254.

commit 394d562125519193436026af30b93a9588ba08ba
Author: tledkov-gridgain 
Date:   2016-11-23T15:10:18Z

IGNITE-4063:  keep order of fields in the metadata according with schema




> BinaryType.fieldNames() should return names in consistent order
> ---
>
> Key: IGNITE-4063
> URL: https://issues.apache.org/jira/browse/IGNITE-4063
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Taras Ledkov
>Priority: Critical
> Fix For: 1.9
>
>
> In some cases it can be useful to get the field names from metadata in the 
> order fields were written when the metadata was created (i.e. object was 
> serialized for the first time). For example, this can be used to recreate the 
> object using builder preserving the consistent field ordering, so that 
> {{BinaryObject.equals()}} method works properly.
> Basically, we just need to replace {{HashMap}} with {{LinkedHashMap}} in the 
> {{BinaryType}} implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)