[jira] [Commented] (IGNITE-4763) doSetRollbackOnly method to be implemented in SpringTransactionManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276443#comment-16276443
 ] 

ASF GitHub Bot commented on IGNITE-4763:


Github user NSAmelchev closed the pull request at:

https://github.com/apache/ignite/pull/1884


> doSetRollbackOnly method to be implemented in SpringTransactionManager
> --
>
> Key: IGNITE-4763
> URL: https://issues.apache.org/jira/browse/IGNITE-4763
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 1.8
>Reporter: Sumanta Ghosh
>Assignee: Amelchev Nikita
>  Labels: newbie, patch
> Fix For: 2.1
>
>
> This issue is raised in continuation with the message posted in ignite user 
> forum 
> (http://apache-ignite-users.70518.x6.nabble.com/SpringTransactionManager-Participating-in-existing-transactions-is-not-supported-td7305.html#a10624).
>  Since the doSetRollBackOnly method is not implemented in 
> SpringTransactionManager, it is not being possible to integrate with spring 
> data's ChainedTransactionManager class. A simple fix (below) would work it 
> seems (however, I did not yet tested with proper rollback test cases though, 
> this implementation at least get rid of the exception chainedtransaction 
> manager raises)
> @Override 
> protected void doSetRollbackOnly(DefaultTransactionStatus status) 
> throws TransactionException { 
> Transaction txn = 
> ((Ignite)this.getResourceFactory()).transactions().tx(); 
> if (txn!=null) txn.setRollbackOnly(); 
> }
> NOTE: This is the first time I am raising issues in apache. So, apologies if 
> all the details are not proper.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-4763) doSetRollbackOnly method to be implemented in SpringTransactionManager

[Andrey Gura (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019574#comment-16019574
 ] 

Andrey Gura commented on IGNITE-4763:
-

Nikita,

your changes are merged into master branch. Thanks a lot!

> doSetRollbackOnly method to be implemented in SpringTransactionManager
> --
>
> Key: IGNITE-4763
> URL: https://issues.apache.org/jira/browse/IGNITE-4763
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 1.8
>Reporter: Sumanta Ghosh
>Assignee: Amelchev Nikita
>  Labels: newbie, patch
> Fix For: 2.1
>
>
> This issue is raised in continuation with the message posted in ignite user 
> forum 
> (http://apache-ignite-users.70518.x6.nabble.com/SpringTransactionManager-Participating-in-existing-transactions-is-not-supported-td7305.html#a10624).
>  Since the doSetRollBackOnly method is not implemented in 
> SpringTransactionManager, it is not being possible to integrate with spring 
> data's ChainedTransactionManager class. A simple fix (below) would work it 
> seems (however, I did not yet tested with proper rollback test cases though, 
> this implementation at least get rid of the exception chainedtransaction 
> manager raises)
> @Override 
> protected void doSetRollbackOnly(DefaultTransactionStatus status) 
> throws TransactionException { 
> Transaction txn = 
> ((Ignite)this.getResourceFactory()).transactions().tx(); 
> if (txn!=null) txn.setRollbackOnly(); 
> }
> NOTE: This is the first time I am raising issues in apache. So, apologies if 
> all the details are not proper.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4763) doSetRollbackOnly method to be implemented in SpringTransactionManager

[Amelchev Nikita (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019280#comment-16019280
 ] 

Amelchev Nikita commented on IGNITE-4763:
-

Hi, Andrey.

I do it because _getTransaction()_ can return null. I agree with you and leave 
assert. 

Please, review.

> doSetRollbackOnly method to be implemented in SpringTransactionManager
> --
>
> Key: IGNITE-4763
> URL: https://issues.apache.org/jira/browse/IGNITE-4763
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 1.8
>Reporter: Sumanta Ghosh
>Assignee: Amelchev Nikita
>  Labels: newbie, patch
> Fix For: 2.1
>
>
> This issue is raised in continuation with the message posted in ignite user 
> forum 
> (http://apache-ignite-users.70518.x6.nabble.com/SpringTransactionManager-Participating-in-existing-transactions-is-not-supported-td7305.html#a10624).
>  Since the doSetRollBackOnly method is not implemented in 
> SpringTransactionManager, it is not being possible to integrate with spring 
> data's ChainedTransactionManager class. A simple fix (below) would work it 
> seems (however, I did not yet tested with proper rollback test cases though, 
> this implementation at least get rid of the exception chainedtransaction 
> manager raises)
> @Override 
> protected void doSetRollbackOnly(DefaultTransactionStatus status) 
> throws TransactionException { 
> Transaction txn = 
> ((Ignite)this.getResourceFactory()).transactions().tx(); 
> if (txn!=null) txn.setRollbackOnly(); 
> }
> NOTE: This is the first time I am raising issues in apache. So, apologies if 
> all the details are not proper.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4763) doSetRollbackOnly method to be implemented in SpringTransactionManager

[Andrey Gura (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012587#comment-16012587
 ] 

Andrey Gura commented on IGNITE-4763:
-

Hi, Nikita,

First of all thank you for contribution!

I've looked at your PR and have only one comment. Why do you check reference to 
the tx on {{null}} value? It seems that transaction should always be 
non-{{null}}. Otherwise is implementation error. May be it would be better just 
assert that {{tx}} doesn't equal {{null}}?

> doSetRollbackOnly method to be implemented in SpringTransactionManager
> --
>
> Key: IGNITE-4763
> URL: https://issues.apache.org/jira/browse/IGNITE-4763
> Project: Ignite
>  Issue Type: Bug
>  Components: spring
>Affects Versions: 1.8
>Reporter: Sumanta Ghosh
>Assignee: Amelchev Nikita
>  Labels: newbie, patch
>
> This issue is raised in continuation with the message posted in ignite user 
> forum 
> (http://apache-ignite-users.70518.x6.nabble.com/SpringTransactionManager-Participating-in-existing-transactions-is-not-supported-td7305.html#a10624).
>  Since the doSetRollBackOnly method is not implemented in 
> SpringTransactionManager, it is not being possible to integrate with spring 
> data's ChainedTransactionManager class. A simple fix (below) would work it 
> seems (however, I did not yet tested with proper rollback test cases though, 
> this implementation at least get rid of the exception chainedtransaction 
> manager raises)
> @Override 
> protected void doSetRollbackOnly(DefaultTransactionStatus status) 
> throws TransactionException { 
> Transaction txn = 
> ((Ignite)this.getResourceFactory()).transactions().tx(); 
> if (txn!=null) txn.setRollbackOnly(); 
> }
> NOTE: This is the first time I am raising issues in apache. So, apologies if 
> all the details are not proper.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4763) doSetRollbackOnly method to be implemented in SpringTransactionManager

[Amelchev Nikita (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988669#comment-15988669
 ] 

Amelchev Nikita commented on IGNITE-4763:
-

I add test that check the doSetRollbackOnly method in existing transaction 
https://github.com/apache/ignite/pull/1884

> doSetRollbackOnly method to be implemented in SpringTransactionManager
> --
>
> Key: IGNITE-4763
> URL: https://issues.apache.org/jira/browse/IGNITE-4763
> Project: Ignite
>  Issue Type: Bug
>  Components: ignite-spring
>Affects Versions: 1.8
>Reporter: Sumanta Ghosh
>Assignee: Amelchev Nikita
>  Labels: newbie, patch
>
> This issue is raised in continuation with the message posted in ignite user 
> forum 
> (http://apache-ignite-users.70518.x6.nabble.com/SpringTransactionManager-Participating-in-existing-transactions-is-not-supported-td7305.html#a10624).
>  Since the doSetRollBackOnly method is not implemented in 
> SpringTransactionManager, it is not being possible to integrate with spring 
> data's ChainedTransactionManager class. A simple fix (below) would work it 
> seems (however, I did not yet tested with proper rollback test cases though, 
> this implementation at least get rid of the exception chainedtransaction 
> manager raises)
> @Override 
> protected void doSetRollbackOnly(DefaultTransactionStatus status) 
> throws TransactionException { 
> Transaction txn = 
> ((Ignite)this.getResourceFactory()).transactions().tx(); 
> if (txn!=null) txn.setRollbackOnly(); 
> }
> NOTE: This is the first time I am raising issues in apache. So, apologies if 
> all the details are not proper.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4763) doSetRollbackOnly method to be implemented in SpringTransactionManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988664#comment-15988664
 ] 

ASF GitHub Bot commented on IGNITE-4763:


GitHub user NSAmelchev opened a pull request:

https://github.com/apache/ignite/pull/1884

IGNITE-4763

- doSetRollbackOnly method to be implemented in SpringTransactionManager
- testDoSetRollbackOnlyInExistingTransaction

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NSAmelchev/ignite IGNITE-4763

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1884


commit bca9756cc4fbe3e89fbc29453d94619d2f90c95b
Author: NSAmelchev 
Date:   2017-02-07T14:04:02Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit fc8ed83579ee9781061490041c0cce553c9a4025
Author: NSAmelchev 
Date:   2017-03-27T12:45:44Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 1c7493cbb5de000f1c131745c90b93d7b57d4d50
Author: NSAmelchev 
Date:   2017-04-04T09:50:52Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 91703d9004a4f68bfd2ca694c93b6c3b2fb45101
Author: NSAmelchev 
Date:   2017-04-17T12:06:48Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 7e0e55e52812d605cde570ca5b50c5764d69e0fb
Author: NSAmelchev 
Date:   2017-04-25T09:27:33Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit b1c09e34d6fa9980ccbdc144de36f485ba518e7f
Author: NSAmelchev 
Date:   2017-04-26T13:17:19Z

doSetRollbackOnly method to be implemented in the SpringTransactionManager

commit 62fe1e9dee40e5d5eee2695ed9a4f0f54e1ccc10
Author: NSAmelchev 
Date:   2017-04-27T08:24:19Z

Refactoring

commit 06b55cbf15f56e31cfd6ed9bf42ebfc8caae03a8
Author: NSAmelchev 
Date:   2017-04-27T08:34:44Z

one-line javadoc

commit 827a28cba5f0f15e27daacb35f0106f420e92379
Author: NSAmelchev 
Date:   2017-04-27T08:36:17Z

one-line javadoc doSetRollbackOnly

commit d1f2a9ea1a83bd92342046aeba973fdc2b486073
Author: NSAmelchev 
Date:   2017-04-27T17:57:46Z

Merge remote-tracking branch 'refs/remotes/apache/master' into IGNITE-4763

commit 6a7ddfb4e77d4bc14b1877bfca0904b03f2917ea
Author: NSAmelchev 
Date:   2017-04-28T09:33:07Z

add testParticipatingInExistingTransactions

commit 791c2abdc42aae02183acba8d91e23ee6c08cca3
Author: NSAmelchev 
Date:   2017-04-28T10:36:33Z

Refactoring method




> doSetRollbackOnly method to be implemented in SpringTransactionManager
> --
>
> Key: IGNITE-4763
> URL: https://issues.apache.org/jira/browse/IGNITE-4763
> Project: Ignite
>  Issue Type: Bug
>  Components: ignite-spring
>Affects Versions: 1.8
>Reporter: Sumanta Ghosh
>Assignee: Amelchev Nikita
>  Labels: newbie, patch
>
> This issue is raised in continuation with the message posted in ignite user 
> forum 
> (http://apache-ignite-users.70518.x6.nabble.com/SpringTransactionManager-Participating-in-existing-transactions-is-not-supported-td7305.html#a10624).
>  Since the doSetRollBackOnly method is not implemented in 
> SpringTransactionManager, it is not being possible to integrate with spring 
> data's ChainedTransactionManager class. A simple fix (below) would work it 
> seems (however, I did not yet tested with proper rollback test cases though, 
> this implementation at least get rid of the exception chainedtransaction 
> manager raises)
> @Override 
> protected void doSetRollbackOnly(DefaultTransactionStatus status) 
> throws TransactionException { 
> Transaction txn = 
> ((Ignite)this.getResourceFactory()).transactions().tx(); 
> if (txn!=null) txn.setRollbackOnly(); 
> }
> NOTE: This is the first time I am raising issues in apache. So, apologies if 
> all the details are not proper.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4763) doSetRollbackOnly method to be implemented in SpringTransactionManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986955#comment-15986955
 ] 

ASF GitHub Bot commented on IGNITE-4763:


Github user NSAmelchev closed the pull request at:

https://github.com/apache/ignite/pull/1879


> doSetRollbackOnly method to be implemented in SpringTransactionManager
> --
>
> Key: IGNITE-4763
> URL: https://issues.apache.org/jira/browse/IGNITE-4763
> Project: Ignite
>  Issue Type: Bug
>  Components: ignite-spring
>Affects Versions: 1.8
>Reporter: Sumanta Ghosh
>Assignee: Amelchev Nikita
>  Labels: newbie, patch
>
> This issue is raised in continuation with the message posted in ignite user 
> forum 
> (http://apache-ignite-users.70518.x6.nabble.com/SpringTransactionManager-Participating-in-existing-transactions-is-not-supported-td7305.html#a10624).
>  Since the doSetRollBackOnly method is not implemented in 
> SpringTransactionManager, it is not being possible to integrate with spring 
> data's ChainedTransactionManager class. A simple fix (below) would work it 
> seems (however, I did not yet tested with proper rollback test cases though, 
> this implementation at least get rid of the exception chainedtransaction 
> manager raises)
> @Override 
> protected void doSetRollbackOnly(DefaultTransactionStatus status) 
> throws TransactionException { 
> Transaction txn = 
> ((Ignite)this.getResourceFactory()).transactions().tx(); 
> if (txn!=null) txn.setRollbackOnly(); 
> }
> NOTE: This is the first time I am raising issues in apache. So, apologies if 
> all the details are not proper.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4763) doSetRollbackOnly method to be implemented in SpringTransactionManager

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986199#comment-15986199
 ] 

ASF GitHub Bot commented on IGNITE-4763:


GitHub user NSAmelchev opened a pull request:

https://github.com/apache/ignite/pull/1879

IGNITE-4763

doSetRollbackOnly method to be implemented in SpringTransactionManager

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NSAmelchev/ignite IGNITE-4763

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1879.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1879


commit bca9756cc4fbe3e89fbc29453d94619d2f90c95b
Author: NSAmelchev 
Date:   2017-02-07T14:04:02Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit fc8ed83579ee9781061490041c0cce553c9a4025
Author: NSAmelchev 
Date:   2017-03-27T12:45:44Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 1c7493cbb5de000f1c131745c90b93d7b57d4d50
Author: NSAmelchev 
Date:   2017-04-04T09:50:52Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 91703d9004a4f68bfd2ca694c93b6c3b2fb45101
Author: NSAmelchev 
Date:   2017-04-17T12:06:48Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 7e0e55e52812d605cde570ca5b50c5764d69e0fb
Author: NSAmelchev 
Date:   2017-04-25T09:27:33Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit b1c09e34d6fa9980ccbdc144de36f485ba518e7f
Author: NSAmelchev 
Date:   2017-04-26T13:17:19Z

doSetRollbackOnly method to be implemented in the SpringTransactionManager

commit 62fe1e9dee40e5d5eee2695ed9a4f0f54e1ccc10
Author: NSAmelchev 
Date:   2017-04-27T08:24:19Z

Refactoring

commit 06b55cbf15f56e31cfd6ed9bf42ebfc8caae03a8
Author: NSAmelchev 
Date:   2017-04-27T08:34:44Z

one-line javadoc

commit 827a28cba5f0f15e27daacb35f0106f420e92379
Author: NSAmelchev 
Date:   2017-04-27T08:36:17Z

one-line javadoc doSetRollbackOnly




> doSetRollbackOnly method to be implemented in SpringTransactionManager
> --
>
> Key: IGNITE-4763
> URL: https://issues.apache.org/jira/browse/IGNITE-4763
> Project: Ignite
>  Issue Type: Bug
>  Components: ignite-spring
>Affects Versions: 1.8
>Reporter: Sumanta Ghosh
>Assignee: Amelchev Nikita
>  Labels: newbie, patch
>
> This issue is raised in continuation with the message posted in ignite user 
> forum 
> (http://apache-ignite-users.70518.x6.nabble.com/SpringTransactionManager-Participating-in-existing-transactions-is-not-supported-td7305.html#a10624).
>  Since the doSetRollBackOnly method is not implemented in 
> SpringTransactionManager, it is not being possible to integrate with spring 
> data's ChainedTransactionManager class. A simple fix (below) would work it 
> seems (however, I did not yet tested with proper rollback test cases though, 
> this implementation at least get rid of the exception chainedtransaction 
> manager raises)
> @Override 
> protected void doSetRollbackOnly(DefaultTransactionStatus status) 
> throws TransactionException { 
> Transaction txn = 
> ((Ignite)this.getResourceFactory()).transactions().tx(); 
> if (txn!=null) txn.setRollbackOnly(); 
> }
> NOTE: This is the first time I am raising issues in apache. So, apologies if 
> all the details are not proper.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)