[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276442#comment-16276442
 ] 

ASF GitHub Bot commented on IGNITE-5087:


Github user NSAmelchev closed the pull request at:

https://github.com/apache/ignite/pull/2015


> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.3
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Andrew Mashenkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080138#comment-16080138
 ] 

Andrew Mashenkov commented on IGNITE-5087:
--

Great! 
TC tests looks fine. Can be merged.

[~NSAmelchev], thanks for contribution.

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.2
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Amelchev Nikita (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078252#comment-16078252
 ] 

Amelchev Nikita commented on IGNITE-5087:
-

[~amashenkov]  I done it. It seems there are no problems at latest master.

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.2
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Andrew Mashenkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078127#comment-16078127
 ] 

Andrew Mashenkov commented on IGNITE-5087:
--

[~NSAmelchev],
.NET test fails due to timeout. I see it was failed in master earlier, but 
looks fixed right now.
Would you please merge your PR with lastest master and check .NET test again?

The rest tests looks perfect.

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.2
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Amelchev Nikita (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078067#comment-16078067
 ] 

Amelchev Nikita commented on IGNITE-5087:
-

[~amashenkov] Yesterday I checked all tests and compared with master. I dont 
see any problems.

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.2
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078049#comment-16078049
 ] 

Anton Vinogradov commented on IGNITE-5087:
--

[~amashenkov], 
Nikita checked TC, could you please recheck to make sure we did not miss 
something?

In case everything is ok please let me know and I'll merge changes to master.

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.2
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073926#comment-16073926
 ] 

Anton Vinogradov commented on IGNITE-5087:
--

[~NSAmelchev]
Please check that there is no stability drop as compared with master.

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.1
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Amelchev Nikita (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073849#comment-16073849
 ] 

Amelchev Nikita commented on IGNITE-5087:
-

[~vozerov] Yes, [TC 
tests|http://ci.ignite.apache.org/project.html?projectId=IgniteTests=projectOverview_IgniteTests=pull%2F2015%2Fhead]

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.1
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Amelchev Nikita (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066399#comment-16066399
 ] 

Amelchev Nikita commented on IGNITE-5087:
-

[~amashenkov]
I add a test in BinaryMarshallerSelfTest. I left only binary marshaller enum 
test so as change applied only the BinaryMarshaller. In addition I add test to 
BinaryEnumsSelfTest.
Please, review.

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.1
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Andrew Mashenkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066269#comment-16066269
 ] 

Andrew Mashenkov commented on IGNITE-5087:
--

Looks fine.

We should add a test in BinaryMarshallerSelfTest as well (as it done in 
attached repro with marshal-unmarshal approach) before merge to master.

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.1
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Amelchev Nikita (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066133#comment-16066133
 ] 

Amelchev Nikita commented on IGNITE-5087:
-

[~amashenkov]
I fixed it, please review

> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.1
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026380#comment-16026380
 ] 

ASF GitHub Bot commented on IGNITE-5087:


GitHub user NSAmelchev opened a pull request:

https://github.com/apache/ignite/pull/2015

IGNITE-5087

Fix Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NSAmelchev/ignite IGNITE-5087

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2015


commit bca9756cc4fbe3e89fbc29453d94619d2f90c95b
Author: NSAmelchev 
Date:   2017-02-07T14:04:02Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit fc8ed83579ee9781061490041c0cce553c9a4025
Author: NSAmelchev 
Date:   2017-03-27T12:45:44Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 1c7493cbb5de000f1c131745c90b93d7b57d4d50
Author: NSAmelchev 
Date:   2017-04-04T09:50:52Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 91703d9004a4f68bfd2ca694c93b6c3b2fb45101
Author: NSAmelchev 
Date:   2017-04-17T12:06:48Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit 7e0e55e52812d605cde570ca5b50c5764d69e0fb
Author: NSAmelchev 
Date:   2017-04-25T09:27:33Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit e603cc6107b6a972d752fb2176bf1d1461058584
Author: NSAmelchev 
Date:   2017-04-27T14:23:21Z

Merge branch 'master' of https://github.com/apache/ignite

commit e66897fddff3818c136e9d9afebe5b4bec802abe
Author: NSAmelchev 
Date:   2017-05-04T08:35:19Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit e8068b07fb8a7079385b113da821587fef4348c4
Author: NSAmelchev 
Date:   2017-05-18T10:17:40Z

Merge remote-tracking branch 'refs/remotes/apache/master'

commit fd9c2823571130cd4093a20e7d46563df6f4aade
Author: NSAmelchev 
Date:   2017-05-22T13:35:26Z

Merge branch 'master' of https://github.com/apache/ignite

commit 5dfee14838190c90155ea7a34a9d9e8f75cfb868
Author: NSAmelchev 
Date:   2017-05-26T12:46:10Z

Add fix and test for enum with declared body

commit 8e5fc52fdf998fa2af142e65823fa3b9d0bc4a2a
Author: NSAmelchev 
Date:   2017-05-26T12:55:28Z

Test refactoring

commit 1d7fa342a05e9fee7b9ef10a5b3d0289363ada6b
Author: NSAmelchev 
Date:   2017-05-26T13:52:10Z

Add method isEnum

commit 6fbf6a304f243ef80b4e1012d4c30ef15272a70e
Author: NSAmelchev 
Date:   2017-05-26T14:03:45Z

Javadoc refactor

commit 108df9521fed3d14762c2f697a791fb64dda5c11
Author: NSAmelchev 
Date:   2017-05-26T14:10:38Z

javadoc fix

commit 481e5e9ff24b23fb8616e1ce17ec47aab32c2e53
Author: NSAmelchev 
Date:   2017-05-26T14:16:51Z

Merge remote-tracking branch 'apache/master'

commit ca500a345fb1eef6ba567585d04ac8d666db
Author: NSAmelchev 
Date:   2017-05-26T14:32:54Z

Merge remote-tracking branch 'apache/master' into IGNITE-5087

# Conflicts:
#   
modules/core/src/test/java/org/apache/ignite/internal/binary/BinaryEnumsSelfTest.java

commit 305cd99e669eff149a502c221d80711399130c87
Author: NSAmelchev 
Date:   2017-05-26T14:34:58Z

Method refactor

commit cfd3250618c0b05be988000b3f456c61cf9f5b30
Author: NSAmelchev 
Date:   2017-05-26T14:39:35Z

Merge remote-tracking branch 'refs/remotes/origin/master' into IGNITE-5087




> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
>Assignee: Amelchev Nikita
> Fix For: 2.1
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-5087) Enum comparison fails after marshal-unmarshal with BinaryMarshaller.

[Andrew Mashenkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1598#comment-1598
 ] 

Andrew Mashenkov commented on IGNITE-5087:
--

Actually, we check if object is enum instance by calling 'isEnum()' method on 
class.

It works fine if it is enum constant. But enum objects type is anonymous class 
and isEnum() method on it returns false, 
that leads these object to be serialized as regular objects.

Startpoint is BinaryFieldAccessor.mode() method. 
1. It uses to detect serialization mode for field value type, but not for field 
type itself. 
2. Also, we should write enum.getDeclaredClass name instead of value class. See 
BinaryWriterImpl.doWriteEnum().



> Enum comparison fails after marshal-unmarshal with BinaryMarshaller.
> 
>
> Key: IGNITE-5087
> URL: https://issues.apache.org/jira/browse/IGNITE-5087
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 1.9
>Reporter: Andrew Mashenkov
> Fix For: 2.1
>
> Attachments: EnumBinaryMarshallerBug.java
>
>
> PFA repro.
> It fails on 1.9 and on 2.0-snapshot as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)