[jira] [Commented] (IGNITE-5562) Assertions in TCP discovery SPI when NTP is moving time backwards
[ https://issues.apache.org/jira/browse/IGNITE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082042#comment-16082042 ] Andrey Gura commented on IGNITE-5562: - Merged to master branch. Thanks for contribution. > Assertions in TCP discovery SPI when NTP is moving time backwards > - > > Key: IGNITE-5562 > URL: https://issues.apache.org/jira/browse/IGNITE-5562 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 1.7 >Reporter: Alexey Goncharuk >Assignee: Vyacheslav Koptilin > Fix For: 2.2 > > > In several places in TcpDiscoverySPI, when metrics are updated, we assert > that time is not negative. However, in some cases, this invariant may fail > because of time adjustments. > Since a missed metric is not critical for us, we should remove these > assertions and replace negative time with 0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5562) Assertions in TCP discovery SPI when NTP is moving time backwards
[ https://issues.apache.org/jira/browse/IGNITE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078022#comment-16078022 ] Vyacheslav Koptilin commented on IGNITE-5562: - Hi [~agoncharuk], Could you please take a look at the pull-request: https://github.com/apache/ignite/pull/2259 ? > Assertions in TCP discovery SPI when NTP is moving time backwards > - > > Key: IGNITE-5562 > URL: https://issues.apache.org/jira/browse/IGNITE-5562 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 1.7 >Reporter: Alexey Goncharuk >Assignee: Vyacheslav Koptilin > Fix For: 2.1 > > > In several places in TcpDiscoverySPI, when metrics are updated, we assert > that time is not negative. However, in some cases, this invariant may fail > because of time adjustments. > Since a missed metric is not critical for us, we should remove these > assertions and replace negative time with 0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5562) Assertions in TCP discovery SPI when NTP is moving time backwards
[ https://issues.apache.org/jira/browse/IGNITE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055862#comment-16055862 ] Sergey Chugunov commented on IGNITE-5562: - Thinking more generally I believe we must prohibit any assertions in metrics. We may print out warnings to logs at max. > Assertions in TCP discovery SPI when NTP is moving time backwards > - > > Key: IGNITE-5562 > URL: https://issues.apache.org/jira/browse/IGNITE-5562 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 1.7 >Reporter: Alexey Goncharuk > Fix For: 2.1 > > > In several places in TcpDiscoverySPI, when metrics are updated, we assert > that time is not negative. However, in some cases, this invariant may fail > because of time adjustments. > Since a missed metric is not critical for us, we should remove these > assertions and replace negative time with 0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
