[jira] [Commented] (IGNITE-5627) Web Console: refactor grid columns menu
[ https://issues.apache.org/jira/browse/IGNITE-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073246#comment-16073246 ] Pavel Konstantinov commented on IGNITE-5627: Tested. > Web Console: refactor grid columns menu > --- > > Key: IGNITE-5627 > URL: https://issues.apache.org/jira/browse/IGNITE-5627 > Project: Ignite > Issue Type: Sub-task > Components: UI, wizards >Reporter: Ilya Borisov >Assignee: Alexey Kuznetsov >Priority: Minor > Fix For: 2.1 > > Attachments: grid column selector.PNG > > > Currently, every menu that allows to toggle individual columns/categories has > it's own implementation. > What to do: > 1. Create a global reusable component that implements that should: > * Support cases when grid has regular columnDefs only and columnDefs with > categories. > * Not display items that are always visible/hidden. > * Have it's own default button markup which can be replaced by transclusion > slot. > * Automatically enable groups during previous groupping when user groups by > such item (old implementation had such an issue, see admin users list for > live example). For example, if first grouping was by column User with column > Email hidden, and then user switches to Email grouping, Email column should > become visible in grid and should be hidden from menu. > * Scroll enabled column/category into view. If category has multiple columns, > scroll to first column of the set. When multiple columns/categories are > enabled, do not scroll anywhere. > 2. Use new component where appropriate and remove old copypasted code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5627) Web Console: refactor grid columns menu
[ https://issues.apache.org/jira/browse/IGNITE-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069623#comment-16069623 ] Vasiliy Sisko commented on IGNITE-5627: --- Tested. Dmitry Please review. > Web Console: refactor grid columns menu > --- > > Key: IGNITE-5627 > URL: https://issues.apache.org/jira/browse/IGNITE-5627 > Project: Ignite > Issue Type: Sub-task > Components: UI, wizards >Reporter: Ilya Borisov >Assignee: Vasiliy Sisko >Priority: Minor > Attachments: grid column selector.PNG > > > Currently, every menu that allows to toggle individual columns/categories has > it's own implementation. > What to do: > 1. Create a global reusable component that implements that should: > * Support cases when grid has regular columnDefs only and columnDefs with > categories. > * Not display items that are always visible/hidden. > * Have it's own default button markup which can be replaced by transclusion > slot. > * Automatically enable groups during previous groupping when user groups by > such item (old implementation had such an issue, see admin users list for > live example). For example, if first grouping was by column User with column > Email hidden, and then user switches to Email grouping, Email column should > become visible in grid and should be hidden from menu. > * Scroll enabled column/category into view. If category has multiple columns, > scroll to first column of the set. When multiple columns/categories are > enabled, do not scroll anywhere. > 2. Use new component where appropriate and remove old copypasted code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-5627) Web Console: refactor grid columns menu
[ https://issues.apache.org/jira/browse/IGNITE-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069429#comment-16069429 ] Alexey Kuznetsov commented on IGNITE-5627: -- Looks good for me. > Web Console: refactor grid columns menu > --- > > Key: IGNITE-5627 > URL: https://issues.apache.org/jira/browse/IGNITE-5627 > Project: Ignite > Issue Type: Sub-task > Components: UI, wizards >Reporter: Ilya Borisov >Assignee: Alexey Kuznetsov >Priority: Minor > Attachments: grid column selector.PNG > > > Currently, every menu that allows to toggle individual columns/categories has > it's own implementation. > What to do: > 1. Create a global reusable component that implements that should: > * Support cases when grid has regular columnDefs only and columnDefs with > categories. > * Not display items that are always visible/hidden. > * Have it's own default button markup which can be replaced by transclusion > slot. > * Automatically enable groups during previous groupping when user groups by > such item (old implementation had such an issue, see admin users list for > live example). For example, if first grouping was by column User with column > Email hidden, and then user switches to Email grouping, Email column should > become visible in grid and should be hidden from menu. > 2. Use new component where appropriate and remove old copypasted code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
