[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[Roman Shtykh (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106933#comment-16106933
 ] 

Roman Shtykh commented on IGNITE-5706:
--

ok

> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
> Fix For: 2.2
>
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106911#comment-16106911
 ] 

Dmitriy Pavlov commented on IGNITE-5706:


Hi, could you please check compilation on CI server?
It seems last merge failed to compile.
http://ci.ignite.apache.org/project.html?projectId=Ignite20Tests_Ignite20Tests=%3Cdefault%3E

> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
> Fix For: 2.2
>
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106867#comment-16106867
 ] 

ASF GitHub Bot commented on IGNITE-5706:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2250


> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
> Fix For: 2.2
>
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[Andrey Novikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106862#comment-16106862
 ] 

Andrey Novikov commented on IGNITE-5706:


Hi [~roman_s],

If database count is not limited or big, your solution is correct. Looks good, 
please merge.

> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
> Fix For: 2.2
>
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[Roman Shtykh (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101124#comment-16101124
 ] 

Roman Shtykh commented on IGNITE-5706:
--

Hi [~anovikov],

Thank you for your comments!
I got rid of {{redisCaches}} creation and use Map from the beginning, as you 
suggested.

As for iteration over all caches, I need to find and clear all Redis caches, 
and don't know what can {{database}} be in 
{{ctx.cache().cache(CACHE_NAME_PREFIX + database)}}. It can be 1 or 1000, or 
even something else (I use it in IGNITE-5241 I am working on). How do you 
suggest to fix it?

> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
> Fix For: 2.2
>
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[Roman Shtykh (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092974#comment-16092974
 ] 

Roman Shtykh commented on IGNITE-5706:
--

[~anovikov] I implemented {{FLUSHALL}} (and {{CACHE_CLEAR}} but not for jetty). 
Can you please have a look?

> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[Andrey Novikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087187#comment-16087187
 ] 

Andrey Novikov commented on IGNITE-5706:


{{CACHE_CLEAR}} will be better. Required parameters: {{c1...cN}} - Cache names.

Also I think {{FLUSHALL}} should clear only caches used for Redis databases.

> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[Roman Shtykh (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085527#comment-16085527
 ] 

Roman Shtykh commented on IGNITE-5706:
--

Hi [~anovikov],

Yes, let's have {{FLUSHALL}} too. Do you think I can add {{CACHE_CLEAR_ALL}} 
command in REST implementation and have a ComputeJob over nodes? It might be 
useful for over-http-commands too.

> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[Andrey Novikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085374#comment-16085374
 ] 

Andrey Novikov commented on IGNITE-5706:


Hi [~roman_s],

Should we also support FLUSHALL command (https://redis.io/commands/flushall) ?
Possibly we should rename {{GridRedisFlushDbCommandHandler}} to 
{{GridRedisFlushCommandHandler}}

Everything else looks good to me

> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5706) Redis FLUSHDB command support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076023#comment-16076023
 ] 

ASF GitHub Bot commented on IGNITE-5706:


GitHub user shroman opened a pull request:

https://github.com/apache/ignite/pull/2250

IGNITE-5706: Redis FLUSHDB command support.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shroman/ignite IGNITE-5706

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2250


commit 8d36fd503f036c63fbe94e55bb4a031189afc7b9
Author: shroman 
Date:   2017-07-06T06:39:44Z

IGNITE-5706: Redis FLUSHDB command support.




> Redis FLUSHDB command support
> -
>
> Key: IGNITE-5706
> URL: https://issues.apache.org/jira/browse/IGNITE-5706
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/flushdb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)