[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550331#comment-16550331
 ] 

ASF GitHub Bot commented on IGNITE-5798:


Github user 1vanan closed the pull request at:

https://github.com/apache/ignite/pull/2957


> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
> Fix For: 2.5
>
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1646#comment-1646
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

[~ein], ok, I made ticket for it - 
https://issues.apache.org/jira/browse/IGNITE-8104.

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
> Fix For: 2.5
>
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Alexandr Kuramshin (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1640#comment-1640
 ] 

Alexandr Kuramshin commented on IGNITE-5798:


[~ivanan.fed], as you wish.

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
> Fix For: 2.5
>
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422217#comment-16422217
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

[~ein], I think, in that formulation task is resolved: Ignite Configuration is 
logged at startup [1]. We can make a ticket for proper {{toString()}} 
implementation.

[1]https://github.com/1vanan/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java#L804

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
> Fix For: 2.5
>
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Alexandr Kuramshin (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409378#comment-16409378
 ] 

Alexandr Kuramshin commented on IGNITE-5798:


[~ivanan.fed],

Earlier I've said that the every logged configuration component should have 
proper {{toString()}} implementation such the every meaningful property should 
be properly logged.

Concerning the quite mode my opinion is to ignore this setting.

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409306#comment-16409306
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

[~ein], 

I link log example with toString() method in comment above [1]. Earlier you've 
said [2] that IgniteConfiguration.toString() will be enough. So, I have several 
questions:
 # Can you explain properties that you want to see in log?
 # In 2.4 release IgniteConfiguration logging when log.isInfoEnabled() and it 
doesn't depend on IgniteLogger.quiet[3]. Do you think that it appropriate 
behavior?

[1]Permalink

[2]Permalink

[3]https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java#L1904

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Alexandr Kuramshin (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409073#comment-16409073
 ] 

Alexandr Kuramshin commented on IGNITE-5798:


[~ivanan.fed],

current implementation rely on {{toString()}}, so many and many properties 
(sub-beans) are not logged properly (use default implementation or hide some 
important properties). Did you overview actual logging occurrences in the 
production?

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407771#comment-16407771
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

[~ein], hello!

I noticed that logging IgniteConfiguration on startup was added[1] in release 
2.4. Thereby can we close this task?

[1]https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java#L1901

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234016#comment-16234016
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

IgniteConfiguration [igniteInstanceName=testAckIgniteConfigurationNonQuietMode, 
pubPoolSize=8, ..., sqlConnCfg=SqlConnectorConfiguration [host=null, 
port=10800, portRange=100, sockSndBufSize=0, sockRcvBufSize=0, tcpNoDelay=true, 
maxOpenCursorsPerConn=128, threadPoolSize=8]]


> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234012#comment-16234012
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

Output example:
IgniteConfiguration [igniteInstanceName=testAckIgniteConfigurationNonQuietMode, 
pubPoolSize=8, svcPoolSize=8, callbackPoolSize=8, stripedPoolSize=8, 
sysPoolSize=8, mgmtPoolSize=4, igfsPoolSize=8, dataStreamerPoolSize=8, 
utilityCachePoolSize=8, utilityCacheKeepAliveTime=6, p2pPoolSize=2, 
qryPoolSize=8, igniteHome=D:\workspace\ignite, 
igniteWorkDir=D:\workspace\ignite\work, 
mbeanSrv=com.sun.jmx.mbeanserver.JmxMBeanServer@5a42bbf4, 
nodeId=6efc8e60-1435-4527-8250-be8ed41aa5f7, 
marsh=org.apache.ignite.internal.binary.BinaryMarshaller@46bbde21, 
marshLocJobs=false, daemon=false, p2pEnabled=true, netTimeout=1, 
sndRetryDelay=1000, sndRetryCnt=3, metricsHistSize=1, 
metricsUpdateFreq=1000, metricsExpTime=9223372036854775807, 
discoSpi=TcpDiscoverySpi [addrRslvr=null, sockTimeout=0, ackTimeout=0, 
marsh=JdkMarshaller [], reconCnt=10, maxAckTimeout=60, forceSrvMode=false, 
clientReconnectDisabled=false], segPlc=STOP, segResolveAttempts=2, 
waitForSegOnStart=true, allResolversPassReq=true, segChkFreq=1, 
commSpi=TcpCommunicationSpi [connectGate=null, connPlc=null, 
enableForcibleNodeKill=false, enableTroubleshootingLog=false, 
srvLsnr=org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi$2@7cd0c0ee, 
locAddr=null, locHost=null, locPort=45010, locPortRange=100, shmemPort=-1, 
directBuf=true, directSndBuf=false, idleConnTimeout=60, connTimeout=5000, 
maxConnTimeout=60, reconCnt=10, sockSndBuf=32768, sockRcvBuf=32768, 
msgQueueLimit=0, slowClientQueueLimit=0, nioSrvr=null, shmemSrv=null, 
usePairedConnections=false, connectionsPerNode=1, tcpNoDelay=true, 
filterReachableAddresses=false, ackSndThreshold=32, unackedMsgsBufSize=0, 
sockWriteTimeout=2000, lsnr=null, boundTcpPort=-1, boundTcpShmemPort=-1, 
selectorsCnt=4, selectorSpins=0, addrRslvr=null, rcvdMsgsCnt=0, sentMsgsCnt=0, 
rcvdBytesCnt=0, sentBytesCnt=0, 
ctxInitLatch=java.util.concurrent.CountDownLatch@75657089[Count = 1], 
stopping=false, 
metricsLsnr=org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi$3@70fbe0fd],
 evtSpi=MemoryEventStorageSpi [expireAgeMs=9223372036854775807, 
expireCnt=1, filter=null], colSpi=NoopCollisionSpi [], 
deploySpi=LocalDeploymentSpi [lsnr=null], 
indexingSpi=org.apache.ignite.spi.indexing.noop.NoopIndexingSpi@8a3f938, 
addrRslvr=null, clientMode=false, rebalanceThreadPoolSize=1, 
txCfg=org.apache.ignite.configuration.TransactionConfiguration@1e933e45, 
cacheSanityCheckEnabled=true, discoStartupDelay=6, deployMode=SHARED, 
p2pMissedCacheSize=100, locHost=127.0.0.1, timeSrvPortBase=31100, 
timeSrvPortRange=100, failureDetectionTimeout=1, 
clientFailureDetectionTimeout=1, metricsLogFreq=0, hadoopCfg=null, 
connectorCfg=null, odbcCfg=null, warmupClos=null, atomicCfg=AtomicConfiguration 
[seqReserveSize=1000, cacheMode=PARTITIONED, backups=0, aff=null, 
grpName=null], classLdr=null, sslCtxFactory=null, platformCfg=null, 
binaryCfg=null, 
memCfg=org.apache.ignite.configuration.MemoryConfiguration@3e3823ad, 
pstCfg=null, activeOnStart=true, longQryWarnTimeout=3000, 
sqlConnCfg=SqlConnectorConfiguration [host=null, port=10800, portRange=100, 
sockSndBufSize=0, sockRcvBufSize=0, tcpNoDelay=true, maxOpenCursorsPerConn=128, 
threadPoolSize=8]]

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233818#comment-16233818
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

PR[1] for ticket IGNITE-5798 "Logging Ignite configuration at startup" is ready 
for review. 
Please find all information in attached link.
[1]https://github.com/apache/ignite/pull/2956

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233810#comment-16233810
 ] 

ASF GitHub Bot commented on IGNITE-5798:


GitHub user 1vanan opened a pull request:

https://github.com/apache/ignite/pull/2957

IGNITE-5798

Logging of IgniteConfiguration was added at startup.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1vanan/ignite IGNITE-5798

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2957


commit 9a7db6bff146eac658324661de5126969c73fcb7
Author: ivanan 
Date:   2017-09-14T21:05:48Z

Log IgniteConfiguration with reflection

commit 5826ec18bdfe3edca0d580b9d33198c42d14e32b
Author: ivanan 
Date:   2017-09-17T13:12:27Z

took into account the corrections

commit ce2d522ab8d451db23f691e1ebee425409740877
Author: ivanan 
Date:   2017-09-21T21:44:24Z

fix ackIgniteConfigurationInfo method in IgniteKernal

commit 78f9b5f0a95c0b221a6f4e3e29feed4e94d33b97
Author: ivanan 
Date:   2017-10-01T20:55:32Z

use recursive ackIgniteConfiguration

commit 868ecb3598f11856050da5f40fb3c7eb8f45d438
Author: ivanan 
Date:   2017-10-01T21:03:26Z

Revert "fix ackIgniteConfigurationInfo method in IgniteKernal"

This reverts commit ce2d522ab8d451db23f691e1ebee425409740877.

commit 3f6e10bc83a199436e1cb7e1ad7709f29956e71c
Author: ivanan 
Date:   2017-10-01T21:30:57Z

add recursive ackIgniteConfiguration

commit e4e0b2047ade273ad0f572a04fb094cd05880e3a
Author: ivanan 
Date:   2017-10-04T22:29:31Z

remove recursion

commit fab172ef257758828b736b151648d6e76697bd6e
Author: ivanan 
Date:   2017-10-06T07:13:18Z

06.10.17 fix changes

commit edff9457587ea42723677c88403e6bb83b42bfa9
Author: ivanan 
Date:   2017-10-12T06:14:15Z

remove deadlock case

commit 7fc4b8e3653dc125e6cb41b00ac370fa9bb914bf
Author: ivanan 
Date:   2017-10-12T06:26:44Z

return java.util imports instead of java.util.*

commit 2a5f7dc7ebf60899c094dabd4dd149fdc88230e6
Author: ivanan 
Date:   2017-10-13T05:27:24Z

minor code style changes

commit 3db6647d31d680467792eaaf06afe735a18ed4fa
Author: ivanan 
Date:   2017-10-17T21:34:31Z

remove Pair, fix changes

commit bfa66b0519173f5e8e1e13d108b5a19eb313ddd4
Author: Ivan 
Date:   2017-10-27T13:18:34Z

27.10.17

commit 6dd08c99edf85bed263626186ece8392eadd74f0
Author: Ivan 
Date:   2017-10-27T13:49:39Z

minor changes

commit d72e3637e214456694ebe67ce5af70d9edb35304
Author: Ivan 
Date:   2017-10-31T09:05:57Z

delete garbage methods.

commit 7d79be46e38c5488b294524786c266b43ffe1941
Author: Ivan 
Date:   2017-11-01T08:56:11Z

delete unused import

commit 6755a26a19c035686ed1e939a1c966489342e407
Author: Ivan 
Date:   2017-11-01T09:01:35Z

delete sout in test




> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233790#comment-16233790
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

Hi, Vladislav Pyatkov.
Field "walHistSize" is not included in IgniteConfiguration class, so I think 
it's necessary to create separate ticket with this problem.

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>Priority: Major
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Vladislav Pyatkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196684#comment-16196684
 ] 

Vladislav Pyatkov commented on IGNITE-5798:
---

Hi, 
Just I have faced with the same issue.
I can not able to verify "WAL history size" after grid is had been started.
We should to show this configuration at start (may by only if it is different 
from default).

{{org.apache.ignite.configuration.PersistentStoreConfiguration#walHistSize}}


> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Alexandr Kuramshin (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196668#comment-16196668
 ] 

Alexandr Kuramshin commented on IGNITE-5798:


Hi, [~ivanan.fed]

1. I think we should use output of {{IgniteConfiguration.toString()}} which 
implemented by standard call to 
{{GridToStringBuilder#toString(java.lang.Class, T)}}. The maximum 
inheritance level will be used. Every object being logged takes own 
responsibility to have right {{toString()}} implementation. You may check 
proper {{@GridToStringInclude}} and {{@GridToStringExclude}} annotation usage 
on all enclosed configuration objects.

2. Null values also should be logged.

3. Relates to question #1.

4. When {{IgniteLogger.quiet == true}} we should not log 
{{IgniteConfiguration}}. Only when {{IgniteLogger.quiet == false}}.

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Alexander Belyak (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196639#comment-16196639
 ] 

Alexander Belyak commented on IGNITE-5798:
--

1) I think you should log as many configuration options as you can
2) Don't sure, I prefer to log such fields for simplify grep for some parameter 
value
3) -
4) Yes, IMHO

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5798) Logging Ignite configuration at startup

[Ivan Fedotov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189346#comment-16189346
 ] 

Ivan Fedotov commented on IGNITE-5798:
--

Hello!
Now I’m working at ticket #5798 “Logging Ignite configuration at startup” and 
have the following questions:
1.Should I get fields and their values only from IgniteConfiguration or I 
should also get them from inherited classes? If second variant is correct , 
what level of inheritance should I use?
2.Should I log fields with null values?
3.Is format [field] : [value.toString] appropriate? Or [field] : 
[GridToStringBuilder.toString(value)] is better?
4.About “I’ve found that IgniteConfiguration is not logged even when 
-DIGNITE_QUIET=false”. Does it mean that I should log IgniteConfiguration when 
log.isQuiet = false to the file and terminal?

> Logging Ignite configuration at startup
> ---
>
> Key: IGNITE-5798
> URL: https://issues.apache.org/jira/browse/IGNITE-5798
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexandr Kuramshin
>Assignee: Ivan Fedotov
>  Labels: easyfix, newbie
>
> I've found that IgniteConfiguration is not logged even when 
> -DIGNITE_QUIET=false
> When we starting Ignite with path to the xml, or InputStream, we have to 
> ensure, that all configuration options were properly read. And also we would 
> like to know actual values of uninitialized configuration properties (default 
> values), which will be set only after Ignite get started.
> Monitoring tools, like Visor or WebConsole, do not show all configuration 
> options. And even though they will be updated to show all properties, when 
> new configuration options appear, then tools update will be needed.
> Logging IgniteConfiguration at startup gives a possibility to ensure that the 
> right grid configuration has been applied and leads to better user support 
> based on log analyzing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)