[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156824#comment-16156824
 ] 

ASF GitHub Bot commented on IGNITE-5855:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2512


> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Fix For: 2.3
>
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[Ilya Kasnacheev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153736#comment-16153736
 ] 

Ilya Kasnacheev commented on IGNITE-5855:
-

https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_IgniteJdbcDriver_Ignite20Tests=pull%2F2512%2Fhead=buildTypeStatusDiv
 JDBC tests pass

> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Fix For: 2.3
>
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[Taras Ledkov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153643#comment-16153643
 ] 

Taras Ledkov commented on IGNITE-5855:
--

Looks good to me. What about tests results?

> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Fix For: 2.3
>
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[Ilya Kasnacheev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150224#comment-16150224
 ] 

Ilya Kasnacheev commented on IGNITE-5855:
-

[~tledkov] please take a look at the amended fix

> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[Ilya Kasnacheev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147061#comment-16147061
 ] 

Ilya Kasnacheev commented on IGNITE-5855:
-

I have updated my pull request. Now fixes the specific issue only without other 
changes.

> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[Ilya Kasnacheev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141524#comment-16141524
 ] 

Ilya Kasnacheev commented on IGNITE-5855:
-

Unfortunately I'm retracting that patch, it doesn't work as expected.

> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Fix For: 2.2
>
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[Ilya Kasnacheev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140250#comment-16140250
 ] 

Ilya Kasnacheev commented on IGNITE-5855:
-

[~vozerov] please take a look.

> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Fix For: 2.2
>
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140249#comment-16140249
 ] 

ASF GitHub Bot commented on IGNITE-5855:


GitHub user alamar opened a pull request:

https://github.com/apache/ignite/pull/2512

IGNITE-5855 Type-safe parameters setting fixes crash when querying 
BigInteger key



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-5855

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2512.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2512


commit 643f2e58415525a75c3630f8d2f174065db9a0e0
Author: Ilya Kasnacheev 
Date:   2017-08-24T16:17:04Z

IGNITE-5855 Type-safe parameters setting fixes crash when querying 
BigInteger key




> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Fix For: 2.2
>
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5855) SQL: BigInteger support broken in SQL queries.

[Ilya Kasnacheev (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140229#comment-16140229
 ] 

Ilya Kasnacheev commented on IGNITE-5855:
-

The offender here is H2's ValueDecimal class:

It doesn't override Value's covertTo(), so when it is asked to be converted to 
Java object, it returns
{code}
return ValueJavaObject.getNoCopy(null,
StringUtils.convertHexToBytes(getString().trim()), 
getDataHandler());
{code}

Instead of sensible "if (targetType == JAVA_OBJECT) return value;" as one might 
imagine.

So we will have to do the check outside of H2 code.


> SQL: BigInteger support broken in SQL queries.
> --
>
> Key: IGNITE-5855
> URL: https://issues.apache.org/jira/browse/IGNITE-5855
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.0, 2.1
>Reporter: Andrew Mashenkov
>Assignee: Ilya Kasnacheev
> Fix For: 2.2
>
> Attachments: BigIntegerKeySqlTest.java
>
>
> Looks like BigInteger support in SQL was broken.
> It works fine on ignite-1.9
> PFA reproducer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)