[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189720#comment-16189720
 ] 

Andrey Kuznetsov commented on IGNITE-6520:
--

Thanks, [~dpavlov]. Probably I have less permissions than you and I can't 
mute/unmute explicitly.

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
> Attachments: unmute.jpg.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189705#comment-16189705
 ] 

Dmitriy Pavlov commented on IGNITE-6520:


Hi [~andrey-kuznetsov], there is second option related to muted state
!unmute.jpg.png!

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
> Attachments: unmute.jpg.png
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189614#comment-16189614
 ] 

Andrey Kuznetsov commented on IGNITE-6520:
--

[~dpavlov], I've marked this test as fixed on TC, but it's still visible in 
'muted problems' tab for some reason. Please check its state.

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188041#comment-16188041
 ] 

Dmitriy Pavlov commented on IGNITE-6520:


Hi [~andrey-kuznetsov], could I ask you to unmute test(s) when it fixed? 
Alternatively you can notify me and I will unmute test.

As far as I see now test described in this ticket is passing: 
https://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_IgniteCacheRestarts2_Ignite20Tests=%3Cdefault%3E=buildTypeStatusDiv
may be we can unmute it now.


> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187978#comment-16187978
 ] 

Andrey Kuznetsov commented on IGNITE-6520:
--

[~dpavlov], we have another issue related to this test method -- IGNITE-6006. I 
coudn't reproduce failure described there, so I need some extra time to 
investigate it.

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Dmitriy Pavlov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187970#comment-16187970
 ] 

Dmitriy Pavlov commented on IGNITE-6520:


Is it possible to unmute IgniteCacheGetRestartTest.testGetRestartReplicated() ? 
Or should we wait for additional fixes?

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187917#comment-16187917
 ] 

ASF GitHub Bot commented on IGNITE-6520:


Github user andrey-kuznetsov closed the pull request at:

https://github.com/apache/ignite/pull/2781


> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Semen Boikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187900#comment-16187900
 ] 

Semen Boikov commented on IGNITE-6520:
--

[~andrey-kuznetsov], such 'fix' with try/catch (Throwable e) is ugly. If we fix 
hangs in such way then we will end up with try/catch around every method call 
in Ignite. If there are problems with internal nodesByPartition API then this 
API should be fixed instead.

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187829#comment-16187829
 ] 

Andrey Kuznetsov commented on IGNITE-6520:
--

[~sboikov], could you please tell why frozen-forever future is better than 
failed one (in case of RuntimeException)?

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
> Fix For: 2.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187789#comment-16187789
 ] 

Andrey Kuznetsov commented on IGNITE-6520:
--

[~sboikov], thanks for your review.

Initially, flaky timeouts were caused by IllegalStateException in 
GridAffinityAssignmentCache::cachedAffinity which propagated up to 
GridPartitionedSingleGetFuture::mapKeyToNode and prevented the future from 
completion. First, I caught this possible exception, and test became to fail 
instead of hanging. Then I fixed the reason of IllegalStateException itself.

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Semen Boikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187758#comment-16187758
 ] 

Semen Boikov commented on IGNITE-6520:
--

[~andrey-kuznetsov], changes related to affinity ready future look good, I 
merged this fix (also I fixed the same issue for GridNearGetFuture).

But could you please explain:
- what was the reason of hangs in IgniteCacheGetRestartTest
- you added try/catch in mapKeyToNode, what exception is thrown there?

Thanks

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[Andrey Kuznetsov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185960#comment-16185960
 ] 

Andrey Kuznetsov commented on IGNITE-6520:
--

[~sboikov], please take a look at PR. It fixes this very issue, and if my logic 
is OK, then we are to revise other AffinityReadyFuture usages.

> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6520) IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185932#comment-16185932
 ] 

ASF GitHub Bot commented on IGNITE-6520:


GitHub user andrey-kuznetsov opened a pull request:

https://github.com/apache/ignite/pull/2781

IGNITE-6520: Using actual AffinityReadyFuture result.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrey-kuznetsov/ignite ignite-6520

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2781.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2781


commit 568b002006b8d5ddf4b72a7cbebc6d394b3ac240
Author: Andrey Kuznetsov 
Date:   2017-09-29T14:46:23Z

IGNITE-6520: Using actual AffinityReadyFuture result.




> IgniteCacheGetRestartTest.testGetRestartReplicated fails sometimes (timeout)
> 
>
> Key: IGNITE-6520
> URL: https://issues.apache.org/jira/browse/IGNITE-6520
> Project: Ignite
>  Issue Type: Bug
>Affects Versions: 2.2
>Reporter: Andrey Kuznetsov
>Assignee: Andrey Kuznetsov
>  Labels: MakeTeamcityGreenAgain
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)