[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465991#comment-16465991 ] Roman Meerson commented on IGNITE-6879: --- [~dpavlov] I faced with same problem and it fixed by changing spring version to old one. We couldn`t just add two version because if we do so we have to duplicate *ignite-spring* module and live with 2 modules for spring and with 2 moodules for spring data. With old spring version tests of both modules works good > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > Fix For: 2.6 > > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465945#comment-16465945 ] Dmitriy Pavlov commented on IGNITE-6879: Same ocurred on TeamCity [https://ci.ignite.apache.org/viewLog.html?buildId=1272331&] > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > Fix For: 2.6 > > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[
https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465896#comment-16465896
]
Dmitriy Pavlov commented on IGNITE-6879:
Hi [~homich], I've checked changes and it looks good to me, but I've faced with
tests failures for old spring data version
{noformat}
java.lang.NoClassDefFoundError:
org/springframework/beans/factory/config/BeanDefinitionCustomizer
at
org.springframework.context.annotation.AnnotatedBeanDefinitionReader.registerBean(AnnotatedBeanDefinitionReader.java:145)
at
org.springframework.context.annotation.AnnotatedBeanDefinitionReader.register(AnnotatedBeanDefinitionReader.java:135)
at
org.springframework.context.annotation.AnnotationConfigApplicationContext.register(AnnotationConfigApplicationContext.java:158)
at
org.apache.ignite.springdata.IgniteSpringDataCrudSelfTest.beforeTestsStarted(IgniteSpringDataCrudSelfTest.java:49)
at
org.apache.ignite.testframework.junits.GridAbstractTest.setUp(GridAbstractTest.java:611)
at
org.apache.ignite.testframework.junits.common.GridCommonAbstractTest.setUp(GridCommonAbstractTest.java:490)
at junit.framework.TestCase.runBare(TestCase.java:139)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Caused by: java.lang.ClassNotFoundException:
org.springframework.beans.factory.config.BeanDefinitionCustomizer
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 21 more{noformat}
Can it be solved? My guess it can be done with some modules dependencies
separation, e.g.
spring43.version for old module.
spring.version
could you please address?
> Support Spring 2.0
> --
>
> Key: IGNITE-6879
> URL: https://issues.apache.org/jira/browse/IGNITE-6879
> Project: Ignite
> Issue Type: Improvement
> Components: spring
>Affects Versions: 2.3
>Reporter: Alexey Kukushkin
>Assignee: Roman Meerson
>Priority: Major
>
> Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt
> with Spring 2.0. Trying to change the Spring dependency version to
> 2.0.0.release results in compile errors like below and requires regression in
> general.
> This improvement was created to either migrate from Spring 1.1 to 2.0 or
> create another set of modules ignite-spring-xxx-2 to have backward
> compatibility with Spring 1.1.
> [ERROR]
> /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10]
> name clash: deleteAll(java.lang.Iterable) in
> org.apache.ignite.springdata.repository.IgniteRepository and
> deleteAll(java.lang.Iterable) in
> org.springframework.data.repository.CrudRepository have the same erasure, yet
> neither overrides the other
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464225#comment-16464225 ] Dmitriy Pavlov commented on IGNITE-6879: [~homich], sorry it seems upsorce does not show corrected files (probably master was merged into branch), I've tried to fetch PR and I see the changes. > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464060#comment-16464060 ] Dmitriy Pavlov commented on IGNITE-6879: [~homich], I've found comment which seems to be not addressed yet, [https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541?commentId=de43c65f-9ac7-4080-9904-aec119138c94&filePath=/modules/spring-data-2.0/src/main/java/org/apache/ignite/springdata/repository/query/IgniteQueryGenerator.java] Can solution meet this proposal? > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426942#comment-16426942 ] Ryabov Dmitrii commented on IGNITE-6879: Ok for me. > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426920#comment-16426920 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] done > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426867#comment-16426867 ] Ryabov Dmitrii commented on IGNITE-6879: I know, you just copied Spring module, but such tickets are the only way to make codestyle fixes and minor refactoring in the whole module. > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417087#comment-16417087 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] done > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417052#comment-16417052 ] Ryabov Dmitrii commented on IGNITE-6879: Javadoc is broken [1] "IgniteRepository.java:50: warning - Tag @link: can't find save(Iterable) in org.springframework.data.repository.CrudRepository" Also check `JdbcThinConnectionSSLTest.testDefaultContext()` [2], because it failed only in your PR. I'm not sure that it is your bad, if this fail is not by your changes I recommend you to merge master into your PR branch again [1] https://ci.ignite.apache.org/viewLog.html?buildId=1163086&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Javadoc [2] https://ci.ignite.apache.org/viewLog.html?buildId=1163057&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteJdbcDriver > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416909#comment-16416909 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] all tests passed [https://ci.ignite.apache.org/viewLog.html?buildId=1161937&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteSpringData] https://ci.ignite.apache.org/viewLog.html?buildId=1161938&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteExamples > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415497#comment-16415497 ] Ryabov Dmitrii commented on IGNITE-6879: Next time try to reset your master for an older commit and update it carefully. Now start the tests and let me know when they will be finished. > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415486#comment-16415486 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] was problem with reverting, so pull request automatically closed, i made merging and open new one > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415485#comment-16415485 ] Ryabov Dmitrii commented on IGNITE-6879: [~homich], you can do it! I believe in you! > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415484#comment-16415484 ] ASF GitHub Bot commented on IGNITE-6879: GitHub user homich1991 opened a pull request: https://github.com/apache/ignite/pull/3704 IGNITE-6879 and migration to spring-data 2.0.5.RELEASE Fixed IGNITE-6879 Migrated to spring-data 2.0.5.RELEASE Migrated to spring 5.0.4.RELEASE Fixed overrided methods naming -- was problem with merging master in previous one https://github.com/apache/ignite/pull/3628, so created this one You can merge this pull request into a Git repository by running: $ git pull https://github.com/homich1991/ignite ignite-6879 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3704.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3704 commit ae280108fad94d42a04d8b955262178ef6a365dd Author: Roman_Meerson Date: 2018-03-13T15:32:46Z Fixed IGNITE-6879 Migrated to spring-data 2.0.5.RELEASE Migrated to spring 5.0.4.RELEASE Fixed overrided methods naming commit f090873961609dc0177172b0ea0a05efc4c462f8 Author: Roman_Meerson Date: 2018-03-13T18:34:17Z Fixed tests commit 2b16d5224290f81cd7949643c8c98b8a4e2b3c4f Author: Roman_Meerson Date: 2018-03-13T20:46:19Z Fixed sorting problem (added UNSORTED option) Fixed bean loading order. Now repositories are loaded only via factory and not by them selves. commit 4ca587129cc91d0a10642ab88e8469bdec4a5d92 Author: Roman_Meerson Date: 2018-03-22T18:44:17Z Fixed comments on PR commit 62f57f920eb3e57f036e664d3334dc9f3f6f599d Author: Roman_Meerson Date: 2018-03-25T15:10:54Z Fixed comments on PR commit e4c443198d52b70912d4ce06fb74c1acd726dad3 Author: Roman_Meerson Date: 2018-03-25T18:30:55Z Fixed spring data examples commit df3fc87a815b816ad599a9872d479b3d63cd028f Author: Roman_Meerson Date: 2018-03-25T18:34:50Z Fixed check style comments in ConditionFalse class commit 1ab3d63cceff5646f9d9d24cec952bd02615a818 Author: Roman_Meerson Date: 2018-03-25T19:25:24Z Return null instead of exception throwing commit b118dc23b65d2d6a28512ec19fa90cb779ffc793 Author: Roman_Meerson Date: 2018-03-27T11:56:54Z Merge branch 'master' into ignite-6879 > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415455#comment-16415455 ] ASF GitHub Bot commented on IGNITE-6879: Github user homich1991 closed the pull request at: https://github.com/apache/ignite/pull/3628 > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415355#comment-16415355 ] Ryabov Dmitrii commented on IGNITE-6879: Now your PR contains 86 commits) Try this way [1]. Your PR should contain only your changes, but not changes already peresented in the master branch. [1] https://help.github.com/articles/syncing-a-fork/ > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415236#comment-16415236 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] Sorry. I`m new in Github Fetching. Made upstream fecth and made merging > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415221#comment-16415221 ] Ryabov Dmitrii commented on IGNITE-6879: Every day someone commits to Ignite. As I see [1] your branch is 73 commits behind of master. You should fetch changes for apache master to see latest commits, update your master and then update PR branch. [1] https://reviews.ignite.apache.org/ignite/branch/PR%203628 > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415135#comment-16415135 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] I just checked my branch it`s also rebased from current master top > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414227#comment-16414227 ] Ryabov Dmitrii commented on IGNITE-6879: You should merge master to your PR branch (or rebase branch onto master), so, current PR will be updated. > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414218#comment-16414218 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] am I understand you right that you want me to merge my branch to master and made another pr? Is it ok for PR flow? > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414212#comment-16414212 ] Ryabov Dmitrii commented on IGNITE-6879: As I see [1] something still wrong. And seems like it was wrong before your commits [2]. Merge with current master and start tests again. [1] https://ci.ignite.apache.org/viewLog.html?buildId=1158698&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteExamples [2] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_IgniteExamples&page=1&tab=buildTypeHistoryList&branch_IgniteTests24Java8= > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413124#comment-16413124 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] Thanks for pointing. Fixed. As well as comments on ConditionFalse class > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413112#comment-16413112 ] Ryabov Dmitrii commented on IGNITE-6879: [~homich], thank you for changes. I see failed test on TC - SpringDataExample.java:[111,29] cannot find symbol [1]. You should change spring example too. [1] https://ci.ignite.apache.org/viewLog.html?buildId=1157885&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteSpring > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413072#comment-16413072 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] another portion of update based on your comments > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410103#comment-16410103 ] Roman Meerson commented on IGNITE-6879: --- [~SomeFire] Thanks for review, I fixed all your comments > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409816#comment-16409816 ] Ryabov Dmitrii commented on IGNITE-6879: [~homich], I looked your PR and left some comments. Please, fix them. > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Assignee: Roman Meerson >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397120#comment-16397120 ] ASF GitHub Bot commented on IGNITE-6879: GitHub user homich1991 opened a pull request: https://github.com/apache/ignite/pull/3628 IGNITE-6879 and migration to spring-data 2.0.5.RELEASE Fixed IGNITE-6879 Migrated to spring-data 2.0.5.RELEASE Migrated to spring 5.0.4.RELEASE Fixed overrided methods naming You can merge this pull request into a Git repository by running: $ git pull https://github.com/homich1991/ignite ignite-6879 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3628.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3628 commit ae280108fad94d42a04d8b955262178ef6a365dd Author: Roman_Meerson Date: 2018-03-13T15:32:46Z Fixed IGNITE-6879 Migrated to spring-data 2.0.5.RELEASE Migrated to spring 5.0.4.RELEASE Fixed overrided methods naming > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6879) Support Spring 2.0
[ https://issues.apache.org/jira/browse/IGNITE-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371560#comment-16371560 ] Robert Wruck commented on IGNITE-6879: -- [https://github.com/tweerlei/ignite-spring-data-2] This is for Ignite 2.3.0. I could try to make a pull request for 2.4.0-SNAPSHOT > Support Spring 2.0 > -- > > Key: IGNITE-6879 > URL: https://issues.apache.org/jira/browse/IGNITE-6879 > Project: Ignite > Issue Type: Improvement > Components: spring >Affects Versions: 2.3 >Reporter: Alexey Kukushkin >Priority: Major > > Ignite-spring and ignite-spring-data now use Spring 1.1 and cannot be rebuilt > with Spring 2.0. Trying to change the Spring dependency version to > 2.0.0.release results in compile errors like below and requires regression in > general. > This improvement was created to either migrate from Spring 1.1 to 2.0 or > create another set of modules ignite-spring-xxx-2 to have backward > compatibility with Spring 1.1. > [ERROR] > /Users/kukushal/Dev/incubator-ignite/modules/spring-data/src/main/java/org/apache/ignite/springdata/repository/IgniteRepository.java:[57,10] > name clash: deleteAll(java.lang.Iterable) in > org.apache.ignite.springdata.repository.IgniteRepository and > deleteAll(java.lang.Iterable) in > org.springframework.data.repository.CrudRepository have the same erasure, yet > neither overrides the other -- This message was sent by Atlassian JIRA (v7.6.3#76005)
