[jira] [Commented] (IGNITE-6946) Change Ignite Logger configuration on the fly
[ https://issues.apache.org/jira/browse/IGNITE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341184#comment-16341184 ] Stanislav Lukyanov commented on IGNITE-6946: [~vkulichenko], I've pushed a new version. It contains the fix for the issue with log4j2.xml you've mentioned, new test for log4j2 + some small fixes and polishing. > Change Ignite Logger configuration on the fly > - > > Key: IGNITE-6946 > URL: https://issues.apache.org/jira/browse/IGNITE-6946 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.3 >Reporter: Alexey Popov >Assignee: Stanislav Lukyanov >Priority: Major > > It would be great if we can change Ignite Logger configuration on the fly > without restarting the cluster node. It will really help to debug an issue > while it is reproducible at the current cluster state. > It should be done within the configured type of a logger, i.e. it is enough > to change logging levels without changing the Logger type itself. > Such configuration change should be done for all supported logger types (JUL, > log4j, log4i2 and others). > Also it should be done easily, for instance, via Visor, WebConsole or any > other user-friendly tool ). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6946) Change Ignite Logger configuration on the fly
[ https://issues.apache.org/jira/browse/IGNITE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340690#comment-16340690 ] Stanislav Lukyanov commented on IGNITE-6946: [~vkulichenko], > I think you should add tests for other loggers as well. We only have our own code for log4j 1.x here. With log4j2 we just use its own configuration capabilitites, and JUL and slf4j are not affected by this change at all. Do you want me to add a test for log4j2? We can have a test similar to the log4j's, but it would mostly be about us not breaking anything in Log4J2Logger - and I can't really imagine how could we break something there (there's just no API for breaking that) :) > Also there are some other changes in log4j.xml which I believe are there by > accident. Yes, you're right, that's a leftover from some experiments - sorry for that. FIxed. > Change Ignite Logger configuration on the fly > - > > Key: IGNITE-6946 > URL: https://issues.apache.org/jira/browse/IGNITE-6946 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.3 >Reporter: Alexey Popov >Assignee: Stanislav Lukyanov >Priority: Major > > It would be great if we can change Ignite Logger configuration on the fly > without restarting the cluster node. It will really help to debug an issue > while it is reproducible at the current cluster state. > It should be done within the configured type of a logger, i.e. it is enough > to change logging levels without changing the Logger type itself. > Such configuration change should be done for all supported logger types (JUL, > log4j, log4i2 and others). > Also it should be done easily, for instance, via Visor, WebConsole or any > other user-friendly tool ). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6946) Change Ignite Logger configuration on the fly
[ https://issues.apache.org/jira/browse/IGNITE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340231#comment-16340231 ] Valentin Kulichenko commented on IGNITE-6946: - [~slukyanov], I think you should add tests for other loggers as well. Other than that looks good. Also there are some other changes in log4j.xml which I believe are there by accident? If there are done on purpose, can you please explain them? > Change Ignite Logger configuration on the fly > - > > Key: IGNITE-6946 > URL: https://issues.apache.org/jira/browse/IGNITE-6946 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.3 >Reporter: Alexey Popov >Assignee: Stanislav Lukyanov >Priority: Major > > It would be great if we can change Ignite Logger configuration on the fly > without restarting the cluster node. It will really help to debug an issue > while it is reproducible at the current cluster state. > It should be done within the configured type of a logger, i.e. it is enough > to change logging levels without changing the Logger type itself. > Such configuration change should be done for all supported logger types (JUL, > log4j, log4i2 and others). > Also it should be done easily, for instance, via Visor, WebConsole or any > other user-friendly tool ). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6946) Change Ignite Logger configuration on the fly
[ https://issues.apache.org/jira/browse/IGNITE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330666#comment-16330666 ] Stanislav Lukyanov commented on IGNITE-6946: After some research, it seems that we can update logger configurations for JUL, log4j, log4j2 (+ SLF4J backed by these loggers) on the fly out of the box. JUL allows to do that via an MXBean. Log4j and log4j2 can be configured to watch changes of the log4j.xml or log4j2.xml file, picking up new configuration if it has changed. For Log4j we need a small code update in Ignite to enable this. For Log4j2 no updates are required per se, but it would be nice to enable config changes watches in the default config file (ignite-log4j2.xml). > Change Ignite Logger configuration on the fly > - > > Key: IGNITE-6946 > URL: https://issues.apache.org/jira/browse/IGNITE-6946 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.3 >Reporter: Alexey Popov >Assignee: Stanislav Lukyanov >Priority: Major > > It would be great if we can change Ignite Logger configuration on the fly > without restarting the cluster node. It will really help to debug an issue > while it is reproducible at the current cluster state. > It should be done within the configured type of a logger, i.e. it is enough > to change logging levels without changing the Logger type itself. > Such configuration change should be done for all supported logger types (JUL, > log4j, log4i2 and others). > Also it should be done easily, for instance, via Visor, WebConsole or any > other user-friendly tool ). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6946) Change Ignite Logger configuration on the fly
[ https://issues.apache.org/jira/browse/IGNITE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320344#comment-16320344 ] Alexey Popov commented on IGNITE-6946: -- Could be added to: https://cwiki.apache.org/confluence/display/IGNITE/Allow+Configuration+Settings+Change+At+Runtime > Change Ignite Logger configuration on the fly > - > > Key: IGNITE-6946 > URL: https://issues.apache.org/jira/browse/IGNITE-6946 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.3 >Reporter: Alexey Popov > > It would be great if we can change Ignite Logger configuration on the fly > without restarting the cluster node. I will really help to debug an issue > while it is reproducible at the current cluster state. > It should be done within the configured type of a logger, i.e. it is enough > to change logging levels without changing the Logger type itself. > Such configuration change should be done for all supported logger types (JUL, > log4j, log4i2 and others). > Also it should be done easily, for instance, via Visor, WebConsole or any > other user-friendly tool ). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
